All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: "Pali Rohár" <pali@kernel.org>, "Marek Behún" <kabel@kernel.org>
Cc: u-boot@lists.denx.de, "Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: fix leaked mtd device
Date: Mon, 27 Sep 2021 07:40:34 +0200	[thread overview]
Message-ID: <11c89e42-ab98-6e2c-3829-e9747c76e147@denx.de> (raw)
In-Reply-To: <20210925160544.iqa34oz5ezlhbxr4@pali>

On 25.09.21 18:05, Pali Rohár wrote:
> On Saturday 25 September 2021 02:49:18 Marek Behún wrote:
>> From: Marek Behún <marek.behun@nic.cz>
>>
>> After getting MTD device via get_mtd_device_nm(), we need to put it with
>> put_mtd_device(), otherwise we get
>>
>>    Removing MTD device #0 (mx25l6405d) with use count 1
>>
>> before booting kernel.
>>
>> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> 
> Reviewed-by: Pali Rohár <pali@kernel.org>
> Tested-by: Pali Rohár <pali@kernel.org>
> Fixes: 92f36c8e74c1 ("arm: mvebu: turris_omnia: fixup MTD partitions in Linux' DTB")
> 
> Above commit was introduced in v2021.10-rc1, so I think this fixup
> should go into v2021.10.
> 
> Stefan, what do you think?

Makes sense. I'll push this out today.

Thanks,
Stefan

>> ---
>>   board/CZ.NIC/turris_omnia/turris_omnia.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
>> index bac78af04e..a48e1f5c30 100644
>> --- a/board/CZ.NIC/turris_omnia/turris_omnia.c
>> +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
>> @@ -647,10 +647,13 @@ int ft_board_setup(void *blob, struct bd_info *bd)
>>   	if (!fixup_mtd_partitions(blob, node, mtd))
>>   		goto fail;
>>   
>> +	put_mtd_device(mtd);
>>   	return 0;
>>   
>>   fail:
>>   	printf("Failed fixing SPI NOR partitions!\n");
>> +	if (!IS_ERR_OR_NULL(mtd))
>> +		put_mtd_device(mtd);
>>   	return 0;
>>   }
>>   #endif
>> -- 
>> 2.32.0
>>


Viele Grüße,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de

  reply	other threads:[~2021-09-27  5:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25  0:49 [PATCH u-boot-marvell] arm: mvebu: turris_omnia: fix leaked mtd device Marek Behún
2021-09-25 16:05 ` Pali Rohár
2021-09-27  5:40   ` Stefan Roese [this message]
2021-09-27  5:39 ` Stefan Roese
2021-09-27  5:48 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11c89e42-ab98-6e2c-3829-e9747c76e147@denx.de \
    --to=sr@denx.de \
    --cc=kabel@kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=pali@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.