From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753049AbdLHVeH (ORCPT ); Fri, 8 Dec 2017 16:34:07 -0500 Received: from gmmr3.centrum.cz ([46.255.225.251]:46849 "EHLO gmmr3.centrum.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289AbdLHVeG (ORCPT ); Fri, 8 Dec 2017 16:34:06 -0500 X-Original-From: marek_tomas@centrum.cz X-Original-IP: 178.17.4.74 Subject: Re: [PATCH v2] Staging: pi433: fix brace coding style issues in pi433_if.c To: Greg KH Cc: devel@driverdev.osuosl.org, joe@perches.com, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com References: <1512420010-20240-1-git-send-email-marek_tomas@centrum.cz> <20171206150123.GA9143@kroah.com> From: Tomas Marek Message-ID: <11cac73a-90f0-f4c3-069f-711526ed55eb@centrum.cz> Date: Fri, 8 Dec 2017 13:34:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171206150123.GA9143@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2017 07:01 AM, Greg KH wrote: > On Mon, Dec 04, 2017 at 09:40:10PM +0100, Tomas Marek wrote: >> This patch fix several brace on next line, braces not necessary, space >> around =/<, and space before/after open/close parenthesis coding style >> errors find by checkpatch in pi433_if.c. >> >> In addition, the interrupt routine DIO0_irq_handler logic is updated: >> - use 'switch' statement instead of 'if/else if' combination for the >> sake of readability, and >> - use dev_dbg_ratelimited instead of dev_dbg to avoid message flooding. > When you have to add "in addition" to a changelog comment, that's a huge > flag that the patch needs to be broken up into a patch series. Please > do that here, only doing one "logical" thing at a time. As it is, it's > hard to review this way. > > thanks, > > greg k-h OK, I see, no problem. Thanks Tomas