From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FAFC433F5 for ; Wed, 10 Nov 2021 00:18:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD41D611F0 for ; Wed, 10 Nov 2021 00:18:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AD41D611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=prevas.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 125C8836D9; Wed, 10 Nov 2021 01:18:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="I4pBN15t"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 855E9837F2; Wed, 10 Nov 2021 01:18:38 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0729.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::729]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 850E5836D9 for ; Wed, 10 Nov 2021 01:18:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fh+/eCW4MJm5qcDXnbKEel6JstLkA8u/NJlCFvLEaeHEIbMJ+gFWRLfnV2MDnCCeANAwGFYJWeAn6zJEVhSaNJNP+uJxilwzzTekFSuTWVmcw8DaaKu1+EJe1sjH4x8OAA3Sveqi+L/6AfTm+IxjyJ5T0PojKaY1J0Sll5ayGeNB6K5QZMCLF6yKSQLElHMwbBbrNaRLGQtGFZfeL7Io04/RKvrtRK6vw7PlnbIVUCavgENrkut59BtrRZkRLGdX/KmcPsUUrXNjnvnpO4IeXBRYAC88SYfEa4uzvU2GjvyYlYypg9jIk+w3RomY0jES1KpyveeOChzqkS4LHT49bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qG1sWHInHgchamRi6gODhQMJns+HngtaAQRrlPivcJc=; b=e4wwhZ3CqodVb9oS5cQYOLN0me7lt7X0LeRcd4toRnCc3zhB4QMCV2YTUAidCJ0tztEG1xI/WqCOLVXzs7XZRUkj0voCKfUkeuEtFK+gYnK+XnMjd6MlHfFaUxQKEkB7DHoLUCLGxR0iRBjduJGyTJhZLSPcXy1DxYyK05GrzGf3bqUbh8jR49L9OTDPfXcE2+3fd2CvtfrAMhGDj1xz8TDwW7x+/wxz3W7OiXS1yxb0W54AcQO8ro90L05AWmRc2WynZvUfuNwb0C3npjQFTIij99cQkA8AGPPMx50pysz0BkIa2C2AMI4Wm4Rx4mH+UOVZ5uTnfis6WfmkVtI7PA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qG1sWHInHgchamRi6gODhQMJns+HngtaAQRrlPivcJc=; b=I4pBN15tC7Yn6y9ajaqUc25bKQk5qaAsJbZNBZsqxwXAfgtoGPW+zCxVScETVAHELmU05ieIgTch9gSon81z695X61AS2kvpppBcFvx2bAUBG/5saGF5Hj38D9aWrUEimwKptzl/x8d3OXor9xypJDrk1Tzj2e72YL/TW2dxauU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=prevas.dk; Received: from PR3PR10MB4239.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:96::6) by PA4PR10MB4381.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:106::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov 2021 00:18:33 +0000 Received: from PR3PR10MB4239.EURPRD10.PROD.OUTLOOK.COM ([fe80::ac23:766f:c440:5d3a]) by PR3PR10MB4239.EURPRD10.PROD.OUTLOOK.COM ([fe80::ac23:766f:c440:5d3a%6]) with mapi id 15.20.4669.016; Wed, 10 Nov 2021 00:18:33 +0000 Subject: Re: [RFC 0/2] Do not stop with an error when mkimage fails To: Tom Rini , Heiko Thiery Cc: Wolfgang Denk , u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Michael Walle , Simon Glass References: <20211104185231.2927-1-heiko.thiery@gmail.com> <729199.1636053161@gemini.denx.de> <963318.1636296486@gemini.denx.de> <20211109194224.GB24579@bill-the-cat> From: Rasmus Villemoes Message-ID: <11cebfaf-8fc4-f80d-ed0f-bd8810a43514@prevas.dk> Date: Wed, 10 Nov 2021 01:18:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20211109194224.GB24579@bill-the-cat> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR02CA0004.eurprd02.prod.outlook.com (2603:10a6:208:3e::17) To PR3PR10MB4239.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:96::6) MIME-Version: 1.0 Received: from [192.168.1.149] (80.208.69.72) by AM0PR02CA0004.eurprd02.prod.outlook.com (2603:10a6:208:3e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13 via Frontend Transport; Wed, 10 Nov 2021 00:18:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b432ba06-67b3-4ef4-d3ff-08d9a3dfa196 X-MS-TrafficTypeDiagnostic: PA4PR10MB4381: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gxiYKiHENGYsp/d/ntWFnhjWEth/4KZCVv+ObvFLK/kOw0IcBrojoVOL4646bH8A6Yv0kA0J3NfkQmEu6Q5ikY7hS2WnGBDB7nz/Qd+e7ZF4eUvOurY6LxT2Z6CbllXdgL/c7g49MIHUeFAcLoMQsAH4gTo6LkFUGL26EneV8uybDb3Y2PhaulL+QmGu/MxiNM2mITu1rOJHi35HFJRD0fOp9tlUi3qWTJTu5d92iwPwTzkQvI6hwk5X4SZ49v8uwSX+jP3lKfSb4xpCKj+lTeYr/QRNNvOzXV+bk0nNp4YFmU7oBobVAUXYNWgmvUmO7iPjyLsZxKgCtPIY8MpJ/B0vdlh6YLi0fsce/b9jk7QZ+e39MRIEPY83lsi29HqpBqSWGCXQuzUyz1GJCsV6bss3+1tsFz/k0QFMkybLJHeuw6FB090o79Ak8DVhf5vXXdNm+88JpXmN8JgAXTlEb4eApCTpmnXLjbEtz1s8ONbEu67q5humAR6jNVm98Kd0lkASCDqhnC0/yMrumLoLuh/tMhfLflCUWuGK6ZdHWfc5hr4MakS/NDNGWMR5cZdmQDK/XU/cW7+rRqXdUE6erM1LVOf2pjZSVuQmD6b+hIlNKD5TjDBIheURDhxMc2Z3+9rv0gP+BdXLsPEmAlVqMQTgkoTe4dT/M8bed1/mzwx3GxxO0YW5gyTcuSNWUHlbqZL2xOpYN1gGpHjtNZxkpJ6X0TG1AJd8uTNs7U94H0gRo4k7MtbfsGafYhYrM8kKY1ba0mOvQjeFdej6pYNZJw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR10MB4239.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(110136005)(26005)(5660300002)(54906003)(316002)(2906002)(31686004)(16576012)(44832011)(38100700002)(66556008)(508600001)(86362001)(6486002)(8676002)(83380400001)(52116002)(186003)(2616005)(66476007)(38350700002)(956004)(31696002)(8936002)(4326008)(66946007)(36756003)(8976002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?PbH2oKNoTozpe7v/FmLrYSvnZ971+1v2t1Yq15kBlr42Fm53eIqxYSb5?= =?Windows-1252?Q?QxIyyqikj7RZkmy6doyIdElwJEWvU8dCQ12GQgoqoFhUhW0fZGhV8lnd?= =?Windows-1252?Q?T9k3wFhg4asx1sAlNhrpiUH1KRiW2wpa/IsnKPq1jtUbHI3FqvOm/EBs?= =?Windows-1252?Q?iDrZ3HD4XScvD5fBf/CHbAoSa1T1ilUSx/grMYYW5b+Ao9C0oMrhaPtn?= =?Windows-1252?Q?HF04pHrtLy4n65YlMzf2vqdthdSHpeUawD++9p+2CY0n6jYMAFQGJnn5?= =?Windows-1252?Q?trvITXl0InvLG2cc6AJlBvJboU8l1/62MOYQZGChrS30N3qH19U6nezm?= =?Windows-1252?Q?l/uG6jaOrdVg5jR1mgS1C+IHmdNFj4TGLJLDXLRNXvdpcjT8ldXjsVj1?= =?Windows-1252?Q?NdeQNNDKa2MxzSbw6Nxr3QQIVAENouE7snSlNAX9xgRlA53moprJAhFh?= =?Windows-1252?Q?lVd+iYEng+8DP6c1PJ0bebnmIe1nmh/qVZ5JVEdhcxcpX5SY9yXUBom+?= =?Windows-1252?Q?S1L4o2t9vF3kwJcdBleiiWl1PtRMNKPK8ERzqGXqw9DlichMqct33Q0d?= =?Windows-1252?Q?Zln/b8Mq2e/2XFQyPcOYHi2K5slCOWeLefSWdRa1jwGNgcUuKFjKZjjS?= =?Windows-1252?Q?CkdDzgFCq1je/+Slhi+o+I83UphME4i+qjeuQ8SFlyvW056uxDvMbEfo?= =?Windows-1252?Q?+ff/6COHlnYorVl5z3fzHnhA7DvBF4VGev6wZpfsYaU+crhs8Arx6WXT?= =?Windows-1252?Q?+gA/lZcIDokCt/G/m5cQIeXCtjaKW8BIySOs+x15DiK/V5nOK8apFcz6?= =?Windows-1252?Q?stCQ1Ek8BrmMKPmfcmfV7P5irQX6iYoYyOPMbVRwnaJZcTHEKjqxovb5?= =?Windows-1252?Q?9neAPMdEUcXHvivNSEnnYAFGmDD0ttBuFW/kIR80kPuwmZnthApJQr6+?= =?Windows-1252?Q?ddvXFUAYlafrXbKx9qP/QD0PT+rjuq+9bWr3v6ibfruS7w9PJCIWr5yC?= =?Windows-1252?Q?DfXzi8MBSZLkzCfnFjy7UlIyoqprDB6o5ZfmcxmgMYpzzmUDgfC648H9?= =?Windows-1252?Q?3JUwXX7964qbfwXGduoQZjVS4CYBNoIuCNfQqXhv9POHHkgz/ETIheZB?= =?Windows-1252?Q?B2qG4QRwvtZDSh6UkbHVvtmsihSW/9u6wfhBJIfFgz+eszcJuJS+/pqA?= =?Windows-1252?Q?rz5L1Wq32uXZSI0UxCm169XOH/8a4GM7N7V+Hl/5yVkDZ1z39f38ll7w?= =?Windows-1252?Q?KKuKf2glzT8g2cEC9Z7+eq5t5Q29Kolfg4os8mTSMipfkWUsXwWxxKml?= =?Windows-1252?Q?BhQGPNdg7SO7Q77IxGlAHzxxsw1RzBXLG1vYHdbdvfUfDEo2kA5oHXcG?= =?Windows-1252?Q?23fPaIS2cM4Z8AAXSkaYQd4zCVR4FZ41WBLOImEcLEmsyi6d0LQKuMKg?= =?Windows-1252?Q?mFJdrYxnyZHh4Ug4jJRDMYWVDLlff2jVPB0/Oh6iO5VL1HhG7q5H9ztr?= =?Windows-1252?Q?vsi8bos6yLOSX5Qjufrvr2DI4oe5797cFagYDOfpsc9URDQRodl1qUM7?= =?Windows-1252?Q?CCNzwbaINqsM1y4iZ7R2TVcROQ4QwzQYVc9T35H8wUDp1ZRjVQ+3JYGn?= =?Windows-1252?Q?4q7c+qNTBSRr2wklOjHikB59mBQk5yfEyqeZ6YLwTncd+00PB7fQf5RB?= =?Windows-1252?Q?4RhzN7zmJze0OY/fbRd85JvrkeAk/ikPMzujWhgc0xGdF1qo4Gqc+/Ii?= =?Windows-1252?Q?v9OerMRG3Dqqwjdo6rwHBJ//4SeP5DwUVZblKNhVPiD6q3UqTevdyGsS?= =?Windows-1252?Q?9NaS4w=3D=3D?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: b432ba06-67b3-4ef4-d3ff-08d9a3dfa196 X-MS-Exchange-CrossTenant-AuthSource: PR3PR10MB4239.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 00:18:33.4762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /0t4HYAisNO9sARyGafnsJY3KzhsPtjF3yNLFA5Qlg9ti6C6IM2rsWmvCnPL84vJrnhs8cBsi7mEijyIMb4x9YRaG8kqEB20OvmSANP5iY0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR10MB4381 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 09/11/2021 20.42, Tom Rini wrote: > On Tue, Nov 09, 2021 at 08:21:07PM +0100, Heiko Thiery wrote: >> Hi Wolfgang, >> >> I know this is not a perfect solution but I don't know how to get my >> board merged without doing this kind of workaround for the U-Boot CI. > > Unfortunately in these days of needing multiple inputs to create a > functional image and also needing to have CI be able to be at all > useful, what we do in many many many cases is yell loudly to the user > that the resulting file here will NOT work and why. So yes, some "yell > it won't work but not return non-zero exit status" is the norm. > > I would be very much open however to some way to handle this > differently. Some environment variable our tools check for and then > yell-but-succeed? Some other idea? I'm just thinking out loud here. Yes, I believe the build system must be taught some env var (or other means) for opting in to this behavior. I've mentioned this example before: Imagine some CI system tracking master branches of various Yocto meta-layers. One of those recipes is responsible for providing one of those infamous binary blobs, but one day the recipe is updated to provide another version, so now the filename is different (this has happened for some imx8m recently). No amount of yelling is going to prevent the CI from thinking "great, the U-Boot build succeeded, now let's deploy that artifact to the test rack and run our test suite". Insta-brick. Apart from forcing one to drive to the office to unbrick the victim boards, figuring out what went wrong is also going to be quite unpleasant, since doing a manual build seems to work just fine. And even in the interactive, developer-working-in-a-terminal, case, there's no guarantee that the yelling hasn't scrolled away because of other make output after the should-have-failed target has been "built". Rasmus