Re: [PATCH 3/3] drm/amdgpu: remove AMDGPU_GEM_CREATE_NO_FALLBACK handling from CS again

From: zhoucm1 <zhoucm1-5C7GfCeVMHo@public.gmane.org>
To: "Christian König"
	<ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 3/3] drm/amdgpu: remove AMDGPU_GEM_CREATE_NO_FALLBACK handling from CS again
Date: Tue, 10 Apr 2018 10:43:27 +0800	[thread overview]
Message-ID: <11e2b937-9e84-428a-1a90-8752f0dadda4@amd.com> (raw)
In-Reply-To: <20180409101900.2790-3-christian.koenig-5C7GfCeVMHo@public.gmane.org>


On 2018年04月09日 18:19, Christian König wrote:
> That should purely be handled by preferred/allowed domains.
Although this flag isn't exported to user space yet, I'm curious that 
how preferred/allowed domains handle no_fallback?
IIRC, currently, our driver will always add GTT fallback for VRAM bo.

Regards,
David Zhou
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 68af2f878bc9..e1756b68a17b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -385,8 +385,7 @@ static int amdgpu_cs_bo_validate(struct amdgpu_cs_parser *p,
>   	    amdgpu_bo_in_cpu_visible_vram(bo))
>   		p->bytes_moved_vis += ctx.bytes_moved;
>   
> -	if (unlikely(r == -ENOMEM) && domain != bo->allowed_domains &&
> -	    !(bo->flags & AMDGPU_GEM_CREATE_NO_FALLBACK)) {
> +	if (unlikely(r == -ENOMEM) && domain != bo->allowed_domains) {
>   		domain = bo->allowed_domains;
>   		goto retry;
>   	}

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx