From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53D3FC4363C for ; Wed, 7 Oct 2020 19:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0310E2076C for ; Wed, 7 Oct 2020 19:23:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728109AbgJGTX6 (ORCPT ); Wed, 7 Oct 2020 15:23:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728092AbgJGTX6 (ORCPT ); Wed, 7 Oct 2020 15:23:58 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 241E9C061755 for ; Wed, 7 Oct 2020 12:23:58 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kQF2W-0019Ex-Uk; Wed, 07 Oct 2020 21:23:53 +0200 Message-ID: <11f40c1a85a118d8207a6f05fc574164a01af3a9.camel@sipsolutions.net> Subject: Re: [RFC v7 20/21] um: host: add test programs From: Johannes Berg To: Hajime Tazaki , linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com Cc: tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com Date: Wed, 07 Oct 2020 21:23:51 +0200 In-Reply-To: <363dceeefe1c468adca17cec0b7ba4fad7c76ef3.1601960644.git.thehajime@gmail.com> References: <363dceeefe1c468adca17cec0b7ba4fad7c76ef3.1601960644.git.thehajime@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Tue, 2020-10-06 at 18:44 +0900, Hajime Tazaki wrote: > > +LKL_TEST_CALL(getpid, lkl_sys_getpid, 1) Could that be unified with KUNIT somehow? > +++ b/tools/um/tests/run.py > @@ -0,0 +1,172 @@ > +#!/usr/bin/env python > +# SPDX-License-Identifier: GPL-2.0 > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; version 2 of the License > +# > +# Author: Octavian Purdila > +# > + > +from __future__ import print_function > + > +import argparse > +import os > +import subprocess > +import sys > +import tap13 ok, I see now, you're doing something with TAP (test anything protocol)... Hmm. I must say I'm not a fan of adding a whole testing framework to the kernel like that, even if it's pretty simple. > +import xml.etree.ElementTree as ET > + > +from junit_xml import TestSuite, TestCase yuck Let's see if you can use KUNIT instead. Anything beyond that doesn't really need to live in the kernel, IMHO. johanens From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQF2Y-0002xZ-F7 for linux-um@lists.infradead.org; Wed, 07 Oct 2020 19:23:55 +0000 Message-ID: <11f40c1a85a118d8207a6f05fc574164a01af3a9.camel@sipsolutions.net> Subject: Re: [RFC v7 20/21] um: host: add test programs From: Johannes Berg Date: Wed, 07 Oct 2020 21:23:51 +0200 In-Reply-To: <363dceeefe1c468adca17cec0b7ba4fad7c76ef3.1601960644.git.thehajime@gmail.com> References: <363dceeefe1c468adca17cec0b7ba4fad7c76ef3.1601960644.git.thehajime@gmail.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Hajime Tazaki , linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com Cc: tavi.purdila@gmail.com, linux-kernel-library@freelists.org, retrage01@gmail.com, linux-arch@vger.kernel.org On Tue, 2020-10-06 at 18:44 +0900, Hajime Tazaki wrote: > > +LKL_TEST_CALL(getpid, lkl_sys_getpid, 1) Could that be unified with KUNIT somehow? > +++ b/tools/um/tests/run.py > @@ -0,0 +1,172 @@ > +#!/usr/bin/env python > +# SPDX-License-Identifier: GPL-2.0 > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; version 2 of the License > +# > +# Author: Octavian Purdila > +# > + > +from __future__ import print_function > + > +import argparse > +import os > +import subprocess > +import sys > +import tap13 ok, I see now, you're doing something with TAP (test anything protocol)... Hmm. I must say I'm not a fan of adding a whole testing framework to the kernel like that, even if it's pretty simple. > +import xml.etree.ElementTree as ET > + > +from junit_xml import TestSuite, TestCase yuck Let's see if you can use KUNIT instead. Anything beyond that doesn't really need to live in the kernel, IMHO. johanens _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um