All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Joerg Roedel" <joerg.roedel@amd.com>
To: "Avi Kivity" <avi@qumranet.com>,
	kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Cc: "Joerg Roedel" <joerg.roedel@amd.com>
Subject: [PATCH 1/8] SVM: move feature detection to hardware setup code
Date: Fri, 25 Jan 2008 21:53:06 +0100	[thread overview]
Message-ID: <1201294393-22613-2-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1201294393-22613-1-git-send-email-joerg.roedel@amd.com>

By moving the SVM feature detection from the each_cpu code to the hardware
setup code it runs only once. As an additional advance the feature check is now
available earlier in the module setup process.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kvm/svm.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 7bdbe16..0c58527 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -302,7 +302,6 @@ static void svm_hardware_enable(void *garbage)
 	svm_data->asid_generation = 1;
 	svm_data->max_asid = cpuid_ebx(SVM_CPUID_FUNC) - 1;
 	svm_data->next_asid = svm_data->max_asid + 1;
-	svm_features = cpuid_edx(SVM_CPUID_FUNC);
 
 	asm volatile ("sgdt %0" : "=m"(gdt_descr));
 	gdt = (struct desc_struct *)gdt_descr.address;
@@ -408,6 +407,9 @@ static __init int svm_hardware_setup(void)
 		if (r)
 			goto err_2;
 	}
+
+	svm_features = cpuid_edx(SVM_CPUID_FUNC);
+
 	return 0;
 
 err_2:
-- 
1.5.3.7




WARNING: multiple messages have this Message-ID (diff)
From: "Joerg Roedel" <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
To: "Avi Kivity" <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
	kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 1/8] SVM: move feature detection to hardware setup code
Date: Fri, 25 Jan 2008 21:53:06 +0100	[thread overview]
Message-ID: <1201294393-22613-2-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1201294393-22613-1-git-send-email-joerg.roedel-5C7GfCeVMHo@public.gmane.org>

By moving the SVM feature detection from the each_cpu code to the hardware
setup code it runs only once. As an additional advance the feature check is now
available earlier in the module setup process.

Signed-off-by: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
---
 arch/x86/kvm/svm.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 7bdbe16..0c58527 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -302,7 +302,6 @@ static void svm_hardware_enable(void *garbage)
 	svm_data->asid_generation = 1;
 	svm_data->max_asid = cpuid_ebx(SVM_CPUID_FUNC) - 1;
 	svm_data->next_asid = svm_data->max_asid + 1;
-	svm_features = cpuid_edx(SVM_CPUID_FUNC);
 
 	asm volatile ("sgdt %0" : "=m"(gdt_descr));
 	gdt = (struct desc_struct *)gdt_descr.address;
@@ -408,6 +407,9 @@ static __init int svm_hardware_setup(void)
 		if (r)
 			goto err_2;
 	}
+
+	svm_features = cpuid_edx(SVM_CPUID_FUNC);
+
 	return 0;
 
 err_2:
-- 
1.5.3.7




-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-01-25 20:54 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-25 20:53 [PATCH][RFC] SVM: Add Support for Nested Paging in AMD Fam16 CPUs Joerg Roedel
2008-01-25 20:53 ` Joerg Roedel
2008-01-25 20:53 ` Joerg Roedel [this message]
2008-01-25 20:53   ` [PATCH 1/8] SVM: move feature detection to hardware setup code Joerg Roedel
2008-01-25 20:53 ` [PATCH 2/8] SVM: add detection of Nested Paging feature Joerg Roedel
2008-01-25 20:53   ` Joerg Roedel
2008-01-25 20:53 ` [PATCH 3/8] SVM: add module parameter to disable Nested Paging Joerg Roedel
2008-01-25 21:35   ` [kvm-devel] " Anthony Liguori
2008-01-25 21:35     ` Anthony Liguori
2008-01-25 22:10     ` [kvm-devel] " Joerg Roedel
2008-01-25 22:10       ` Joerg Roedel
2008-01-26 18:38       ` [kvm-devel] " Avi Kivity
2008-01-26 18:38         ` Avi Kivity
2008-01-26  1:47   ` [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable NestedPaging Nakajima, Jun
2008-01-26  1:47     ` Nakajima, Jun
2008-01-26  7:25     ` [kvm-devel] " Joerg Roedel
2008-01-26  7:25       ` Joerg Roedel
2008-01-26  9:49       ` [kvm-devel] " Alexey Eremenko
2008-01-26  9:49         ` Alexey Eremenko
2008-01-26 10:06         ` [kvm-devel] " Joerg Roedel
2008-01-26 10:06           ` Joerg Roedel
2008-01-26 16:36         ` [kvm-devel] " Anthony Liguori
2008-01-26 16:36           ` Anthony Liguori
2008-01-26 18:23       ` [kvm-devel] " Avi Kivity
2008-01-25 20:53 ` [PATCH 4/8] X86: export information about NPT to generic x86 code Joerg Roedel
2008-01-25 20:53   ` Joerg Roedel
2008-01-25 21:37   ` [kvm-devel] " Anthony Liguori
2008-01-25 21:37     ` Anthony Liguori
2008-01-25 21:40     ` [kvm-devel] " Anthony Liguori
2008-01-25 21:40       ` Anthony Liguori
2008-01-27  8:40   ` [kvm-devel] " Avi Kivity
2008-01-27  8:40     ` Avi Kivity
2008-01-25 20:53 ` [PATCH 5/8] MMU: make the __nonpaging_map function generic Joerg Roedel
2008-01-25 20:53   ` Joerg Roedel
2008-01-25 20:53 ` [PATCH 6/8] X86: export the load_pdptrs() function to modules Joerg Roedel
2008-01-25 20:53   ` Joerg Roedel
2008-01-25 20:53 ` [PATCH 7/8] MMU: add HAP support to the KVM MMU Joerg Roedel
2008-01-25 20:53   ` Joerg Roedel
2008-01-25 20:53 ` [PATCH 8/8] SVM: add support for Nested Paging Joerg Roedel
2008-01-25 20:53   ` Joerg Roedel
2008-01-27  8:52   ` [kvm-devel] " Avi Kivity
2008-01-27  8:52     ` Avi Kivity
2008-01-27  9:41     ` [kvm-devel] " Joerg Roedel
2008-01-27  9:41       ` Joerg Roedel
2008-01-27  9:51       ` [kvm-devel] " Avi Kivity
2008-01-27  9:51         ` Avi Kivity
2008-01-27 10:05         ` [kvm-devel] " Joerg Roedel
2008-01-27 10:05           ` Joerg Roedel
2008-01-27 10:24           ` [kvm-devel] " Avi Kivity
2008-01-27 10:24             ` Avi Kivity
2008-01-25 21:32 ` [kvm-devel] [PATCH][RFC] SVM: Add Support for Nested Paging in AMD Fam16 CPUs Anthony Liguori
2008-01-25 21:32   ` Anthony Liguori
2008-01-25 22:47   ` [kvm-devel] " Joerg Roedel
2008-01-25 22:47     ` Joerg Roedel
2008-01-26  1:57 ` [kvm-devel] " Nakajima, Jun
2008-01-26  1:57   ` Nakajima, Jun
2008-01-27  8:57 ` [kvm-devel] " Avi Kivity
2008-01-27  8:57   ` Avi Kivity
2008-01-27  9:51   ` [kvm-devel] " Joerg Roedel
2008-01-27  9:51     ` Joerg Roedel
2008-01-28  3:20   ` [kvm-devel] " Jeremy Fitzhardinge
2008-01-28  3:20     ` Jeremy Fitzhardinge
2008-01-28 11:08     ` [kvm-devel] " Avi Kivity
2008-01-28 11:08       ` Avi Kivity
2008-02-07 12:09   ` [kvm-devel] " Joerg Roedel
2008-02-07 12:09     ` Joerg Roedel
2008-02-10 10:35     ` [kvm-devel] " Avi Kivity
2008-02-10 10:35       ` Avi Kivity
2008-02-07 12:47 KVM: add support for SVM Nested Paging Joerg Roedel
2008-02-07 12:47 ` [PATCH 1/8] SVM: move feature detection to hardware setup code Joerg Roedel
2008-02-07 12:47   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201294393-22613-2-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.