From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/2] drm/scheduler: remove timeout work_struct from drm_sched_job Date: Wed, 19 Sep 2018 14:30:49 +0200 Message-ID: <12021007-424e-e770-9705-4ea9027ac9d4@amd.com> References: <20180918161710.2669-1-nayan26deshmukh@gmail.com> <20180918161710.2669-2-nayan26deshmukh@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0053.outbound.protection.outlook.com [104.47.33.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2D656E4F1 for ; Wed, 19 Sep 2018 12:31:01 +0000 (UTC) In-Reply-To: <20180918161710.2669-2-nayan26deshmukh@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nayan Deshmukh , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMTguMDkuMjAxOCB1bSAxODoxNyBzY2hyaWViIE5heWFuIERlc2htdWtoOgo+IGhhdmluZyBh IGRlbGF5ZWQgd29yayBpdGVtIHBlciBqb2IgaXMgcmVkdW5kYW50IGFzIHdlIG9ubHkgbmVlZCBv bmUKPiBwZXIgc2NoZWR1bGVyIHRvIHRyYWNrIHRoZSB0aW1lIG91dCB0aGUgY3VycmVudGx5IGV4 ZWN1dGluZyBqb2IuCgpXZWxsIHRoYXQgbG9va3Mgc2ltcGxlciB0aGFuIEkgdGhvdWdodCBpdCB3 b3VsZCBiZS4KCkJ1dCBpdCBzaG93cyB0aGUgbmV4dCBwcm9ibGVtIHRoYXQgdGhlIHRpbWVvdXQg YW5kIHRoZSBjb21wbGV0aW9uIGNvdWxkIApyYWNlLgoKQXMgZmFyIGFzIEkgY2FuIHNlZSB0aGF0 IGNhbiBiZSBmaXhlZCBieSBtb3ZpbmcgdGhlIApkbWFfZmVuY2VfcmVtb3ZlX2NhbGxiYWNrKCkv ZG1hX2ZlbmNlX2FkZF9jYWxsYmFjaygpIGRhbmNlIGZyb20gCmRybV9zY2hlZF9od19qb2JfcmVz ZXQoKSB0byBkcm1fc2NoZWRfam9iX3RpbWVkb3V0KCkuCgpBbnl3YXksIEkgd291bGQgc2F5IGRy b3AgcGF0Y2ggIzEgYW5kIGZpeCB0aGUgb25lIGNvbW1lbnQgYmVsb3cgYW5kIHdlIApjYW4gdXNl IHRoaXMuCgo+Cj4gU2lnbmVkLW9mZi1ieTogTmF5YW4gRGVzaG11a2ggPG5heWFuMjZkZXNobXVr aEBnbWFpbC5jb20+Cj4gU3VnZ2VzdGVkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4u a29lbmlnQGFtZC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVk X21haW4uYyB8IDE2ICsrKysrKysrKy0tLS0tLS0KPiAgIGluY2x1ZGUvZHJtL2dwdV9zY2hlZHVs ZXIuaCAgICAgICAgICAgIHwgIDYgKysrLS0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2Vy dGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9zY2hlZHVsZXIvc2NoZWRfbWFpbi5jIGIvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hl ZF9tYWluLmMKPiBpbmRleCAwZTZjY2M4MjQzZGIuLmYyMTNiNWM3ZjcxOCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX21haW4uYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9zY2hlZHVsZXIvc2NoZWRfbWFpbi5jCj4gQEAgLTE5OCw3ICsxOTgsNyBAQCBzdGF0 aWMgdm9pZCBkcm1fc2NoZWRfam9iX2ZpbmlzaChzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4g ICAJICogbWFuYWdlcyB0byBmaW5kIHRoaXMgam9iIGFzIHRoZSBuZXh0IGpvYiBpbiB0aGUgbGlz dCwgdGhlIGZlbmNlCj4gICAJICogc2lnbmFsZWQgY2hlY2sgYmVsb3cgd2lsbCBwcmV2ZW50IHRo ZSB0aW1lb3V0IHRvIGJlIHJlc3RhcnRlZC4KPiAgIAkgKi8KPiAtCWNhbmNlbF9kZWxheWVkX3dv cmtfc3luYygmc19qb2ItPndvcmtfdGRyKTsKPiArCWNhbmNlbF9kZWxheWVkX3dvcmtfc3luYygm c2NoZWQtPndvcmtfdGRyKTsKPiAgIAo+ICAgCXNwaW5fbG9jaygmc2NoZWQtPmpvYl9saXN0X2xv Y2spOwo+ICAgCS8qIHF1ZXVlIFREUiBmb3IgbmV4dCBqb2IgKi8KPiBAQCAtMjA3LDcgKzIwNyw3 IEBAIHN0YXRpYyB2b2lkIGRybV9zY2hlZF9qb2JfZmluaXNoKHN0cnVjdCB3b3JrX3N0cnVjdCAq d29yaykKPiAgIAlpZiAoc2NoZWQtPnRpbWVvdXQgIT0gTUFYX1NDSEVEVUxFX1RJTUVPVVQgJiYK PiAgIAkgICAgIWxpc3RfaXNfbGFzdCgmc19qb2ItPm5vZGUsICZzY2hlZC0+cmluZ19taXJyb3Jf bGlzdCkpIHsKPiAgIAkJaWYgKCFkbWFfZmVuY2VfaXNfc2lnbmFsZWQoJm5leHQtPnNfZmVuY2Ut PmZpbmlzaGVkKSkKClNpbmNlIHdlIG5vdyBoYXZlIG9ubHkgb25lIGRlbGF5ZWQgd29yayBpdGVt IHdlIGNhbiBqdXN0IGRyb3AgdGhlIHRlc3QgCmlmIG5leHQgaXMgYWxyZWFkeSBzaWduYWxlZC4K ClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4gLQkJCXNjaGVkdWxlX2RlbGF5ZWRfd29yaygmbmV4dC0+ d29ya190ZHIsIHNjaGVkLT50aW1lb3V0KTsKPiArCQkJc2NoZWR1bGVfZGVsYXllZF93b3JrKCZz Y2hlZC0+d29ya190ZHIsIHNjaGVkLT50aW1lb3V0KTsKPiAgIAl9Cj4gICAJLyogcmVtb3ZlIGpv YiBmcm9tIHJpbmdfbWlycm9yX2xpc3QgKi8KPiAgIAlsaXN0X2RlbCgmc19qb2ItPm5vZGUpOwo+ IEBAIC0yMzcsNyArMjM3LDcgQEAgc3RhdGljIHZvaWQgZHJtX3NjaGVkX2pvYl9iZWdpbihzdHJ1 Y3QgZHJtX3NjaGVkX2pvYiAqc19qb2IpCj4gICAJaWYgKGxpc3RfZmlyc3RfZW50cnlfb3JfbnVs bCgmc2NoZWQtPnJpbmdfbWlycm9yX2xpc3QsCj4gICAJCQkJc3RydWN0IGRybV9zY2hlZF9qb2Is IG5vZGUpID09IHNfam9iKSB7Cj4gICAJCWlmIChzY2hlZC0+dGltZW91dCAhPSBNQVhfU0NIRURV TEVfVElNRU9VVCkKPiAtCQkJc2NoZWR1bGVfZGVsYXllZF93b3JrKCZzX2pvYi0+d29ya190ZHIs IHNjaGVkLT50aW1lb3V0KTsKPiArCQkJc2NoZWR1bGVfZGVsYXllZF93b3JrKCZzY2hlZC0+d29y a190ZHIsIHNjaGVkLT50aW1lb3V0KTsKPiAgIAkJc2NoZWQtPmN1cnJfam9iID0gc19qb2I7Cj4g ICAJfQo+ICAgCXNwaW5fdW5sb2NrKCZzY2hlZC0+am9iX2xpc3RfbG9jayk7Cj4gQEAgLTI0NSw4 ICsyNDUsMTAgQEAgc3RhdGljIHZvaWQgZHJtX3NjaGVkX2pvYl9iZWdpbihzdHJ1Y3QgZHJtX3Nj aGVkX2pvYiAqc19qb2IpCj4gICAKPiAgIHN0YXRpYyB2b2lkIGRybV9zY2hlZF9qb2JfdGltZWRv dXQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAgewo+IC0Jc3RydWN0IGRybV9zY2hlZF9q b2IgKmpvYiA9IGNvbnRhaW5lcl9vZih3b3JrLCBzdHJ1Y3QgZHJtX3NjaGVkX2pvYiwKPiAtCQkJ CQkJIHdvcmtfdGRyLndvcmspOwo+ICsJc3RydWN0IGRybV9ncHVfc2NoZWR1bGVyICpzY2hlZCA9 IGNvbnRhaW5lcl9vZih3b3JrLAo+ICsJCQkJCQlzdHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIsCj4g KwkJCQkJCXdvcmtfdGRyLndvcmspOwo+ICsJc3RydWN0IGRybV9zY2hlZF9qb2IgKmpvYiA9IHNj aGVkLT5jdXJyX2pvYjsKPiAgIAo+ICAgCWpvYi0+c2NoZWQtPm9wcy0+dGltZWRvdXRfam9iKGpv Yik7Cj4gICB9Cj4gQEAgLTMxOCw3ICszMjAsNyBAQCB2b2lkIGRybV9zY2hlZF9qb2JfcmVjb3Zl cnkoc3RydWN0IGRybV9ncHVfc2NoZWR1bGVyICpzY2hlZCkKPiAgIAlzX2pvYiA9IGxpc3RfZmly c3RfZW50cnlfb3JfbnVsbCgmc2NoZWQtPnJpbmdfbWlycm9yX2xpc3QsCj4gICAJCQkJCSBzdHJ1 Y3QgZHJtX3NjaGVkX2pvYiwgbm9kZSk7Cj4gICAJaWYgKHNfam9iICYmIHNjaGVkLT50aW1lb3V0 ICE9IE1BWF9TQ0hFRFVMRV9USU1FT1VUKQo+IC0JCXNjaGVkdWxlX2RlbGF5ZWRfd29yaygmc19q b2ItPndvcmtfdGRyLCBzY2hlZC0+dGltZW91dCk7Cj4gKwkJc2NoZWR1bGVfZGVsYXllZF93b3Jr KCZzY2hlZC0+d29ya190ZHIsIHNjaGVkLT50aW1lb3V0KTsKPiAgIAlpZiAoc19qb2IpCj4gICAJ CXNjaGVkLT5jdXJyX2pvYiA9IHNfam9iOwo+ICAgCj4gQEAgLTM4OSw3ICszOTEsNiBAQCBpbnQg ZHJtX3NjaGVkX2pvYl9pbml0KHN0cnVjdCBkcm1fc2NoZWRfam9iICpqb2IsCj4gICAKPiAgIAlJ TklUX1dPUksoJmpvYi0+ZmluaXNoX3dvcmssIGRybV9zY2hlZF9qb2JfZmluaXNoKTsKPiAgIAlJ TklUX0xJU1RfSEVBRCgmam9iLT5ub2RlKTsKPiAtCUlOSVRfREVMQVlFRF9XT1JLKCZqb2ItPndv cmtfdGRyLCBkcm1fc2NoZWRfam9iX3RpbWVkb3V0KTsKPiAgIAo+ICAgCXJldHVybiAwOwo+ICAg fQo+IEBAIC01ODAsNiArNTgxLDcgQEAgaW50IGRybV9zY2hlZF9pbml0KHN0cnVjdCBkcm1fZ3B1 X3NjaGVkdWxlciAqc2NoZWQsCj4gICAJSU5JVF9MSVNUX0hFQUQoJnNjaGVkLT5yaW5nX21pcnJv cl9saXN0KTsKPiAgIAlzcGluX2xvY2tfaW5pdCgmc2NoZWQtPmpvYl9saXN0X2xvY2spOwo+ICAg CWF0b21pY19zZXQoJnNjaGVkLT5od19ycV9jb3VudCwgMCk7Cj4gKwlJTklUX0RFTEFZRURfV09S Sygmc2NoZWQtPndvcmtfdGRyLCBkcm1fc2NoZWRfam9iX3RpbWVkb3V0KTsKPiAgIAlhdG9taWNf c2V0KCZzY2hlZC0+bnVtX2pvYnMsIDApOwo+ICAgCWF0b21pYzY0X3NldCgmc2NoZWQtPmpvYl9p ZF9jb3VudCwgMCk7Cj4gICAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZ3B1X3NjaGVkdWxl ci5oIGIvaW5jbHVkZS9kcm0vZ3B1X3NjaGVkdWxlci5oCj4gaW5kZXggMDdlNzc2YjFjYTQyLi45 ZDUwZDdmM2VhYTQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZ3B1X3NjaGVkdWxlci5oCj4g KysrIGIvaW5jbHVkZS9kcm0vZ3B1X3NjaGVkdWxlci5oCj4gQEAgLTE3NSw4ICsxNzUsNiBAQCBz dHJ1Y3QgZHJtX3NjaGVkX2ZlbmNlICp0b19kcm1fc2NoZWRfZmVuY2Uoc3RydWN0IGRtYV9mZW5j ZSAqZik7Cj4gICAgKiAgICAgICAgICAgICAgIGZpbmlzaGVkIHRvIHJlbW92ZSB0aGUgam9iIGZy b20gdGhlCj4gICAgKiAgICAgICAgICAgICAgIEBkcm1fZ3B1X3NjaGVkdWxlci5yaW5nX21pcnJv cl9saXN0Lgo+ICAgICogQG5vZGU6IHVzZWQgdG8gYXBwZW5kIHRoaXMgc3RydWN0IHRvIHRoZSBA ZHJtX2dwdV9zY2hlZHVsZXIucmluZ19taXJyb3JfbGlzdC4KPiAtICogQHdvcmtfdGRyOiBzY2hl ZHVsZXMgYSBkZWxheWVkIGNhbGwgdG8gQGRybV9zY2hlZF9qb2JfdGltZWRvdXQgYWZ0ZXIgdGhl IHRpbWVvdXQKPiAtICogICAgICAgICAgICBpbnRlcnZhbCBpcyBvdmVyLgo+ICAgICogQGlkOiBh IHVuaXF1ZSBpZCBhc3NpZ25lZCB0byBlYWNoIGpvYiBzY2hlZHVsZWQgb24gdGhlIHNjaGVkdWxl ci4KPiAgICAqIEBrYXJtYTogaW5jcmVtZW50IG9uIGV2ZXJ5IGhhbmcgY2F1c2VkIGJ5IHRoaXMg am9iLiBJZiB0aGlzIGV4Y2VlZHMgdGhlIGhhbmcKPiAgICAqICAgICAgICAgbGltaXQgb2YgdGhl IHNjaGVkdWxlciB0aGVuIHRoZSBqb2IgaXMgbWFya2VkIGd1aWx0eSBhbmQgd2lsbCBub3QKPiBA QCAtMTk1LDcgKzE5Myw2IEBAIHN0cnVjdCBkcm1fc2NoZWRfam9iIHsKPiAgIAlzdHJ1Y3QgZG1h X2ZlbmNlX2NiCQlmaW5pc2hfY2I7Cj4gICAJc3RydWN0IHdvcmtfc3RydWN0CQlmaW5pc2hfd29y azsKPiAgIAlzdHJ1Y3QgbGlzdF9oZWFkCQlub2RlOwo+IC0Jc3RydWN0IGRlbGF5ZWRfd29yawkJ d29ya190ZHI7Cj4gICAJdWludDY0X3QJCQlpZDsKPiAgIAlhdG9taWNfdAkJCWthcm1hOwo+ICAg CWVudW0gZHJtX3NjaGVkX3ByaW9yaXR5CQlzX3ByaW9yaXR5Owo+IEBAIC0yNjAsNiArMjU3LDgg QEAgc3RydWN0IGRybV9zY2hlZF9iYWNrZW5kX29wcyB7Cj4gICAgKiAgICAgICAgICAgICAgICAg ZmluaXNoZWQuCj4gICAgKiBAaHdfcnFfY291bnQ6IHRoZSBudW1iZXIgb2Ygam9icyBjdXJyZW50 bHkgaW4gdGhlIGhhcmR3YXJlIHF1ZXVlLgo+ICAgICogQGpvYl9pZF9jb3VudDogdXNlZCB0byBh c3NpZ24gdW5pcXVlIGlkIHRvIHRoZSBlYWNoIGpvYi4KPiArICogQHdvcmtfdGRyOiBzY2hlZHVs ZXMgYSBkZWxheWVkIGNhbGwgdG8gQGRybV9zY2hlZF9qb2JfdGltZWRvdXQgYWZ0ZXIgdGhlCj4g KyAqICAgICAgICAgICAgdGltZW91dCBpbnRlcnZhbCBpcyBvdmVyLgo+ICAgICogQHRocmVhZDog dGhlIGt0aHJlYWQgb24gd2hpY2ggdGhlIHNjaGVkdWxlciB3aGljaCBydW4uCj4gICAgKiBAcmlu Z19taXJyb3JfbGlzdDogdGhlIGxpc3Qgb2Ygam9icyB3aGljaCBhcmUgY3VycmVudGx5IGluIHRo ZSBqb2IgcXVldWUuCj4gICAgKiBAam9iX2xpc3RfbG9jazogbG9jayB0byBwcm90ZWN0IHRoZSBy aW5nX21pcnJvcl9saXN0Lgo+IEBAIC0yODAsNiArMjc5LDcgQEAgc3RydWN0IGRybV9ncHVfc2No ZWR1bGVyIHsKPiAgIAl3YWl0X3F1ZXVlX2hlYWRfdAkJam9iX3NjaGVkdWxlZDsKPiAgIAlhdG9t aWNfdAkJCWh3X3JxX2NvdW50Owo+ICAgCWF0b21pYzY0X3QJCQlqb2JfaWRfY291bnQ7Cj4gKwlz dHJ1Y3QgZGVsYXllZF93b3JrCQl3b3JrX3RkcjsKPiAgIAlzdHJ1Y3QgdGFza19zdHJ1Y3QJCSp0 aHJlYWQ7Cj4gICAJc3RydWN0IGxpc3RfaGVhZAkJcmluZ19taXJyb3JfbGlzdDsKPiAgIAlzcGlu bG9ja190CQkJam9iX2xpc3RfbG9jazsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=