From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751626AbdILPp3 (ORCPT ); Tue, 12 Sep 2017 11:45:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:44643 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751430AbdILPp2 (ORCPT ); Tue, 12 Sep 2017 11:45:28 -0400 Subject: Re: [Xen-devel] [PATCH 1/4] xen: re-introduce support for grant v2 interface To: Boris Ostrovsky , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20170908144849.2958-1-jgross@suse.com> <20170908144849.2958-2-jgross@suse.com> <67503f2a-6d93-59c6-5a49-40fcb487859c@oracle.com> From: Juergen Gross Message-ID: <12021f54-9404-c92b-5368-440d14814dbd@suse.com> Date: Tue, 12 Sep 2017 17:45:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <67503f2a-6d93-59c6-5a49-40fcb487859c@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/17 17:41, Boris Ostrovsky wrote: > >> +int arch_gnttab_map_status(uint64_t *frames, unsigned long nr_gframes, >> + unsigned long max_nr_gframes, >> + grant_status_t **__shared) >> +{ >> + grant_status_t *shared = *__shared; >> + unsigned long addr; >> + unsigned long i; >> + >> + if (shared == NULL) >> + *__shared = shared = gnttab_status_vm_area.area->addr; >> + >> + addr = (unsigned long)shared; >> + >> + for (i = 0; i < nr_gframes; i++) { >> + set_pte_at(&init_mm, addr, gnttab_status_vm_area.ptes[i], >> + mfn_pte(frames[i], PAGE_KERNEL)); >> + addr += PAGE_SIZE; >> + } >> + >> + return 0; >> +} > > This looks pretty much identical to arch_gnttab_map_shared() except for > gnttab_shared_vm_area vs. gnttab_status_vm_area,which can be passed in > as a parameter. > >> + >> void arch_gnttab_unmap(void *shared, unsigned long nr_gframes) >> { >> + pte_t **ptes; >> unsigned long addr; >> unsigned long i; >> >> + if (shared == gnttab_status_vm_area.area->addr) >> + ptes = gnttab_status_vm_area.ptes; >> + else >> + ptes = gnttab_shared_vm_area.ptes; >> + >> addr = (unsigned long)shared; >> >> for (i = 0; i < nr_gframes; i++) { >> - set_pte_at(&init_mm, addr, gnttab_shared_vm_area.ptes[i], >> - __pte(0)); >> + set_pte_at(&init_mm, addr, ptes[i], __pte(0)); >> addr += PAGE_SIZE; >> } > > And this too looks like can be factored out (to something like > arch_update_gnttab()). But perhaps not in this patch. > >> } >> @@ -102,12 +129,35 @@ static int arch_gnttab_valloc(struct gnttab_vm_area *area, unsigned nr_frames) >> return 0; >> } >> >> -int arch_gnttab_init(unsigned long nr_shared) >> +static void arch_gnttab_vfree(struct gnttab_vm_area *area) >> { >> + free_vm_area(area->area); >> + kfree(area->ptes); >> +} > > Not sure there is need for this routine. It is used only once. > > Also, as an overall comment -- It feels like there may be too many > BUG_ON()s. This patch is mostly a revert of David's patch removing grant v2 support with just very few adaptions. I wanted to keep it as similar to the former grant v2 support as possible. Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH 1/4] xen: re-introduce support for grant v2 interface Date: Tue, 12 Sep 2017 17:45:25 +0200 Message-ID: <12021f54-9404-c92b-5368-440d14814dbd@suse.com> References: <20170908144849.2958-1-jgross@suse.com> <20170908144849.2958-2-jgross@suse.com> <67503f2a-6d93-59c6-5a49-40fcb487859c@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drnNR-0003Ux-U7 for xen-devel@lists.xenproject.org; Tue, 12 Sep 2017 15:45:30 +0000 In-Reply-To: <67503f2a-6d93-59c6-5a49-40fcb487859c@oracle.com> Content-Language: de-DE List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Boris Ostrovsky , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gMTIvMDkvMTcgMTc6NDEsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToKPiAKPj4gK2ludCBhcmNo X2dudHRhYl9tYXBfc3RhdHVzKHVpbnQ2NF90ICpmcmFtZXMsIHVuc2lnbmVkIGxvbmcgbnJfZ2Zy YW1lcywKPj4gKwkJCSAgIHVuc2lnbmVkIGxvbmcgbWF4X25yX2dmcmFtZXMsCj4+ICsJCQkgICBn cmFudF9zdGF0dXNfdCAqKl9fc2hhcmVkKQo+PiArewo+PiArCWdyYW50X3N0YXR1c190ICpzaGFy ZWQgPSAqX19zaGFyZWQ7Cj4+ICsJdW5zaWduZWQgbG9uZyBhZGRyOwo+PiArCXVuc2lnbmVkIGxv bmcgaTsKPj4gKwo+PiArCWlmIChzaGFyZWQgPT0gTlVMTCkKPj4gKwkJKl9fc2hhcmVkID0gc2hh cmVkID0gZ250dGFiX3N0YXR1c192bV9hcmVhLmFyZWEtPmFkZHI7Cj4+ICsKPj4gKwlhZGRyID0g KHVuc2lnbmVkIGxvbmcpc2hhcmVkOwo+PiArCj4+ICsJZm9yIChpID0gMDsgaSA8IG5yX2dmcmFt ZXM7IGkrKykgewo+PiArCQlzZXRfcHRlX2F0KCZpbml0X21tLCBhZGRyLCBnbnR0YWJfc3RhdHVz X3ZtX2FyZWEucHRlc1tpXSwKPj4gKwkJCSAgIG1mbl9wdGUoZnJhbWVzW2ldLCBQQUdFX0tFUk5F TCkpOwo+PiArCQlhZGRyICs9IFBBR0VfU0laRTsKPj4gKwl9Cj4+ICsKPj4gKwlyZXR1cm4gMDsK Pj4gK30KPiAKPiBUaGlzIGxvb2tzIHByZXR0eSBtdWNoIGlkZW50aWNhbCB0byBhcmNoX2dudHRh Yl9tYXBfc2hhcmVkKCkgZXhjZXB0IGZvcgo+IGdudHRhYl9zaGFyZWRfdm1fYXJlYSB2cy4gZ250 dGFiX3N0YXR1c192bV9hcmVhLHdoaWNoIGNhbiBiZSBwYXNzZWQgaW4KPiBhcyBhIHBhcmFtZXRl ci4KPiAKPj4gKwo+PiAgdm9pZCBhcmNoX2dudHRhYl91bm1hcCh2b2lkICpzaGFyZWQsIHVuc2ln bmVkIGxvbmcgbnJfZ2ZyYW1lcykKPj4gIHsKPj4gKwlwdGVfdCAqKnB0ZXM7Cj4+ICAJdW5zaWdu ZWQgbG9uZyBhZGRyOwo+PiAgCXVuc2lnbmVkIGxvbmcgaTsKPj4gIAo+PiArCWlmIChzaGFyZWQg PT0gZ250dGFiX3N0YXR1c192bV9hcmVhLmFyZWEtPmFkZHIpCj4+ICsJCXB0ZXMgPSBnbnR0YWJf c3RhdHVzX3ZtX2FyZWEucHRlczsKPj4gKwllbHNlCj4+ICsJCXB0ZXMgPSBnbnR0YWJfc2hhcmVk X3ZtX2FyZWEucHRlczsKPj4gKwo+PiAgCWFkZHIgPSAodW5zaWduZWQgbG9uZylzaGFyZWQ7Cj4+ ICAKPj4gIAlmb3IgKGkgPSAwOyBpIDwgbnJfZ2ZyYW1lczsgaSsrKSB7Cj4+IC0JCXNldF9wdGVf YXQoJmluaXRfbW0sIGFkZHIsIGdudHRhYl9zaGFyZWRfdm1fYXJlYS5wdGVzW2ldLAo+PiAtCQkJ ICAgX19wdGUoMCkpOwo+PiArCQlzZXRfcHRlX2F0KCZpbml0X21tLCBhZGRyLCBwdGVzW2ldLCBf X3B0ZSgwKSk7Cj4+ICAJCWFkZHIgKz0gUEFHRV9TSVpFOwo+PiAgCX0KPiAKPiBBbmQgdGhpcyB0 b28gbG9va3MgbGlrZSBjYW4gYmUgZmFjdG9yZWQgb3V0ICh0byBzb21ldGhpbmcgbGlrZQo+IGFy Y2hfdXBkYXRlX2dudHRhYigpKS4gQnV0IHBlcmhhcHMgbm90IGluIHRoaXMgcGF0Y2guCj4gCj4+ ICB9Cj4+IEBAIC0xMDIsMTIgKzEyOSwzNSBAQCBzdGF0aWMgaW50IGFyY2hfZ250dGFiX3ZhbGxv YyhzdHJ1Y3QgZ250dGFiX3ZtX2FyZWEgKmFyZWEsIHVuc2lnbmVkIG5yX2ZyYW1lcykKPj4gIAly ZXR1cm4gMDsKPj4gIH0KPj4gIAo+PiAtaW50IGFyY2hfZ250dGFiX2luaXQodW5zaWduZWQgbG9u ZyBucl9zaGFyZWQpCj4+ICtzdGF0aWMgdm9pZCBhcmNoX2dudHRhYl92ZnJlZShzdHJ1Y3QgZ250 dGFiX3ZtX2FyZWEgKmFyZWEpCj4+ICB7Cj4+ICsJZnJlZV92bV9hcmVhKGFyZWEtPmFyZWEpOwo+ PiArCWtmcmVlKGFyZWEtPnB0ZXMpOwo+PiArfQo+IAo+IE5vdCBzdXJlIHRoZXJlIGlzIG5lZWQg Zm9yIHRoaXMgcm91dGluZS4gSXQgaXMgdXNlZCBvbmx5IG9uY2UuCj4gCj4gQWxzbywgYXMgYW4g b3ZlcmFsbCBjb21tZW50IC0tIEl0IGZlZWxzIGxpa2UgdGhlcmUgbWF5IGJlIHRvbyBtYW55Cj4g QlVHX09OKClzLgoKVGhpcyBwYXRjaCBpcyBtb3N0bHkgYSByZXZlcnQgb2YgRGF2aWQncyBwYXRj aCByZW1vdmluZyBncmFudCB2MiBzdXBwb3J0CndpdGgganVzdCB2ZXJ5IGZldyBhZGFwdGlvbnMu IEkgd2FudGVkIHRvIGtlZXAgaXQgYXMgc2ltaWxhciB0byB0aGUKZm9ybWVyIGdyYW50IHYyIHN1 cHBvcnQgYXMgcG9zc2libGUuCgoKSnVlcmdlbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==