From: Hin-Tak Leung <htl10@users.sourceforge.net>
To: Johan Hovold <johan@kernel.org>, Kalle Valo <kvalo@codeaurora.org>
Cc: Herton Ronaldo Krzesinski <herton@canonical.com>,
Larry Finger <larry.finger@lwfinger.net>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Siva Rebbagondla <siva8118@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 3/4] rtl8187: fix control-message timeouts
Date: Mon, 25 Oct 2021 19:11:50 +0000 (UTC) [thread overview]
Message-ID: <1202359771.1685642.1635189110010@mail.yahoo.com> (raw)
In-Reply-To: 1202359771.1685642.1635189110010.ref@mail.yahoo.com
> USB control-message timeouts are specified in milliseconds and should
> specifically not vary with CONFIG_HZ.
> Fixes: 605bebe23bf6 ("[PATCH] Add rtl8187 wireless driver")
> Cc: stable@vger.kernel.org # 2.6.23
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>
> ---
> .../net/wireless/realtek/rtl818x/rtl8187/rtl8225.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
> diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
> index 585784258c66..4efab907a3ac 100644
> --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
> +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
> @@ -28,7 +28,7 @@ u8 rtl818x_ioread8_idx(struct rtl8187_priv *priv,
> usb_control_msg(priv->udev, usb_rcvctrlpipe(priv->udev, 0),
> RTL8187_REQ_GET_REG, RTL8187_REQT_READ,
> (unsigned long)addr, idx & 0x03,
> - &priv->io_dmabuf->bits8, sizeof(val), HZ / 2);
> + &priv->io_dmabuf->bits8, sizeof(val), 500);
Looks reasonable, although I would have preferred a common defined value taken from a common header, instead of a hard-coded 1/2 second.
next parent reply other threads:[~2021-10-25 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1202359771.1685642.1635189110010.ref@mail.yahoo.com>
2021-10-25 19:11 ` Hin-Tak Leung [this message]
2021-10-25 12:05 [PATCH 0/4] wireless: fix control-message timeouts Johan Hovold
2021-10-25 12:05 ` [PATCH 3/4] rtl8187: " Johan Hovold
2021-10-28 13:26 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202359771.1685642.1635189110010@mail.yahoo.com \
--to=htl10@users.sourceforge.net \
--cc=amitkarwar@gmail.com \
--cc=herton@canonical.com \
--cc=johan@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=siva8118@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.