All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [PATCH] eal/linux: fix build with glibc 2.25
Date: Tue, 04 Apr 2017 14:51:25 +0200	[thread overview]
Message-ID: <12057052.OZe6dLyBjp@xps13> (raw)
In-Reply-To: <20170403083514.5401-1-jerin.jacob@caviumnetworks.com>

2017-04-03 14:05, Jerin Jacob:
> glibc 2.25 is warning about if applications depend on
> sys/types.h for makedev macro, it expects to be included
> from <sys/sysmacros.h>
> 
> Found this error while testing with GCC 6.3.1 on archlinux.
> 
> lib/librte_eal/linuxapp/eal/eal_pci_uio.c: In function ‘pci_mknod_uio_dev’:
> lib/librte_eal/linuxapp/eal/eal_pci_uio.c:134:13:
> error: In the GNU C Library, "makedev" is defined
> by <sys/sysmacros.h>. For historical compatibility, it is
> currently defined by <sys/types.h> as well, but we plan to
> remove this soon. To use "makedev", include <sys/sysmacros.h>
> directly. If you did not intend to use a system-defined macro
> "makedev", you should undefine it after including <sys/types.h>. [-Werror]
>  dev = makedev(major, minor);
>              ^~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied, thanks

      reply	other threads:[~2017-04-04 12:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03  8:35 [PATCH] eal/linux: fix build with glibc 2.25 Jerin Jacob
2017-04-04 12:51 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12057052.OZe6dLyBjp@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.