From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Date: Mon, 25 Mar 2019 16:07:11 +0000
Subject: [U-Boot] [REGRESSION: PATCH 34/34] drivers/net/fec: phy_init:
 remove redundant logic
In-Reply-To: <20190313082845.70B83C21FAB@lists.denx.de>
References: <20190313082845.70B83C21FAB@lists.denx.de>
Message-ID: <120740997b8dab076d17f91625de73b40ae54b48.camel@toradex.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano

On Wed, 2019-03-13 at 08:28 +0000, sbabic at denx.de wrote:
> > The phy_connect_dev(...) function from phy.c does all the handling
> > (inclusive catching fixed-link).
> > So we drop here the single steps and call just
> > phy_connect_dev(...).
> > Signed-off-by: Hannes Schmelzer <hannes.schmelzer@br-automation.com
> > >
> > Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> 
> Applied to u-boot-imx, master, thanks !
> 
> Best regards,
> Stefano Babic

Unfortunately, this commit broke Ethernet on the Vybrid. When re-basing 
my Colibri VF50/VF61 clean-up patch set ("colibri vybrid fixes, device
tree enablement and driver model conversion") I noticed that Ethernet
no longer works giving the following error messages:

Net:   Could not get PHY for FEC0: addr -19
eth-1: fec at 400d1000
Colibri VFxx # dhcp
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
Could not get PHY for FEC0: addr -19
No ethernet found.
Could not get PHY for FEC0: addr -19
Colibri VFxx # 

Bisecting points to this commit and reverting it indeed makes it work
again.

Has anybody else seen a similar issue (e.g. @Lukasz on pcm052)?

Cheers

Marcel