All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stephan Müller" <smueller@chronox.de>
To: Vladis Dronov <vdronov@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3] Jitter RNG - Permanent and Intermittent health errors
Date: Sun, 26 Mar 2023 10:51:29 +0200	[thread overview]
Message-ID: <12178306.O9o76ZdvQC@positron.chronox.de> (raw)
In-Reply-To: <CAMusb+RsaSdztEgUMO=JD-ZcJ19v41r1Mw0oY-CUgtJTr+FzTg@mail.gmail.com>

Am Samstag, 25. März 2023, 15:44:59 CEST schrieb Vladis Dronov:

Hi Vladis,

> Hi, Stephan,
> 
> On Fri, Mar 24, 2023 at 6:56 PM Stephan Mueller <smueller@chronox.de> wrote:
> > Thank you very much. I have fixed it in my local copy, but will wait for
> > another bit in case there are other reports.
> 
> A couple of more suggestions, if I may. These are really small,
> I'm suggesting them just due to a sense of perfection.
> 
> 1) A patch name. All the patches in this area look like
> "crypto: jitter - <lowercase letters>". Probably a patch name could be
> adjusted as "crypto: jitter - permanent and intermittent health errors"?

Will do.
> 
> 2) You use panic("Jitter RNG permanent health test failure\n") in your
> patch. With that, probably, jent_panic() could be removed, since
> nothing is using it, couldn't it?

Yes, you are right. I will remove it.
> 
> Best regards,
> Vladis


Thanks a lot
Stephan



  reply	other threads:[~2023-03-26  8:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23  7:17 [PATCH] crypto: Jitter RNG - Permanent and Intermittent health errors Stephan Müller
2023-03-24  9:27 ` Herbert Xu
2023-03-24 12:01   ` Stephan Mueller
2023-03-24 12:30 ` [PATCH v2] " Stephan Müller
2023-03-24 16:03   ` kernel test robot
2023-03-24 17:00 ` [PATCH v3] " Stephan Müller
2023-03-24 17:47   ` Vladis Dronov
2023-03-24 17:54     ` Stephan Mueller
2023-03-25 14:44       ` Vladis Dronov
2023-03-26  8:51         ` Stephan Müller [this message]
2023-03-27  7:03 ` [PATCH v4] crypto: jitter - permanent and intermittent " Stephan Müller
2023-03-27 16:40   ` Marcelo Henrique Cerri
2023-04-06  8:50   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12178306.O9o76ZdvQC@positron.chronox.de \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=vdronov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.