From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF1F0C433ED for ; Wed, 5 May 2021 10:16:43 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id B6C7961157 for ; Wed, 5 May 2021 10:16:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6C7961157 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF4C240143; Wed, 5 May 2021 12:16:41 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 216A040040 for ; Wed, 5 May 2021 12:16:40 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5AC35168D; Wed, 5 May 2021 06:16:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 05 May 2021 06:16:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= +8AJHqt2ruyw4wn+tyzRWdl0iMow0mi+PXEXmNn2wx0=; b=loRHoLmTDdFblKrh leYjMpL3J5dU5/PtPBvGzVurKOeJsA0xXQJP/yGzmETC1j963IzCrIJOAq4sIRFf qMSY9XX11kDRqqvlvghba8wpRsjxTRlV2xKPexUNRiUo4i7XDkHNxRz6Y+R4ZwQ5 0PUD5xXJsFFMbfzokE+T7rnN/KO8tlpxrWnoK3ttubiWmYSrsm/e9bhcKZ/GZTdo yY3rsIKTBhr1AbcDgBz0cTY671f0pUQ/K9ty6QUy7QEyiAhwsiNtp/jgHeh7m35u gmfXd6Dn4ceki24KUIQnYgiFVBch4QFVxva6W5ffoTu0VY70nIRsCU9btKS8aeLb 3Bpsng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=+8AJHqt2ruyw4wn+tyzRWdl0iMow0mi+PXEXmNn2w x0=; b=byJiywUHKJek917pVbUsyOREOBFop6dmaZU68vVgTyO0tIdIzquXgCp54 l4twqLf2Z7uaOLXZpwI8twwdw3R7UZG16nKc0pD4na2qtTEb/rkc81fXygX0eY8u plhdcAUFNrGO3Og07tjDOAJxzh7rI43Ck/iI5W8La8KzE8xBGldZb+vKdVPqoC3u /OF4ob4ErUgR9daDP7iSttAIv/tQNFIjnEa/I/tNzmVyutyLKYX1mccjqX5w3G9Z Qp+znYOaomYZXwkOQX3U4RXODK+wEkqQxtjAI2OPO1lSnP6w+gH4EClcinXr5ddd yFa8yWyPIbuv3IqV21GdVIPDtutsQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefkedgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 May 2021 06:16:35 -0400 (EDT) From: Thomas Monjalon To: Vladimir Medvedkin Cc: dev@dpdk.org, konstantin.ananyev@intel.com, andrey.chilikin@intel.com, ray.kinsella@intel.com, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, kda@semihalf.com Date: Wed, 05 May 2021 12:16:34 +0200 Message-ID: <12183288.lg1fQFyeHg@thomas> In-Reply-To: <1620138304-203463-1-git-send-email-vladimir.medvedkin@intel.com> References: <1620137248-203174-1-git-send-email-vladimir.medvedkin@intel.com> <1620138304-203463-1-git-send-email-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] hash: fix tuple adjustment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/05/2021 16:25, Vladimir Medvedkin: > rte_thash_adjust_tuple() uses random to generate a new subtuple if > fn() callback reports about collision. In some cases random changes > the subtuple in a way that after complementary bits are applied the > original tuple is obtained. This patch replaces random with subtuple > increment. > > Fixes: 28ebff11c2dc ("hash: add predictable RSS") > Cc: vladimir.medvedkin@intel.com > > Signed-off-by: Vladimir Medvedkin > --- > lib/hash/rte_thash.c | 121 ++++++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 100 insertions(+), 21 deletions(-) Waiting for a review. It is a complex change.