From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEJEt-0006AD-8O for qemu-devel@nongnu.org; Thu, 03 May 2018 14:46:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEJEq-0005cD-5m for qemu-devel@nongnu.org; Thu, 03 May 2018 14:45:59 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:45579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fEJEp-0005bB-VP for qemu-devel@nongnu.org; Thu, 03 May 2018 14:45:56 -0400 Received: by mail-pf0-x244.google.com with SMTP id c10so15410078pfi.12 for ; Thu, 03 May 2018 11:45:55 -0700 (PDT) References: <20180503091922.28733-1-edgar.iglesias@gmail.com> <20180503091922.28733-16-edgar.iglesias@gmail.com> From: Richard Henderson Message-ID: <12197a48-1ce1-eaa5-9d44-f43f21931d32@linaro.org> Date: Thu, 3 May 2018 11:45:51 -0700 MIME-Version: 1.0 In-Reply-To: <20180503091922.28733-16-edgar.iglesias@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 15/29] target-microblaze: Break out trap_userspace() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, sai.pavan.boddu@xilinx.com, alistair@alistair23.me, frasse.iglesias@gmail.com, edgar.iglesias@xilinx.com On 05/03/2018 02:19 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Break out trap_userspace() to avoid open coding it everywhere. > For privileged insns, we now always stop translation of the > current insn for cores without exceptions. > > Signed-off-by: Edgar E. Iglesias > --- > target/microblaze/translate.c | 76 +++++++++++++++---------------------------- > 1 file changed, 27 insertions(+), 49 deletions(-) Reviewed-by: Richard Henderson r~