* [PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt
@ 2017-11-06 22:31 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-06 22:31 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: dri-devel, linux-fbdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/video/fbdev/sm501fb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index 076dd27..7085cc0 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -1008,6 +1008,7 @@ static int sm501fb_blank_crt(int blank_mode, struct fb_info *info)
case FB_BLANK_POWERDOWN:
ctrl &= ~SM501_DC_CRT_CONTROL_ENABLE;
sm501_misc_control(fbi->dev->parent, SM501_MISC_DAC_POWER, 0);
+ /* fall through */
case FB_BLANK_NORMAL:
ctrl |= SM501_DC_CRT_CONTROL_BLANK;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt
@ 2017-11-06 22:31 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-06 22:31 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: dri-devel, linux-fbdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/video/fbdev/sm501fb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index 076dd27..7085cc0 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -1008,6 +1008,7 @@ static int sm501fb_blank_crt(int blank_mode, struct fb_info *info)
case FB_BLANK_POWERDOWN:
ctrl &= ~SM501_DC_CRT_CONTROL_ENABLE;
sm501_misc_control(fbi->dev->parent, SM501_MISC_DAC_POWER, 0);
+ /* fall through */
case FB_BLANK_NORMAL:
ctrl |= SM501_DC_CRT_CONTROL_BLANK;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt
2017-11-06 22:31 ` Gustavo A. R. Silva
(?)
@ 2017-11-09 15:57 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-11-09 15:57 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: dri-devel, linux-fbdev, linux-kernel
On Monday, November 06, 2017 04:31:18 PM Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Patch queued for 4.15, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt
@ 2017-11-09 15:57 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-11-09 15:57 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-fbdev, linux-kernel, dri-devel
On Monday, November 06, 2017 04:31:18 PM Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Patch queued for 4.15, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt
@ 2017-11-09 15:57 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-11-09 15:57 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-fbdev, linux-kernel, dri-devel
On Monday, November 06, 2017 04:31:18 PM Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Patch queued for 4.15, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-09 15:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20171106223123epcas2p205e8d945db1baf075e0e1005e308e81d@epcas2p2.samsung.com>
2017-11-06 22:31 ` [PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt Gustavo A. R. Silva
2017-11-06 22:31 ` Gustavo A. R. Silva
2017-11-09 15:57 ` Bartlomiej Zolnierkiewicz
2017-11-09 15:57 ` Bartlomiej Zolnierkiewicz
2017-11-09 15:57 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.