From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 2/6] x86/cpuid: Introduce recalculate_xstate() Date: Tue, 17 Jan 2017 15:15:37 +0000 Message-ID: <121b7beb-1fc4-63d8-77f7-aa6423301950@citrix.com> References: <1484566830-13916-3-git-send-email-andrew.cooper3@citrix.com> <1484652467-8251-1-git-send-email-andrew.cooper3@citrix.com> <587E21870200007800130CF5@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <587E21870200007800130CF5@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Xen-devel List-Id: xen-devel@lists.xenproject.org T24gMTcvMDEvMTcgMTI6NTIsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDE3LjAxLjE3IGF0 IDEyOjI3LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+IC0tLSBhL3hlbi9h cmNoL3g4Ni9jcHVpZC5jCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9jcHVpZC5jCj4+IEBAIC04MCw2 ICs4MCwxMDMgQEAgc3RhdGljIHZvaWQgc2FuaXRpc2VfZmVhdHVyZXNldCh1aW50MzJfdCAqZnMp Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmc1tGRUFUVVJFU0VUX2UxZF0gJiB+Q1BV SURfQ09NTU9OXzFEX0ZFQVRVUkVTKSk7Cj4+ICB9Cj4+ICAKPj4gK3N0YXRpYyB2b2lkIHJlY2Fs Y3VsYXRlX3hzdGF0ZShzdHJ1Y3QgY3B1aWRfcG9saWN5ICpwKQo+PiArewo+PiArICAgIHVpbnQ2 NF90IHhzdGF0ZXMgPSBYU1RBVEVfRlBfU1NFOwo+PiArICAgIHVpbnQzMl90IHhzdGF0ZV9zaXpl ID0gWFNUQVRFX0FSRUFfTUlOX1NJWkU7Cj4+ICsgICAgdW5zaWduZWQgaW50IGksIERhMSA9IHAt PnhzdGF0ZS5EYTE7Cj4+ICsKPj4gKyAgICAvKgo+PiArICAgICAqIFRoZSBEYTEgbGVhZiBpcyB0 aGUgb25seSBwaWVjZSBpZiBpbmZvcm1hdGlvbiBwcmVzZXJ2ZWQgaW4gdGhlIGNvbW1vbgo+PiAr ICAgICAqIGNhc2UuICBFdmVyeXRoaW5nIGVsc2UgaXMgZGVyaXZlZCBmcm9tIG90aGVyIGZlYXR1 cmUgc3RhdGUuCj4+ICsgICAgICovCj4gInBpZWNlIG9mIiBJIHRoaW5rLgoKQWggeWVzIC0gd2ls bCBmaXguCgo+Cj4+ICsgICAgbWVtc2V0KCZwLT54c3RhdGUsIDAsIHNpemVvZihwLT54c3RhdGUp KTsKPj4gKwo+PiArICAgIGlmICggIXAtPmJhc2ljLnhzYXZlICkKPj4gKyAgICAgICAgcmV0dXJu Owo+PiArCj4+ICsgICAgaWYgKCBwLT5iYXNpYy5hdnggKQo+PiArICAgIHsKPj4gKyAgICAgICAg eHN0YXRlcyB8PSBYU1RBVEVfWU1NOwo+PiArICAgICAgICB4c3RhdGVfc2l6ZSA9IG1heCh4c3Rh dGVfc2l6ZSwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgeHN0YXRlX29mZnNldHNbX1hT VEFURV9ZTU1dICsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgeHN0YXRlX3NpemVzW19Y U1RBVEVfWU1NXSk7Cj4+ICsgICAgfQo+PiArCj4+ICsgICAgaWYgKCBwLT5mZWF0Lm1weCApCj4+ ICsgICAgewo+PiArICAgICAgICB4c3RhdGVzIHw9IFhTVEFURV9CTkRSRUdTIHwgWFNUQVRFX0JO RENTUjsKPj4gKyAgICAgICAgeHN0YXRlX3NpemUgPSBtYXgoeHN0YXRlX3NpemUsCj4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgIHhzdGF0ZV9vZmZzZXRzW19YU1RBVEVfQk5EQ1NSXSArCj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgIHhzdGF0ZV9zaXplc1tfWFNUQVRFX0JORENTUl0p Owo+PiArICAgIH0KPj4gKwo+PiArICAgIGlmICggcC0+ZmVhdC5hdng1MTJmICkKPj4gKyAgICB7 Cj4+ICsgICAgICAgIHhzdGF0ZXMgfD0gWFNUQVRFX09QTUFTSyB8IFhTVEFURV9aTU0gfCBYU1RB VEVfSElfWk1NOwo+PiArICAgICAgICB4c3RhdGVfc2l6ZSA9IG1heCh4c3RhdGVfc2l6ZSwKPj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgeHN0YXRlX29mZnNldHNbX1hTVEFURV9ISV9aTU1d ICsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgeHN0YXRlX3NpemVzW19YU1RBVEVfSElf Wk1NXSk7Cj4+ICsgICAgfQo+PiArCj4+ICsgICAgaWYgKCBwLT5mZWF0LnBrdSApCj4+ICsgICAg ewo+PiArICAgICAgICB4c3RhdGVzIHw9IFhTVEFURV9QS1JVOwo+PiArICAgICAgICB4c3RhdGVf c2l6ZSA9IG1heCh4c3RhdGVfc2l6ZSwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgeHN0 YXRlX29mZnNldHNbX1hTVEFURV9QS1JVXSArCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg IHhzdGF0ZV9zaXplc1tfWFNUQVRFX1BLUlVdKTsKPj4gKyAgICB9Cj4+ICsKPj4gKyAgICBpZiAo IHAtPmV4dGQubHdwICkKPj4gKyAgICB7Cj4+ICsgICAgICAgIHhzdGF0ZXMgfD0gWFNUQVRFX0xX UDsKPj4gKyAgICAgICAgeHN0YXRlX3NpemUgPSBtYXgoeHN0YXRlX3NpemUsCj4+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgIHhzdGF0ZV9vZmZzZXRzW19YU1RBVEVfTFdQXSArCj4+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgIHhzdGF0ZV9zaXplc1tfWFNUQVRFX0xXUF0pOwo+PiArICAg IH0KPj4gKwo+PiArICAgIC8qIFNhbml0eSBjaGVjayB3ZSBhcmVuJ3QgYWR2ZXJ0aXNpbmcgdW5r bm93biBzdGF0ZXMuICovCj4+ICsgICAgQVNTRVJUKCh4c3RhdGVzICYgflhDTlRYVF9NQVNLKSA9 PSAwKTsKPj4gKwo+PiArICAgIHAtPnhzdGF0ZS5tYXhfc2l6ZSAgPSAgeHN0YXRlX3NpemU7Cj4+ ICsgICAgcC0+eHN0YXRlLnhjcjBfbG93ICA9ICB4c3RhdGVzICYgflhTVEFURV9YU0FWRVNfT05M WTsKPj4gKyAgICBwLT54c3RhdGUueGNyMF9oaWdoID0gKHhzdGF0ZXMgJiB+WFNUQVRFX1hTQVZF U19PTkxZKSA+PiAzMjsKPj4gKwo+PiArICAgIHAtPnhzdGF0ZS5EYTEgPSBEYTE7Cj4+ICsgICAg aWYgKCBwLT54c3RhdGUueHNhdmVzICkKPj4gKyAgICB7Cj4+ICsgICAgICAgIHAtPnhzdGF0ZS54 c3NfbG93ICAgPSAgeHN0YXRlcyAmIFhTVEFURV9YU0FWRVNfT05MWTsKPj4gKyAgICAgICAgcC0+ eHN0YXRlLnhzc19oaWdoICA9ICh4c3RhdGVzICYgWFNUQVRFX1hTQVZFU19PTkxZKSA+PiAzMjsK Pj4gKyAgICB9Cj4+ICsgICAgZWxzZQo+PiArICAgICAgICB4c3RhdGVzICY9IH5YU1RBVEVfWFNB VkVTX09OTFk7Cj4+ICsKPj4gKyAgICBmb3IgKCBpID0gMjsgaSA8IG1pbig2M3VsLCBBUlJBWV9T SVpFKHAtPnhzdGF0ZS5jb21wKSk7ICsraSApCj4+ICsgICAgewo+PiArICAgICAgICB1aW50NjRf dCBjdXJyX3hzdGF0ZSA9IDF1bCA8PCBpOwo+PiArCj4+ICsgICAgICAgIGlmICggISh4c3RhdGVz ICYgY3Vycl94c3RhdGUpICkKPj4gKyAgICAgICAgICAgIGNvbnRpbnVlOwo+PiArCj4+ICsgICAg ICAgIHAtPnhzdGF0ZS5jb21wW2ldLnNpemUgICA9IHhzdGF0ZV9zaXplc1tpXTsKPj4gKyAgICAg ICAgcC0+eHN0YXRlLmNvbXBbaV0ub2Zmc2V0ID0geHN0YXRlX29mZnNldHNbaV07Cj4+ICsgICAg ICAgIHAtPnhzdGF0ZS5jb21wW2ldLnhzcyAgICA9IGN1cnJfeHN0YXRlICYgWFNUQVRFX1hTQVZF U19PTkxZOwo+PiArICAgICAgICBwLT54c3RhdGUuY29tcFtpXS5hbGlnbiAgPSBjdXJyX3hzdGF0 ZSAmIHhzdGF0ZV9hbGlnbjsKPj4gKwo+PiArICAgICAgICAvKgo+PiArICAgICAgICAgKiBTYW5p dHkgY2hlY2tzOgo+PiArICAgICAgICAgKiAtIEFsbCB2YWxpZCBjb21wb25lbnRzIHNob3VsZCBo YXZlIG5vbi16ZXJvIHNpemUuCj4+ICsgICAgICAgICAqIC0gQWxsIHhjcjAgY29tcG9uZW50cyBz aG91bGQgaGF2ZSBub24temVybyBvZmZzZXQuCj4+ICsgICAgICAgICAqIC0gQWxsIHhzcyBjb21w b25lbnRzIHNob3VsZCByZXBvcnQgMCBvZmZzZXQuCj4+ICsgICAgICAgICAqLwo+PiArICAgICAg ICBBU1NFUlQoeHN0YXRlX3NpemVzW2ldKTsKPj4gKyAgICAgICAgaWYgKCBjdXJyX3hzdGF0ZSAm IFhTVEFURV9YU0FWRVNfT05MWSApCj4+ICsgICAgICAgICAgICBBU1NFUlQoeHN0YXRlX29mZnNl dHNbaV0gPT0gMCk7Cj4+ICsgICAgICAgIGVsc2UKPj4gKyAgICAgICAgICAgIEFTU0VSVCh4c3Rh dGVfb2Zmc2V0c1tpXSk7Cj4+ICsgICAgfQo+IEhtbSwgbm93IHRoYXQgSSBsb29rIGF0IHRoaXMg YWdhaW4gLSB3aGF0IGJ1c2luZXNzIGRvIHRoZXNlCj4gYXNzZXJ0aW9ucyBoYXZlIGhlcmU/IFRo ZXkncmUgY2hlY2tpbmcgaG9zdCBpbmZvcm1hdGlvbiwgd2hpY2gKPiBpc24ndCBnb2luZyB0byBj aGFuZ2UgcG9zdCBib290LiBTdWNoIGNoZWNraW5nLCBpZiBpbmRlZWQgd2FudGVkLAo+IHNob3Vs ZCBiZSBkb25lIG9uY2UgZHVyaW5nIHN5c3RlbSBib290LgoKSSBwdXQgdGhpcyBpbiB0byB0cnkg YW5kIGVuc3VyZSB0aGF0IHdlIGRvbid0IHB1dCBqdW5rIGludG8gdGhlIHBvbGljeSwKYnV0IHRo aW5raW5nIGFib3V0IGl0IG1vcmUsIGJ5IHRoZSB0aW1lIGRvIGhhdmUganVuayBpbiB0aGVzZSBh cnJheXMsIHdlCmhhdmUgYmlnZ2VyIHhzdGF0ZSBwcm9ibGVtcy4gIEkgd2lsbCBkcm9wIHRoZXNl IGZyb20gaGVyZSBhbmQgZm9jdXMgb24KYmVlZmluZyB1cCB0aGUgeHN0YXRlIGRyaXZlciBpdHNl bGYuCgo+Cj4gSSBhbHNvIHRoaW5rIHN1Y2ggY2hlY2tzIHNob3VsZCBiZSBjb25zaXN0ZW50IGlu IHN0eWxlIC0gZWl0aGVyIGJvdGgKPiBleHBsaWNpdGx5IGNvbXBhcmluZyB3aXRoIHplcm8sIG9y IHVzaW5nICEgaW4gdGhlIGlmKCkgYnJhbmNoIHRvIG1hdGNoCj4gdGhlIGVsc2Ugb25lLgo+Cj4+ IEBAIC0xNTQsNiArMTUyLDEzIEBAIHN0cnVjdCBjcHVpZF9wb2xpY3kKPj4gICAgICAgICAgICAg IH07Cj4+ICAgICAgICAgICAgICB1aW50MzJfdCAvKiBiICovOjMyLCB4c3NfbG93LCB4c3NfaGln aDsKPj4gICAgICAgICAgfTsKPj4gKwo+PiArICAgICAgICAvKiBQZXItY29tcG9uZW50IGNvbW1v biBzdGF0ZS4gIFZhbGlkIGZvciBpID49IDIuICovCj4+ICsgICAgICAgIHN0cnVjdCB7Cj4+ICsg ICAgICAgICAgICB1aW50MzJfdCBzaXplLCBvZmZzZXQ7Cj4+ICsgICAgICAgICAgICBib29sIHhz czoxLCBhbGlnbjoxOwo+PiArICAgICAgICAgICAgdWludDMyX3QgX3Jlc19kOwo+IEkgc2VlIHlv dSd2ZSBkZWNpZGVkIGFnYWluc3QgYW4gaW5uZXIgdW5pb24uIFNob3VsZCBiZSBmaW5lIG9mCj4g Y291cnNlLCBhdCBsZWFzdCB1bnRpbCB3ZSBoYXZlIGEgbmVlZCB0byBhY2Nlc3MgdGhlIGZ1bGwg RUNYIHZhbHVlCj4gYnkgbmFtZS4KCk9oIC0gSSBtaXNpbnRlcnByZXRlZCB3aGF0IHlvdSBtZWFu dCB0aGVuLgoKRGlkIHlvdSBtZWFuCgpzdHJ1Y3QgewogICAgdWludDMyX3Qgc2l6ZSwgb2Zmc2V0 OwogICAgdW5pb24gewogICAgICAgIHN0cnVjdCB7CiAgICAgICAgICAgIGJvb2wgeHNzOjEsIGFs aWduOjE7CiAgICAgICAgfTsKICAgICAgICB1aW50MzJfdCBjOwogICAgfTsKICAgIHVpbnQzMl90 IC8qIGQgKi86MzI7Cn07CgpUaGVuPwoKfkFuZHJldwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==