All of lore.kernel.org
 help / color / mirror / Atom feed
From: Enguerrand de Ribaucourt  <enguerrand.de-ribaucourt@savoirfairelinux.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v3 2/2] net: dp83822: disable rx error interrupt
Date: Mon, 12 Sep 2022 06:07:08 -0400 (EDT)	[thread overview]
Message-ID: <1223536756.162378.1662977228581.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <Yxohrg//utRPoJYc@kroah.com>

> From: "Greg KH" <gregkh@linuxfoundation.org>
> To: "Enguerrand de Ribaucourt" <enguerrand.de-ribaucourt@savoirfairelinux.com>
> Cc: stable@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>, "Jakub Kicinski" <kuba@kernel.org>
> Sent: Thursday, September 8, 2022 7:09:02 PM
> Subject: Re: [PATCH v3 2/2] net: dp83822: disable rx error interrupt

> On Wed, Sep 07, 2022 at 12:45:59PM +0200, Enguerrand de Ribaucourt wrote:
> > Some RX errors, notably when disconnecting the cable, increase the RCSR
> > register. Once half full (0x7fff), an interrupt flood is generated. I
> > measured ~3k/s interrupts even after the RX errors transfer was
> > stopped.

> > Since we don't read and clear the RCSR register, we should disable this
> > interrupt.

> > Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
>> Signed-off-by: Enguerrand de Ribaucourt
> > <enguerrand.de-ribaucourt@savoirfairelinux.com>
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > [backport of 5.10 commit 0e597e2affb90d6ea48df6890d882924acf71e19]
> > ---
> > drivers/net/phy/dp83822.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)

> Does not apply to 5.4.y or 4.19.y :(

I could apply the patch with no problems on those versions. I also could cherry-pick
the commit on the branch queue/5.4 from stable/linux-stable-rc.git without conflicts.

I can't reproduce the issue you seem to be facing when applying those patches. Would you
mind helping me finding what's wrong with the patch on those branches?

Thanks,

Enguerrand de Ribaucourt

  reply	other threads:[~2022-09-12 10:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 10:45 [PATCH v3 0/2] net: dp83822: backport fix interrupt floods Enguerrand de Ribaucourt
2022-09-07 10:45 ` [PATCH v3 1/2] net: dp83822: disable false carrier interrupt Enguerrand de Ribaucourt
2022-09-07 10:45 ` [PATCH v3 2/2] net: dp83822: disable rx error interrupt Enguerrand de Ribaucourt
2022-09-08 17:09   ` Greg KH
2022-09-12 10:07     ` Enguerrand de Ribaucourt [this message]
2022-09-12 14:39       ` Greg KH
2022-09-13  8:17       ` [PATCH v3] " Enguerrand de Ribaucourt
2022-09-13 11:30         ` Greg KH
2022-09-14  7:07           ` Enguerrand de Ribaucourt
2022-09-16  9:35             ` Greg KH
2022-09-08 17:07 ` [PATCH v3 0/2] net: dp83822: backport fix interrupt floods Greg KH
2022-09-12 10:02   ` Enguerrand de Ribaucourt
  -- strict thread matches above, loose matches on Subject: below --
2022-06-17 17:55 [PATCH] net: dp83822: disable false carrier interrupt Andrew Lunn
2022-06-23 13:46 ` [PATCH v3 0/2] net: dp83822: fix interrupt floods Enguerrand de Ribaucourt
2022-06-23 13:46   ` [PATCH v3 2/2] net: dp83822: disable rx error interrupt Enguerrand de Ribaucourt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223536756.162378.1662977228581.JavaMail.zimbra@savoirfairelinux.com \
    --to=enguerrand.de-ribaucourt@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.