From: logang@deltatee.com (Logan Gunthorpe)
Subject: [RFC PATCH 8/8] nvmet: add configfs interface for target passthru
Date: Fri, 13 Apr 2018 11:37:16 -0600 [thread overview]
Message-ID: <12238d4c-c01d-9590-2357-dbeabff23dfc@deltatee.com> (raw)
In-Reply-To: <20180413173004.GC23674@lst.de>
On 13/04/18 11:30 AM, Christoph Hellwig wrote:
> Maybe. But how would you design it? Have a passthrough filed under
> the subsystem that you can echo a controller name to? And then make
> the exclusive vs creating namespaces?
Yes. It only really requires one field (the path to the nvme char
device) and making it exclusive to namespaces doesn't seem that
unintuitive. An error and appropriate dmesg if one is set before the
other would be pretty clear and quickly understood (compared to a whole
new top level directory named 'pt'). When I'm playing around with
sysfs/configfs/debugfs interfaces I rarely read the documentation and
just watch dmesg if I see an error returned. When I first played around
with this patchset the current interface required me to look at the code
to understand what was going on (there was no documentation).
> Ugg. Hell no! Way too much magic.
Fair point.
Logan
next prev parent reply other threads:[~2018-04-13 17:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 6:57 [RFC PATCH 0/8] nvmet: implement target passthru commands support Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 1/8] nvme-core: add new interfaces Chaitanya Kulkarni
2018-03-30 17:48 ` Logan Gunthorpe
2018-04-02 23:25 ` Chaitanya Kulkarni
2018-04-04 11:52 ` Sagi Grimberg
2018-04-13 17:27 ` Christoph Hellwig
2018-03-30 6:57 ` [RFC PATCH 2/8] nvme-core: export existing ctrl and ns interfaces Chaitanya Kulkarni
2018-04-04 11:59 ` Sagi Grimberg
2018-03-30 6:57 ` [RFC PATCH 3/8] nvmet: add passthru members in target subsys Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 4/8] nvmet: use const values for id-ctrl Chaitanya Kulkarni
2018-03-30 18:50 ` Logan Gunthorpe
2018-04-02 23:27 ` Chaitanya Kulkarni
2018-04-13 17:28 ` Christoph Hellwig
2018-03-30 6:57 ` [RFC PATCH 5/8] nvmet: export nvmet_add_async_event api Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 6/8] nvmet: add target passthru command support Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 7/8] nvmet: integrate passthru code with target core Chaitanya Kulkarni
2018-03-30 6:57 ` [RFC PATCH 8/8] nvmet: add configfs interface for target passthru Chaitanya Kulkarni
2018-03-30 18:13 ` Logan Gunthorpe
2018-04-03 0:13 ` Chaitanya Kulkarni
2018-04-03 3:21 ` Logan Gunthorpe
2018-04-13 17:30 ` Christoph Hellwig
2018-04-13 17:37 ` Logan Gunthorpe [this message]
2018-04-13 21:50 ` Stephen Bates
2018-03-30 17:46 ` [RFC PATCH 0/8] nvmet: implement target passthru commands support Logan Gunthorpe
2018-04-02 23:23 ` Chaitanya Kulkarni
2018-04-04 11:44 ` Sagi Grimberg
2018-04-13 17:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12238d4c-c01d-9590-2357-dbeabff23dfc@deltatee.com \
--to=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.