All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Maxin B. John" <maxin.john@intel.com>,
	Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 4/4] tslib: move recipe from oe-core
Date: Fri, 16 Sep 2016 10:17:11 +1200	[thread overview]
Message-ID: <12285709.EfYBoYq9CT@peggleto-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <1472730043-31245-5-git-send-email-maxin.john@intel.com>

On Thu, 01 Sep 2016 14:40:43 Maxin B. John wrote:
> Move tslib recipe from oe-core layer.
> 
> Signed-off-by: Maxin B. John <maxin.john@intel.com>
> ---
>  meta-gpe/recipes-graphics/tslib/tslib/ts.conf  | 25 ++++++++++++
>  meta-gpe/recipes-graphics/tslib/tslib/tslib.sh |  8 ++++
>  meta-gpe/recipes-graphics/tslib/tslib_1.1.bb   | 53
> ++++++++++++++++++++++++++ 3 files changed, 86 insertions(+)
>  create mode 100644 meta-gpe/recipes-graphics/tslib/tslib/ts.conf
>  create mode 100644 meta-gpe/recipes-graphics/tslib/tslib/tslib.sh
>  create mode 100644 meta-gpe/recipes-graphics/tslib/tslib_1.1.bb
> 
> diff --git a/meta-gpe/recipes-graphics/tslib/tslib/ts.conf
> b/meta-gpe/recipes-graphics/tslib/tslib/ts.conf new file mode 100644
> index 0000000..1b0da93
> --- /dev/null
> +++ b/meta-gpe/recipes-graphics/tslib/tslib/ts.conf
> @@ -0,0 +1,25 @@
> +# Uncomment if you wish to use the linux input layer event interface
> +module_raw input
> +
> +# Uncomment if you're using a Sharp Zaurus SL-5500/SL-5000d
> +# module_raw collie
> +
> +# Uncomment if you're using a Sharp Zaurus SL-C700/C750/C760/C860
> +# module_raw corgi
> +
> +# Uncomment if you're using a device with a UCB1200/1300/1400 TS interface
> +# module_raw ucb1x00
> +
> +# Uncomment if you're using an HP iPaq h3600 or similar
> +# module_raw h3600
> +
> +# Uncomment if you're using a Hitachi Webpad
> +# module_raw mk712
> +
> +# Uncomment if you're using an IBM Arctic II
> +# module_raw arctic2
> +
> +module pthres pmin=1
> +module variance delta=30
> +module dejitter delta=100
> +module linear
> diff --git a/meta-gpe/recipes-graphics/tslib/tslib/tslib.sh
> b/meta-gpe/recipes-graphics/tslib/tslib/tslib.sh new file mode 100644
> index 0000000..7068e8d
> --- /dev/null
> +++ b/meta-gpe/recipes-graphics/tslib/tslib/tslib.sh
> @@ -0,0 +1,8 @@
> +#!/bin/sh
> +
> +if [ -e /dev/input/touchscreen0 ]; then
> +    TSLIB_TSDEVICE=/dev/input/touchscreen0
> +
> +    export TSLIB_TSDEVICE
> +fi
> +
> diff --git a/meta-gpe/recipes-graphics/tslib/tslib_1.1.bb
> b/meta-gpe/recipes-graphics/tslib/tslib_1.1.bb new file mode 100644
> index 0000000..b0264c3
> --- /dev/null
> +++ b/meta-gpe/recipes-graphics/tslib/tslib_1.1.bb
> @@ -0,0 +1,53 @@
> +SUMMARY = "An abstraction layer for touchscreen panel events"
> +DESCRIPTION = "Tslib is an abstraction layer for touchscreen panel \
> +events, as well as a filter stack for the manipulation of those events. \
> +Tslib is generally used on embedded devices to provide a common user \
> +space interface to touchscreen functionality."
> +HOMEPAGE = "http://tslib.berlios.de/"
> +
> +AUTHOR = "Russell King w/ plugins by Chris Larson et. al."
> +SECTION = "base"
> +LICENSE = "LGPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=f30a9716ef3762e3467a2f62bf790f0a"
> +
> +SRC_URI =
> "https://github.com/kergoth/tslib/releases/download/${PV}/tslib-${PV}.tar.x
> z;downloadfilename=tslib-${PV}.tar.xz \ +           file://ts.conf \
> +           file://tslib.sh \
> +"
> +
> +SRC_URI[md5sum] = "14771f8607b341bb4b297819d37e837d"
> +SRC_URI[sha256sum] =
> "fe35e5f710ea933b118f710e2ce4403ac076fe69926b570333867d4de082a51c" +
> +UPSTREAM_CHECK_URI = "https://github.com/kergoth/tslib/releases"
> +
> +inherit autotools pkgconfig
> +
> +EXTRA_OECONF = "--enable-shared --disable-h3600 --enable-input
> --disable-corgi --disable-collie --disable-mk712 --disable-arctic2
> --disable-ucb1x00" +
> +do_install_prepend() {
> +	install -m 0644 ${WORKDIR}/ts.conf ${S}/etc/ts.conf
> +}
> +
> +do_install_append() {
> +	install -d ${D}${sysconfdir}/profile.d/
> +	install -m 0755 ${WORKDIR}/tslib.sh ${D}${sysconfdir}/profile.d/
> +}
> +
> +# People should consider using udev's /dev/input/touchscreen0 symlink
> +# instead of detect-stylus
> +#RDEPENDS_tslib-conf_weird-machine = "detect-stylus"
> +RPROVIDES_tslib-conf = "libts-0.0-conf"
> +
> +PACKAGES =+ "tslib-conf tslib-tests tslib-calibrate"
> +DEBIAN_NOAUTONAME_tslib-conf = "1"
> +DEBIAN_NOAUTONAME_tslib-tests = "1"
> +DEBIAN_NOAUTONAME_tslib-calibrate = "1"
> +
> +RDEPENDS_${PN} = "tslib-conf"
> +RRECOMMENDS_${PN} = "pointercal"
> +
> +FILES_${PN}-dev += "${libdir}/ts/*.la"
> +FILES_tslib-conf = "${sysconfdir}/ts.conf ${sysconfdir}/profile.d/tslib.sh
> ${datadir}/tslib" +FILES_${PN} = "${libdir}/*.so.* ${libdir}/ts/*.so*"
> +FILES_tslib-calibrate += "${bindir}/ts_calibrate"
> +FILES_tslib-tests = "${bindir}/ts_harvest ${bindir}/ts_print
> ${bindir}/ts_print_raw ${bindir}/ts_test"

So it seems like this has been blocked purely based on indentation that 
arguably doesn't even really matter, and as a result we no longer have tslib 
anywhere. Can you guys please resolve this ASAP?

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


  parent reply	other threads:[~2016-09-15 22:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 11:40 [PATCH 0/4] move tslib, pointercal and xtscal recipes from oe-core Maxin B. John
2016-09-01 11:40 ` [PATCH 1/4] pointercal: move recipe " Maxin B. John
2016-09-05 11:37   ` Martin Jansa
2016-09-01 11:40 ` [PATCH 2/4] meta-gpe: add pointercal to layer.conf Maxin B. John
2016-09-01 11:40 ` [PATCH 3/4] xtscal: move recipe from oe-core Maxin B. John
2016-09-01 11:40 ` [PATCH 4/4] tslib: " Maxin B. John
2016-09-05 11:39   ` Martin Jansa
2016-09-15 22:17   ` Paul Eggleton [this message]
2016-09-15 22:19     ` Paul Eggleton
2016-09-16  8:50       ` Maxin B. John
2016-09-16 12:10         ` Andrea Adami
2016-09-16 15:08           ` Burton, Ross
2016-09-17  0:43             ` Paul Eggleton
2016-09-19 13:08               ` Mike Looijmans
2016-09-21  2:37       ` Khem Raj
2016-09-21  4:36         ` Jonathan Liu
2016-09-21 14:34           ` Martin Jansa
2016-09-16 11:19 [PATCH v2 0/4] move tslib, pointercal and xtscal recipes " Maxin B. John
2016-09-16 11:19 ` [PATCH 4/4] tslib: move recipe " Maxin B. John
2016-09-21 15:47 [PATCH v3 0/4] move tslib, pointercal and xtscal recipes " Maxin B. John
2016-09-21 15:47 ` [PATCH 4/4] tslib: move recipe " Maxin B. John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12285709.EfYBoYq9CT@peggleto-mobl.ger.corp.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=martin.jansa@gmail.com \
    --cc=maxin.john@intel.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.