From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAWkO-0004Tr-Go for qemu-devel@nongnu.org; Wed, 10 Dec 2008 16:37:32 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAWkI-0004RA-V2 for qemu-devel@nongnu.org; Wed, 10 Dec 2008 16:37:31 -0500 Received: from [199.232.76.173] (port=49216 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAWkI-0004R5-Q2 for qemu-devel@nongnu.org; Wed, 10 Dec 2008 16:37:26 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:45146) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LAWkI-0001rG-Ca for qemu-devel@nongnu.org; Wed, 10 Dec 2008 16:37:26 -0500 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e31.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id mBALZwJI022612 for ; Wed, 10 Dec 2008 14:35:58 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mBALbCuV040494 for ; Wed, 10 Dec 2008 14:37:16 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mBALbBbL004055 for ; Wed, 10 Dec 2008 14:37:11 -0700 Subject: Re: [Qemu-devel] [PATCH 00/13] Cleanup some logging code From: Hollis Blanchard In-Reply-To: <1228933464-7670-1-git-send-email-ehabkost@redhat.com> References: <1228933464-7670-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain Date: Wed, 10 Dec 2008 15:37:10 -0600 Message-Id: <1228945030.15931.0.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eduardo Habkost On Wed, 2008-12-10 at 16:24 -0200, Eduardo Habkost wrote: > The following patches are small cleanups of the logging code on multiple > partes of qemu. Most of them are for removing duplicated code and #ifdefs > from the code. The patches are available on a git tree (see pull request > below). > > My long-term plan is to have a propper logging API on qemu, instead of > the global variables 'loglevel' and 'logfile'. These cleanups should > make that work easier, in addition to the code readability improvement. Sounds good to me. You might want to look at GRUB2's grub_dprintf(), which has proven invaluable for low-level remote debugging. Basically you can just tell someone to run "set debug=disk" at runtime to enable the "disk" class of debug output. Other classes include partition map, ELF loading, filesystems, etc. It's nothing revolutionary, but it's been really really useful. -- Hollis Blanchard IBM Linux Technology Center