From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LB9ew-0007nZ-JR for qemu-devel@nongnu.org; Fri, 12 Dec 2008 10:10:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LB9el-0007a6-Ur for qemu-devel@nongnu.org; Fri, 12 Dec 2008 10:10:21 -0500 Received: from [199.232.76.173] (port=50377 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LB9el-0007ZU-Dl for qemu-devel@nongnu.org; Fri, 12 Dec 2008 10:10:19 -0500 Received: from mx2.redhat.com ([66.187.237.31]:32971) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LB9ek-0001dy-Ko for qemu-devel@nongnu.org; Fri, 12 Dec 2008 10:10:19 -0500 From: Eduardo Habkost Date: Fri, 12 Dec 2008 13:08:39 -0200 Message-Id: <1229094550-2022-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 00/31] Logging code cleanup, take 2 Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eduardo Habkost This is a new take of the patches for cleaning up qemu logging/debugging code. The series grow a little, as I've macrofied more #ifdefs on other files. I've also changed the macros to use 'foo(bar, ## __VA_ARGS__)' instead of 'foo(bar, __VA_ARGS__)', as suggested by Anthony. The patches on this series shouldn't bring any change on the behavior of the code. They are just replacing #ifdefs with macros with the same behavior. My long-term plan is to have a propper logging API on qemu, instead of the global variables 'loglevel' and 'logfile'. These cleanups should make that work easier, in addition to the code readability improvement. This series is available on a git repository, at: git://github.com/ehabkost/qemu-hacks.git logging-cleanup I have a git branch where I've added qemu-log.h macros that can become the logging API, and converted all existing references to the 'logfile' and 'loglevel' variables to use those macros. I plan to submit that soon, after testing and polishing it. For those interested, the work-in-progress branch can be seen at: git://github.com/ehabkost/qemu-hacks.git hacking/log-api --- The following changes since commit 8de24106355d25512a8578ac83dab0c7515575b0: aurel32 (1): PPC405EP: fix fpga write function are available in the git repository at: git://github.com/ehabkost/qemu-hacks.git logging-cleanup Eduardo Habkost (31): hw/ppc.c: LOG_IRQ macro hw/ppc.c: use LOG_IRQ instead of #ifdefs hw/ppc.c: LOG_TB macro hw/ppc.c: use LOG_TB instead of #ifdefs vl.c: LOG_IOPORT macro vl.c: use LOG_IOPORT instead of #ifdefs kqemu.c: LOG_INT macro kqemu.c: use LOG_INT instead of #ifdefs kqemu.c: LOG_INT_STATE macro kqemu.c: use LOG_INT_STATE instead of #ifdefs kqemu.c: kill remaining DEBUG #ifdefs target-i386/op_helper.c: LOG_PCALL macro target-i386/op_helper.c: LOG_PCALL_STATE macro target-i386/op_helper.c: use LOG_PCALL instead of #ifdefs target-i386/op_helper.c: use LOG_PCALL/LOG_PCALL_STATE target-cris/translate.c: LOG_DIS macro target-cris: replace D(fprintf(logfile, ...)) macros with D_LOG(...) target-mips/translate.c: LOG_DISAS macro target-ppc/helper.c: LOG_MMU macro target-ppc/helper.c: LOG_SWTLB macro target-ppc/helper.c: convert commented-out debug code to LOG_SWTLB target-ppc/helper.c: LOG_BATS macro target-ppc/helper.c: LOG_SLB macro target-ppc/helper.c: LOG_EXCP macro target-ppc/helper.c: remaining LOG_BATS & LOG_MMU conversions target-ppc/helper.c: LOG_MMU_STATE macro target-ppc/op_helper.c: LOG_SWTLB macro target-ppc/translate.c: LOG_DISAS macro hw/ppc4xx_devs.c: LOG_UIC macro target-alpha/translate.c: LOG_DISAS macro linux-user/vm86.c: LOG_VM86 macro hw/ppc.c | 313 ++++++++++---------------------------------- hw/ppc4xx_devs.c | 58 +++------ kqemu.c | 77 ++++------- linux-user/vm86.c | 39 +++--- target-alpha/translate.c | 28 ++-- target-cris/helper.c | 26 +++- target-cris/mmu.c | 12 +- target-cris/op_helper.c | 26 +++-- target-cris/translate.c | 289 ++++++++++++++++++++-------------------- target-i386/op_helper.c | 57 ++++----- target-mips/translate.c | 116 +++------------- target-ppc/helper.c | 328 +++++++++++++++------------------------------- target-ppc/op_helper.c | 64 +++------- target-ppc/translate.c | 24 ++-- vl.c | 40 +++---- 15 files changed, 532 insertions(+), 965 deletions(-) -- Eduardo