From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goyH1-0005GN-3j for qemu-devel@nongnu.org; Wed, 30 Jan 2019 17:23:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goyH0-0006Hn-Cg for qemu-devel@nongnu.org; Wed, 30 Jan 2019 17:23:59 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39968) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1goyH0-0006H6-1t for qemu-devel@nongnu.org; Wed, 30 Jan 2019 17:23:58 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0UMKM3t087719 for ; Wed, 30 Jan 2019 17:23:56 -0500 Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qbkv92144-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 30 Jan 2019 17:23:56 -0500 Received: from localhost by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 Jan 2019 22:23:55 -0000 References: <1548768562-20007-1-git-send-email-jjherne@linux.ibm.com> <1548768562-20007-3-git-send-email-jjherne@linux.ibm.com> From: Farhan Ali Date: Wed, 30 Jan 2019 17:23:49 -0500 MIME-Version: 1.0 In-Reply-To: <1548768562-20007-3-git-send-email-jjherne@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <122a2e16-b5ca-b666-d080-4afdfd0f6d34@linux.ibm.com> Subject: Re: [Qemu-devel] [PATCH 02/15] s390-bios: decouple cio setup from virtio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jason J. Herne" , qemu-devel@nongnu.org, qemu-s390x@nongnu.org, cohuck@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com On 01/29/2019 08:29 AM, Jason J. Herne wrote: > Move channel i/o setup code out to a separate function. This decouples cio > setup from the virtio code path and allows us to make use of it for booting > dasd devices. > > Signed-off-by: Jason J. Herne > Acked-by: Halil Pasic > Reviewed-by: Collin Walling > --- > pc-bios/s390-ccw/main.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c > index 544851d..e82fe2c 100644 > --- a/pc-bios/s390-ccw/main.c > +++ b/pc-bios/s390-ccw/main.c > @@ -99,6 +99,18 @@ static void menu_setup(void) > } > } > > +/* > + * Initialize the channel I/O subsystem so we can talk to our ipl/boot device. > + */ > +static void css_setup(void) > +{ > + /* > + * Unconditionally enable mss support. In every sane configuration this > + * will succeed; and even if it doesn't, stsch_err() can handle it. > + */ > + enable_mss_facility(); > +} > + > static void virtio_setup(void) > { > Schib schib; > @@ -109,13 +121,6 @@ static void virtio_setup(void) > VDev *vdev = virtio_get_device(); > QemuIplParameters *early_qipl = (QemuIplParameters *)QIPL_ADDRESS; > > - /* > - * We unconditionally enable mss support. In every sane configuration, > - * this will succeed; and even if it doesn't, stsch_err() can deal > - * with the consequences. > - */ > - enable_mss_facility(); > - > sclp_get_loadparm_ascii(loadparm_str); > memcpy(ldp + 10, loadparm_str, LOADPARM_LEN); > sclp_print(ldp); > @@ -168,6 +173,7 @@ static void virtio_setup(void) > int main(void) > { > sclp_setup(); > + css_setup(); > virtio_setup(); > > zipl_load(); /* no return */ > Reviewed-by: Farhan Ali