From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35542C4167B for ; Thu, 10 Nov 2022 17:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229678AbiKJRph (ORCPT ); Thu, 10 Nov 2022 12:45:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbiKJRpc (ORCPT ); Thu, 10 Nov 2022 12:45:32 -0500 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15CE62DAA4; Thu, 10 Nov 2022 09:45:29 -0800 (PST) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AAHikMB018321; Thu, 10 Nov 2022 11:44:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668102286; bh=yW1uO952OcBO2fElaCf2Q7WipVJKTPj/Dc1SJmpKnwQ=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=jmWpEZtBQjS+jkYmlQnMGGEGS3FoSgizdYC4mDmAC9EuKZcIWv9APoor5v+zti9VA 2Ok1cqJCcekDc4R5Zv49W+RIYyJMHulx4Oz/6EPnRwe6eiBEsO37Rnv5oDFD4GmSCV kG3QiELaUFr3RkwjhRlSUU99+fHUNDOfYdi/24G8= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AAHik26061482 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 10 Nov 2022 11:44:46 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Thu, 10 Nov 2022 11:44:46 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Thu, 10 Nov 2022 11:44:45 -0600 Received: from [128.247.81.39] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2AAHijVL130696; Thu, 10 Nov 2022 11:44:45 -0600 Message-ID: <1231f3e6-61a7-ca3c-2fbb-679b583e0df1@ti.com> Date: Thu, 10 Nov 2022 11:44:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC To: Kevin Hilman , jerome Neanne , Nishanth Menon CC: Lee Jones , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> <20221105000104.rtj3r6ufqwqmepon@keenly> <7heduewjp0.fsf@baylibre.com> <5418ac3b-04d7-5e77-7612-c8f168e24621@ti.com> <1267bf43-618c-7347-be3a-2792c656d9b6@baylibre.com> <7hk042agn4.fsf@baylibre.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <7hk042agn4.fsf@baylibre.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/22 11:00 AM, Kevin Hilman wrote: > jerome Neanne writes: > >> On 09/11/2022 22:59, Andrew Davis wrote: >>> On 11/7/22 3:14 PM, Kevin Hilman wrote: >>>> Nishanth Menon writes: >>>> >>>>> On 13:58-20221104, jerome Neanne wrote: >>>>>> >>>>> [...] >>>>> >>>>>> >>>>>>> >>>>>>> Can you try an compile with W=1 please. >>>>>> This raise one warning on mfd: >>>>>> drivers/mfd/tps65219.c:28:12: warning: ‘tps65219_soft_shutdown’ >>>>>> defined but >>>>>> not used [-Wunused-function] >>>>>>     28 | static int tps65219_soft_shutdown(struct tps65219 *tps) >>>>>>        |            ^~~~~~~~~~~~~~~~~~~~~~ >>>>>> soft_shutdown has been validated and is used in TI baseline even if not >>>>>> hooked in upstream version further to this review: >>>>>> https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.com/ >>>>>> >>>>>> It was a TI requirement to implement it... >>>>>> Let me know if you want me to remove this function or if we can keep >>>>>> it like >>>>>> this. >>>>> >>>>> There are platforms without psci, correct? I think the comment was to >>>>> drop the force override with system-power-controller property, >>>>> >>>>> if (!pm_power_off) { >>>>>     tps65219_i2c_client = client; >>>>>     pm_power_off = &tps65219_pm_power_off; >>>>> } >>>>> >>>>> Could still be valid for such platforms, no? I do see that the >>>>> capability that the PMIC has - which is software shutdown is a valid >>>>> feature that we support in many different PMIC drivers. Is'nt the job of >>>>> the driver to introduce the functionality in a manner that is >>>>> appropriate to the OS framework? >>>> >>>> Yeah, I think Nishanth is right here. >>>> >>>> We should probably keep the `if (!pm_power_off)` part so the PMIC will >>>> be used if PSCI is not, but it also allows an easy way to test/use the >>>> PMIC >>>> shutdown functionality downstream if needed. >>>> >>> >>> Then should be using the sys-off handler API[0] so it doesn't block PSCI >>> which is also switching over[1]. >>> >>> Andrew >>> >>> [0] https://lwn.net/Articles/894511/ >>> [1] https://www.spinics.net/lists/arm-kernel/msg1024127.html >> Can we go for upstream with v7 without tps65219_soft_shutdown. Then if >> everyone agrees with Andrew proposal, I'll submit a separate patch which >> adds implementation of tps65219_soft_shutdown support through sys-off >> handler. >> >> So that we are not blocking upstream in case further >> discussions/alignment are required. > > Seems OK to me. Nishanth? Andrew? > > But I think you'll need to at least submit a v8 without the unused > code/dead code that Lee pointed out. > If you need the v8 anyway, then add support through sys-off in that spin, should only be a couple lines of change. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95D37C433FE for ; Thu, 10 Nov 2022 17:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ObQiYc4kunHiBON/UHS8ren0dyvJrIOqF7NxxlrL/w=; b=Eg14nbTr0nSqD8 BofiqhCJ2zeA3v3CEapkRxBuDkJU0FHBVcceIUbzGiLwJB1tOGNm2Ja8RYgkf2PZGVjjhYfsZBlrd BB8ytqwQgnwHSUS1eRtK8y/+O6igZQ5BG2iNusb3s/rM3oMWBi0XE1H1SjG2P433q/A5MiQhlaQY8 TcqLvaAljnHmeKIEvSF/r1hbfx2UwaAAjpUaYrI+BCSjdjBCWSLKZflCRsTtO+jQT/bFpxEh7Blq3 O93Z2ko1mxoV0mQ/V4DMfx9YTfs1GG5ImRLmm2o0pdw8hx+9mFfQ1A13WoLBnF3yGW0U+xlU2Tn2t iDXOKZf7PuHmusIN5Z0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otBcF-007oSm-2Y; Thu, 10 Nov 2022 17:45:28 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otBcB-007oQI-34 for linux-arm-kernel@lists.infradead.org; Thu, 10 Nov 2022 17:45:24 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 2AAHikMB018321; Thu, 10 Nov 2022 11:44:46 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1668102286; bh=yW1uO952OcBO2fElaCf2Q7WipVJKTPj/Dc1SJmpKnwQ=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=jmWpEZtBQjS+jkYmlQnMGGEGS3FoSgizdYC4mDmAC9EuKZcIWv9APoor5v+zti9VA 2Ok1cqJCcekDc4R5Zv49W+RIYyJMHulx4Oz/6EPnRwe6eiBEsO37Rnv5oDFD4GmSCV kG3QiELaUFr3RkwjhRlSUU99+fHUNDOfYdi/24G8= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 2AAHik26061482 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 10 Nov 2022 11:44:46 -0600 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Thu, 10 Nov 2022 11:44:46 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Thu, 10 Nov 2022 11:44:45 -0600 Received: from [128.247.81.39] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 2AAHijVL130696; Thu, 10 Nov 2022 11:44:45 -0600 Message-ID: <1231f3e6-61a7-ca3c-2fbb-679b583e0df1@ti.com> Date: Thu, 10 Nov 2022 11:44:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC To: Kevin Hilman , jerome Neanne , Nishanth Menon CC: Lee Jones , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> <20221105000104.rtj3r6ufqwqmepon@keenly> <7heduewjp0.fsf@baylibre.com> <5418ac3b-04d7-5e77-7612-c8f168e24621@ti.com> <1267bf43-618c-7347-be3a-2792c656d9b6@baylibre.com> <7hk042agn4.fsf@baylibre.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <7hk042agn4.fsf@baylibre.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221110_094523_232415_84EF86AC X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTEvMTAvMjIgMTE6MDAgQU0sIEtldmluIEhpbG1hbiB3cm90ZToKPiBqZXJvbWUgTmVhbm5l IDxqbmVhbm5lQGJheWxpYnJlLmNvbT4gd3JpdGVzOgo+IAo+PiBPbiAwOS8xMS8yMDIyIDIyOjU5 LCBBbmRyZXcgRGF2aXMgd3JvdGU6Cj4+PiBPbiAxMS83LzIyIDM6MTQgUE0sIEtldmluIEhpbG1h biB3cm90ZToKPj4+PiBOaXNoYW50aCBNZW5vbiA8bm1AdGkuY29tPiB3cml0ZXM6Cj4+Pj4KPj4+ Pj4gT24gMTM6NTgtMjAyMjExMDQsIGplcm9tZSBOZWFubmUgd3JvdGU6Cj4+Pj4+Pgo+Pj4+PiBb Li4uXQo+Pj4+Pgo+Pj4+Pj4KPj4+Pj4+Pgo+Pj4+Pj4+IENhbiB5b3UgdHJ5IGFuIGNvbXBpbGUg d2l0aCBXPTEgcGxlYXNlLgo+Pj4+Pj4gVGhpcyByYWlzZSBvbmUgd2FybmluZyBvbiBtZmQ6Cj4+ Pj4+PiBkcml2ZXJzL21mZC90cHM2NTIxOS5jOjI4OjEyOiB3YXJuaW5nOiDigJh0cHM2NTIxOV9z b2Z0X3NodXRkb3du4oCZCj4+Pj4+PiBkZWZpbmVkIGJ1dAo+Pj4+Pj4gbm90IHVzZWQgWy1XdW51 c2VkLWZ1bmN0aW9uXQo+Pj4+Pj4gIMKgwqDCoCAyOCB8IHN0YXRpYyBpbnQgdHBzNjUyMTlfc29m dF9zaHV0ZG93bihzdHJ1Y3QgdHBzNjUyMTkgKnRwcykKPj4+Pj4+ICDCoMKgwqDCoMKgwqAgfMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgXn5+fn5+fn5+fn5+fn5+fn5+fn5+fgo+Pj4+Pj4gc29mdF9z aHV0ZG93biBoYXMgYmVlbiB2YWxpZGF0ZWQgYW5kIGlzIHVzZWQgaW4gVEkgYmFzZWxpbmUgZXZl biBpZiBub3QKPj4+Pj4+IGhvb2tlZCBpbiB1cHN0cmVhbSB2ZXJzaW9uIGZ1cnRoZXIgdG8gdGhp cyByZXZpZXc6Cj4+Pj4+PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMjIwODI1MTUw MjI0LjgyNjI1OC01LW1zcEBiYXlsaWJyZS5jb20vCj4+Pj4+Pgo+Pj4+Pj4gSXQgd2FzIGEgVEkg cmVxdWlyZW1lbnQgdG8gaW1wbGVtZW50IGl0Li4uCj4+Pj4+PiBMZXQgbWUga25vdyBpZiB5b3Ug d2FudCBtZSB0byByZW1vdmUgdGhpcyBmdW5jdGlvbiBvciBpZiB3ZSBjYW4ga2VlcAo+Pj4+Pj4g aXQgbGlrZQo+Pj4+Pj4gdGhpcy4KPj4+Pj4KPj4+Pj4gVGhlcmUgYXJlIHBsYXRmb3JtcyB3aXRo b3V0IHBzY2ksIGNvcnJlY3Q/IEkgdGhpbmsgdGhlIGNvbW1lbnQgd2FzIHRvCj4+Pj4+IGRyb3Ag dGhlIGZvcmNlIG92ZXJyaWRlIHdpdGggc3lzdGVtLXBvd2VyLWNvbnRyb2xsZXIgcHJvcGVydHks Cj4+Pj4+Cj4+Pj4+IGlmICghcG1fcG93ZXJfb2ZmKSB7Cj4+Pj4+ICDCoMKgwqDCoHRwczY1MjE5 X2kyY19jbGllbnQgPSBjbGllbnQ7Cj4+Pj4+ICDCoMKgwqDCoHBtX3Bvd2VyX29mZiA9ICZ0cHM2 NTIxOV9wbV9wb3dlcl9vZmY7Cj4+Pj4+IH0KPj4+Pj4KPj4+Pj4gQ291bGQgc3RpbGwgYmUgdmFs aWQgZm9yIHN1Y2ggcGxhdGZvcm1zLCBubz8gSSBkbyBzZWUgdGhhdCB0aGUKPj4+Pj4gY2FwYWJp bGl0eSB0aGF0IHRoZSBQTUlDIGhhcyAtIHdoaWNoIGlzIHNvZnR3YXJlIHNodXRkb3duIGlzIGEg dmFsaWQKPj4+Pj4gZmVhdHVyZSB0aGF0IHdlIHN1cHBvcnQgaW4gbWFueSBkaWZmZXJlbnQgUE1J QyBkcml2ZXJzLiBJcydudCB0aGUgam9iIG9mCj4+Pj4+IHRoZSBkcml2ZXIgdG8gaW50cm9kdWNl IHRoZSBmdW5jdGlvbmFsaXR5IGluIGEgbWFubmVyIHRoYXQgaXMKPj4+Pj4gYXBwcm9wcmlhdGUg dG8gdGhlIE9TIGZyYW1ld29yaz8KPj4+Pgo+Pj4+IFllYWgsIEkgdGhpbmsgTmlzaGFudGggaXMg cmlnaHQgaGVyZS4KPj4+Pgo+Pj4+IFdlIHNob3VsZCBwcm9iYWJseSBrZWVwIHRoZSBgaWYgKCFw bV9wb3dlcl9vZmYpYCBwYXJ0IHNvIHRoZSBQTUlDIHdpbGwKPj4+PiBiZSB1c2VkIGlmIFBTQ0kg aXMgbm90LCBidXQgaXQgYWxzbyBhbGxvd3MgYW4gZWFzeSB3YXkgdG8gdGVzdC91c2UgdGhlCj4+ Pj4gUE1JQwo+Pj4+IHNodXRkb3duIGZ1bmN0aW9uYWxpdHkgZG93bnN0cmVhbSBpZiBuZWVkZWQu Cj4+Pj4KPj4+Cj4+PiBUaGVuIHNob3VsZCBiZSB1c2luZyB0aGUgc3lzLW9mZiBoYW5kbGVyIEFQ SVswXSBzbyBpdCBkb2Vzbid0IGJsb2NrIFBTQ0kKPj4+IHdoaWNoIGlzIGFsc28gc3dpdGNoaW5n IG92ZXJbMV0uCj4+Pgo+Pj4gQW5kcmV3Cj4+Pgo+Pj4gWzBdIGh0dHBzOi8vbHduLm5ldC9BcnRp Y2xlcy84OTQ1MTEvCj4+PiBbMV0gaHR0cHM6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMvYXJtLWtl cm5lbC9tc2cxMDI0MTI3Lmh0bWwKPj4gQ2FuIHdlIGdvIGZvciB1cHN0cmVhbSB3aXRoIHY3IHdp dGhvdXQgdHBzNjUyMTlfc29mdF9zaHV0ZG93bi4gVGhlbiBpZgo+PiBldmVyeW9uZSBhZ3JlZXMg d2l0aCBBbmRyZXcgcHJvcG9zYWwsIEknbGwgc3VibWl0IGEgc2VwYXJhdGUgcGF0Y2ggd2hpY2gK Pj4gYWRkcyBpbXBsZW1lbnRhdGlvbiBvZiB0cHM2NTIxOV9zb2Z0X3NodXRkb3duIHN1cHBvcnQg dGhyb3VnaCBzeXMtb2ZmCj4+IGhhbmRsZXIuCj4+Cj4+IFNvIHRoYXQgd2UgYXJlIG5vdCBibG9j a2luZyB1cHN0cmVhbSBpbiBjYXNlIGZ1cnRoZXIKPj4gZGlzY3Vzc2lvbnMvYWxpZ25tZW50IGFy ZSByZXF1aXJlZC4KPiAKPiBTZWVtcyBPSyB0byBtZS4gIE5pc2hhbnRoPyAgQW5kcmV3Pwo+IAo+ IEJ1dCBJIHRoaW5rIHlvdSdsbCBuZWVkIHRvIGF0IGxlYXN0IHN1Ym1pdCBhIHY4IHdpdGhvdXQg dGhlIHVudXNlZAo+IGNvZGUvZGVhZCBjb2RlIHRoYXQgTGVlIHBvaW50ZWQgb3V0Lgo+IAoKSWYg eW91IG5lZWQgdGhlIHY4IGFueXdheSwgdGhlbiBhZGQgc3VwcG9ydCB0aHJvdWdoIHN5cy1vZmYg aW4KdGhhdCBzcGluLCBzaG91bGQgb25seSBiZSBhIGNvdXBsZSBsaW5lcyBvZiBjaGFuZ2UuCgpB bmRyZXcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK