From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sander Eikelenboom Subject: Re: [PATCH] x86/vMSI-X: Fix host crash when shutting down guests with MSI capable devices Date: Fri, 22 Jul 2016 10:50:17 +0200 Message-ID: <1232921799.20160722105017@eikelenboom.it> References: <1469096317-6643-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1469096317-6643-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper Cc: Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org ClRodXJzZGF5LCBKdWx5IDIxLCAyMDE2LCAxMjoxODozNyBQTSwgeW91IHdyb3RlOgoKPiBjL3Mg NzRjNmRjMmQgIng4Ni92TVNJLVg6IGRlZmVyIGludGVyY2VwdCBoYW5kbGVyIHJlZ2lzdHJhdGlv biIgY2F1c2VkIE1TSS1YCj4gdGFibGUgaW5mcmFzdHJ1Y3R1cmUgbm90IHRvIGFsd2F5cyBiZSBp bml0aWFsaXNlZCwgYnV0IGl0IG1pc3NlZCBvbmUgcGF0aAo+IHdoaWNoIG5lZWRlZCBhbiBpcy1p bml0aWFsaXNlZCBjaGVjay4KCj4gSWYgYSBkZXZpY2VzIGlzIHBhc3NlZCB0aHJvdWdoIHRvIGEg ZG9tYWluIHdoaWNoIGlzIE1TSSBjYXBhYmxlIGJ1dCBub3QgTVNJLVgKPiBjYXBhYmxlLCB0aGUg Y2FsbCB0byBtc2l4dGJsX2luaXQoKSBpcyBvbWl0dGVkLCBidXQgYSBYRU5fRE9NQ1RMX3VuYmlu ZF9wdF9pcnEKPiBoeXBlcmNhbGwgc3RpbGwgY2FsbHMgaW50byBtc2l4dGJsX3B0X3VucmVnaXN0 ZXIoKS4gIFRoaXMgZm9sbG93cyB0aGUgbGlua2VkCj4gbGlzdCBwb2ludGVyIHdoaWNoIGlzIHN0 aWxsIE5VTEwuCgo+IEludHJvZHVjZSBhbiBpcy1pbml0YWxpc2VkIGNoZWNrIHRvIG1zaXh0Ymxf cHRfdW5yZWdpc3RlcigpLgoKPiBGdXJ0aGVybW9yZSwgdGhlIHB1cnBvc2Ugb2YgdGhlIG9wZW4t Y29kZWQgbXNpeHRibF9saXN0Lm5leHQgY2hlY2sgaXMgcmF0aGVyCj4gc3VidGxlLiAgSW50cm9k dWNlIGFuIG1zaXh0YmxfaW5pdGlhbGlzZWQoKSBwcmVkaWNhdGUgaW5zdGVhZCwgd2hpY2ggbWFr ZXMgaXRzCj4gcHVycG9zZSBmYXIgbW9yZSBvYnZpb3VzLgoKPiBSZXBvcnRlZC1ieTogU2FuZGVy IEVpa2VsZW5ib29tIDxsaW51eEBlaWtlbGVuYm9vbS5pdD4KPiBTaWduZWQtb2ZmLWJ5OiBBbmRy ZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgo+IC0tLQo+IENDOiBKYW4gQmV1 bGljaCA8SkJldWxpY2hAc3VzZS5jb20+Cj4gQ0M6IFNhbmRlciBFaWtlbGVuYm9vbSA8bGludXhA ZWlrZWxlbmJvb20uaXQ+Cgo+IFNhbmRlciAtIHdvdWxkIHlvdSBtaW5kIGRvdWJsZSBjaGVja2lu ZyB0aGlzIHBhdGNoPwo+IC0tLQoKSGkgQW5kcmV3LAoKSnVzdCBnb3QgdGhlIGNoYW5jZSB0byB0 ZXN0IGFuZCBpdCB3b3JrcyBmb3IgbWUgIQoKVGhhbmtzLAoKU2FuZGVyCgoKPiAgeGVuL2FyY2gv eDg2L2h2bS92bXNpLmMgfCAxNiArKysrKysrKysrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAx MyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv eDg2L2h2bS92bXNpLmMgYi94ZW4vYXJjaC94ODYvaHZtL3Ztc2kuYwo+IGluZGV4IGU0MThiOTgu LmVmMWRmZmYgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS92bXNpLmMKPiArKysgYi94 ZW4vYXJjaC94ODYvaHZtL3Ztc2kuYwo+IEBAIC0xNjYsNiArMTY2LDE2IEBAIHN0cnVjdCBtc2l4 dGJsX2VudHJ5Cj4gIAo+ICBzdGF0aWMgREVGSU5FX1JDVV9SRUFEX0xPQ0sobXNpeHRibF9yY3Vf bG9jayk7Cj4gIAo+ICsvKgo+ICsgKiBNU0ktWCB0YWJsZSBpbmZyYXN0cnVjdHVyZSBpcyBkeW5h bWljYWxseSBpbml0aWFsaXNlZCB3aGVuIGFuIE1TSS1YIGNhcGFibGUKPiArICogZGV2aWNlIGlz IHBhc3NlZCB0aHJvdWdoIHRvIGEgZG9tYWluLCByYXRoZXIgdGhhbiB1bmNvbmRpdGlvbmFsbHkg Zm9yIGFsbAo+ICsgKiBkb21haW5zLgo+ICsgKi8KPiArc3RhdGljIGJvb2wgbXNpeHRibF9pbml0 aWFsaXNlZChjb25zdCBzdHJ1Y3QgZG9tYWluICpkKQo+ICt7CisgICAgcmV0dXJuICEhZC0+PmFy Y2guaHZtX2RvbWFpbi5tc2l4dGJsX2xpc3QubmV4dDsKPiArfQo+ICsKPiAgc3RhdGljIHN0cnVj dCBtc2l4dGJsX2VudHJ5ICptc2l4dGJsX2ZpbmRfZW50cnkoCj4gICAgICBzdHJ1Y3QgdmNwdSAq diwgdW5zaWduZWQgbG9uZyBhZGRyKQo+ICB7Cj4gQEAgLTUxOSw3ICs1MjksNyBAQCB2b2lkIG1z aXh0YmxfcHRfdW5yZWdpc3RlcihzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGlycSAqcGlycSkK PiAgICAgIEFTU0VSVChwY2lkZXZzX2xvY2tlZCgpKTsKPiAgICAgIEFTU0VSVChzcGluX2lzX2xv Y2tlZCgmZC0+ZXZlbnRfbG9jaykpOwo+ICAKPiAtICAgIGlmICggIWhhc192bGFwaWMoZCkgKQo+ ICsgICAgaWYgKCAhbXNpeHRibF9pbml0aWFsaXNlZChkKSApCj4gICAgICAgICAgcmV0dXJuOwo+ ICAKPiAgICAgIGlycV9kZXNjID0gcGlycV9zcGluX2xvY2tfaXJxX2Rlc2MocGlycSwgTlVMTCk7 Cj4gQEAgLTU1Miw3ICs1NjIsNyBAQCB2b2lkIG1zaXh0YmxfaW5pdChzdHJ1Y3QgZG9tYWluICpk KQo+ICAgICAgc3RydWN0IGh2bV9pb19oYW5kbGVyICpoYW5kbGVyOwo+ICAKPiAgICAgIGlmICgg IWhhc19odm1fY29udGFpbmVyX2RvbWFpbihkKSB8fCAhaGFzX3ZsYXBpYyhkKSB8fAotICAgICAg ICAgZC0+PmFyY2guaHZtX2RvbWFpbi5tc2l4dGJsX2xpc3QubmV4dCApCj4gKyAgICAgICAgIG1z aXh0YmxfaW5pdGlhbGlzZWQoZCkgKQo+ICAgICAgICAgIHJldHVybjsKPiAgCj4gICAgICBJTklU X0xJU1RfSEVBRCgmZC0+YXJjaC5odm1fZG9tYWluLm1zaXh0YmxfbGlzdCk7Cj4gQEAgLTU2OSw3 ICs1NzksNyBAQCB2b2lkIG1zaXh0YmxfcHRfY2xlYW51cChzdHJ1Y3QgZG9tYWluICpkKQo+ICB7 Cj4gICAgICBzdHJ1Y3QgbXNpeHRibF9lbnRyeSAqZW50cnksICp0ZW1wOwo+ICAKLSAgICBpZiAo ICFkLT4+YXJjaC5odm1fZG9tYWluLm1zaXh0YmxfbGlzdC5uZXh0ICkKPiArICAgIGlmICggIW1z aXh0YmxfaW5pdGlhbGlzZWQoZCkgKQo+ICAgICAgICAgIHJldHVybjsKPiAgCj4gICAgICBzcGlu X2xvY2soJmQtPmV2ZW50X2xvY2spOwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhl bi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=