From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760641AbZBLV3t (ORCPT ); Thu, 12 Feb 2009 16:29:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751238AbZBLV3l (ORCPT ); Thu, 12 Feb 2009 16:29:41 -0500 Received: from gate.crashing.org ([63.228.1.57]:40582 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750906AbZBLV3k (ORCPT ); Thu, 12 Feb 2009 16:29:40 -0500 Subject: Re: [PATCH 1/5]: drm: ati_pcigart: Do not access I/O MEM space using pointer derefs. From: Benjamin Herrenschmidt To: David Miller Cc: airlied@linux.ie, dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org In-Reply-To: <1234473963.29851.65.camel@pasglop> References: <20090212.021527.12463602.davem@davemloft.net> <1234434959.29851.55.camel@pasglop> <20090212.030926.74125778.davem@davemloft.net> <1234473963.29851.65.camel@pasglop> Content-Type: text/plain Date: Fri, 13 Feb 2009 08:29:27 +1100 Message-Id: <1234474167.29851.66.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-02-13 at 08:26 +1100, Benjamin Herrenschmidt wrote: > > 1) The kernel radeon framebuffer driver doesn't mess with > > the framebuffer endianness setting. > > > > 2) On >= R300 (which my chip is), Xorg leaves it alone too. > > They leave alone the swapper of the engine, not the fb one > (SURFACE_CNTL) afaik. Though actually if you stick to 8bpp, the default, the swapper will be off in radeonfb. > I dbl checked the other day and it seems that we setup the GART before > we whack it tho but it might be an issue in conjunction with radeonfb > (ie, I don't have radeonfb on my test embedded boards as I rely on X to > POST the cards using ATOMBIOS). > > Cheers, > Ben. >