From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755385AbZBZU77 (ORCPT ); Thu, 26 Feb 2009 15:59:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755078AbZBZU7u (ORCPT ); Thu, 26 Feb 2009 15:59:50 -0500 Received: from gate.crashing.org ([63.228.1.57]:39250 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753816AbZBZU7t (ORCPT ); Thu, 26 Feb 2009 15:59:49 -0500 Subject: Re: [RFC][PATCH 2/2] PM: Rework handling of interrupts during suspend-resume From: Benjamin Herrenschmidt To: Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= Cc: "Rafael J. Wysocki" , Ingo Molnar , Linus Torvalds , "Eric W. Biederman" , LKML , Jeremy Fitzhardinge , pm list , Len Brown , Jesse Barnes , Thomas Gleixner In-Reply-To: References: <200902221837.49396.rjw@sisk.pl> <200902250029.16107.rjw@sisk.pl> <200902261050.50531.rjw@sisk.pl> Content-Type: text/plain; charset="UTF-8" Date: Fri, 27 Feb 2009 07:57:29 +1100 Message-Id: <1235681849.7388.22.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2009-02-26 at 12:34 -0800, Arve Hjønnevåg wrote: > That is enough for drivers that use wakelocks to abort suspend (if I > fix the wakelock code to not use a platform device as its last abort > point). It is not enough if you don't have wakelocks, since the > interrupt can occur after suspend_late has been called and the driver > has no way to abort suspend. > I still don't quite see how you deal with the race anyway. Ie. Even without Rafael patch, what if the interrupt occurs after your sysdev suspend ? In general, unless they are level sensitive, wakeup interrupts tend to always be somewhat racy. Cheers, Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [RFC][PATCH 2/2] PM: Rework handling of interrupts during suspend-resume Date: Fri, 27 Feb 2009 07:57:29 +1100 Message-ID: <1235681849.7388.22.camel@pasglop> References: <200902221837.49396.rjw@sisk.pl> <200902250029.16107.rjw@sisk.pl> <200902261050.50531.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= Cc: Jeremy Fitzhardinge , LKML , Jesse Barnes , Thomas Gleixner , "Eric W. Biederman" , Ingo Molnar , Linus Torvalds , pm list List-Id: linux-pm@vger.kernel.org T24gVGh1LCAyMDA5LTAyLTI2IGF0IDEyOjM0IC0wODAwLCBBcnZlIEhqw7hubmV2w6VnIHdyb3Rl Ogo+IFRoYXQgaXMgZW5vdWdoIGZvciBkcml2ZXJzIHRoYXQgdXNlIHdha2Vsb2NrcyB0byBhYm9y dCBzdXNwZW5kIChpZiBJCj4gZml4IHRoZSB3YWtlbG9jayBjb2RlIHRvIG5vdCB1c2UgYSBwbGF0 Zm9ybSBkZXZpY2UgYXMgaXRzIGxhc3QgYWJvcnQKPiBwb2ludCkuIEl0IGlzIG5vdCBlbm91Z2gg aWYgeW91IGRvbid0IGhhdmUgd2FrZWxvY2tzLCBzaW5jZSB0aGUKPiBpbnRlcnJ1cHQgY2FuIG9j Y3VyIGFmdGVyIHN1c3BlbmRfbGF0ZSBoYXMgYmVlbiBjYWxsZWQgYW5kIHRoZSBkcml2ZXIKPiBo YXMgbm8gd2F5IHRvIGFib3J0IHN1c3BlbmQuCj4gCkkgc3RpbGwgZG9uJ3QgcXVpdGUgc2VlIGhv dyB5b3UgZGVhbCB3aXRoIHRoZSByYWNlIGFueXdheS4gSWUuIEV2ZW4Kd2l0aG91dCBSYWZhZWwg cGF0Y2gsIHdoYXQgaWYgdGhlIGludGVycnVwdCBvY2N1cnMgYWZ0ZXIgeW91ciBzeXNkZXYKc3Vz cGVuZCA/CgpJbiBnZW5lcmFsLCB1bmxlc3MgdGhleSBhcmUgbGV2ZWwgc2Vuc2l0aXZlLCB3YWtl dXAgaW50ZXJydXB0cyB0ZW5kIHRvCmFsd2F5cyBiZSBzb21ld2hhdCByYWN5LgoKQ2hlZXJzLApC ZW4uCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtcG0gbWFpbGluZyBsaXN0CmxpbnV4LXBtQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0 dHBzOi8vbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1w bQ==