* [PATCH]: dm-snap-fix-status-output.patch
@ 2009-03-04 21:30 Jonathan Brassow
2009-03-19 20:00 ` Alasdair G Kergon
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Brassow @ 2009-03-04 21:30 UTC (permalink / raw)
To: dm-devel
This patch goes over the first round of exception store API patches.
Prerequisites are:
1) dm-exception-store-introduce-registry.patch
2) dm-exception-store-move-dm_target-pointer.patch
3) dm-exception-store-move-chunk_fields.patch
4) dm-exception-store-move-cow-pointer.patch
5) dm-snapshot-remove-dm_snap-header-use.patch
6) dm-snapshot-remove-dm_snap-header.patch
7) dm-snapshot-use-DMEMIT-macro-for-status.patch
8) dm-snapshot-move-ctr-parsing-to-exception-store.patch
9) dm-snapshot-move-status-to-exception-store.patch
10) dm-exception-store-generalize-table-args.patch
11) dm-snapshot-new-ctr-table-format.patch
12) dm-snapshot-cleanup.patch
13) dm-snap-minor-fix.patch
brassow
Failure to take into account what has already been put into
the status buffer via 'DMEMIT' will result in the exception
store status printing over what snapshot_status put into
the buffer.
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Index: linux-2.6/drivers/md/dm-snap.c
===================================================================
--- linux-2.6.orig/drivers/md/dm-snap.c
+++ linux-2.6/drivers/md/dm-snap.c
@@ -1193,7 +1193,7 @@ static void snapshot_resume(struct dm_ta
static int snapshot_status(struct dm_target *ti, status_type_t type,
char *result, unsigned int maxlen)
{
- int sz = 0;
+ unsigned int sz = 0;
struct dm_snapshot *snap = ti->private;
switch (type) {
@@ -1221,8 +1221,9 @@ static int snapshot_status(struct dm_tar
* to make private copies if the output is to
* make sense.
*/
- DMEMIT("%s", snap->origin->name);
- snap->store->type->status(snap->store, type, result, maxlen);
+ DMEMIT("%s ", snap->origin->name);
+ snap->store->type->status(snap->store, type,
+ result+sz, maxlen-sz);
break;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH]: dm-snap-fix-status-output.patch
2009-03-04 21:30 [PATCH]: dm-snap-fix-status-output.patch Jonathan Brassow
@ 2009-03-19 20:00 ` Alasdair G Kergon
0 siblings, 0 replies; 2+ messages in thread
From: Alasdair G Kergon @ 2009-03-19 20:00 UTC (permalink / raw)
To: device-mapper development
Folded into dm-snapshot-move-status-to-exception-store.patch
Alasdair
--
agk@redhat.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-19 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-04 21:30 [PATCH]: dm-snap-fix-status-output.patch Jonathan Brassow
2009-03-19 20:00 ` Alasdair G Kergon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.