From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Tyser Date: Wed, 04 Mar 2009 17:58:42 -0600 Subject: [U-Boot] [PATCH 03/15] tools/Makefile: Build bmp_logo only when LCD or VIDEO logos are enabled In-Reply-To: <200903041848.33583.vapier@gentoo.org> References: <2e1eea15f282ac75853cd510fa4301e3f0763e75.1236207433.git.ptyser@xes-inc.com> <22a383f60a66b6c9baa54dcc1766b3ebde62c873.1236207433.git.ptyser@xes-inc.com> <200903041848.33583.vapier@gentoo.org> Message-ID: <1236211122.27449.8.camel@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2009-03-04 at 18:48 -0500, Mike Frysinger wrote: > On Wednesday 04 March 2009 18:32:53 Peter Tyser wrote: > > Signed-off-by: Peter Tyser > > --- > > tools/Makefile | 107 > > +++++++++++++++++++++++++++++--------------------------- 1 files changed, > > 55 insertions(+), 52 deletions(-) > > > > diff --git a/tools/Makefile b/tools/Makefile > > index 991ad8b..09512ec 100644 > > --- a/tools/Makefile > > +++ b/tools/Makefile > > @@ -21,57 +21,6 @@ > > # MA 02111-1307 USA > > # > > > > -# Generated executable files > > -BIN_FILES-y += img2srec$(SFX) > > -BIN_FILES-y += mkimage$(SFX) > > -BIN_FILES-y += envcrc$(SFX) > > -BIN_FILES-y += ubsha1$(SFX) > > -BIN_FILES-y += gen_eth_addr$(SFX) > > -BIN_FILES-y += bmp_logo$(SFX) > > this patch seems to move a large chunk of code around in the file for no real > discernible reason ... maybe some unrelated changes got squashed here ? I moved a chunk of code below the "include $(TOPDIR)/config.mk". The config.mk includes the include/autoconf.mk file which is needed for conditional compilation. I assumed it was necessary to include config.mk before referencing CONFIG_XXX values in the Makefile, so the change was intentional. Maybe there's some "make magic" such that the the order of the inclusion of config.mk doesn't matter, but I thought this was more logical even if it wasn't absolutely necessary. Best, Peter