From: Lin Ming <ming.m.lin@intel.com>
To: Eric Paris <eparis@redhat.com>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"Moore, Robert" <robert.moore@intel.com>,
"Brown, Len" <len.brown@intel.com>
Subject: Re: linux-next acpi changes make vmware server unusable
Date: Thu, 05 Mar 2009 08:44:31 +0800 [thread overview]
Message-ID: <1236213871.28145.1.camel@minggr.sh.intel.com> (raw)
In-Reply-To: <1236203700.3569.11.camel@localhost.localdomain>
On Thu, 2009-03-05 at 05:55 +0800, Eric Paris wrote:
> I built a linux-next kernel yesterday and discovered that the free
> vmware server 2 would start to boot the kernel and very quickly just
> power off. vmware gave some crap message about the MBR being wrong,
> which obviously wasn't the case since grub started and the kernel
> started booting. Looking at the last line on the serial console for the
> new kernel and the next line in a working kernel I knew the next output
> was supposed to be in the ACPI code. I bisected drivers/acpi and found
> that d6c349993fc7c9dabf873796c4e82bb94544b3ce is first bad commit.
Would you please try below patch?
ACPICA: Check for non-zero address before being converted to GAS
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
drivers/acpi/acpica/tbfadt.c | 16 +++++++++-------
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/acpi/acpica/tbfadt.c b/drivers/acpi/acpica/tbfadt.c
index 042d239..af8fbe1 100644
--- a/drivers/acpi/acpica/tbfadt.c
+++ b/drivers/acpi/acpica/tbfadt.c
@@ -625,12 +625,14 @@ static void acpi_tb_setup_fadt_registers(void)
ACPI_ADD_PTR(struct acpi_generic_address, &acpi_gbl_FADT,
fadt_pm_info_table[i].source);
- acpi_tb_init_generic_address(fadt_pm_info_table[i].target,
- source64->space_id,
- pm1_register_byte_width,
- source64->address +
- (fadt_pm_info_table[i].
- register_num *
- pm1_register_byte_width));
+ if (source64->address) {
+ acpi_tb_init_generic_address(fadt_pm_info_table[i].
+ target, source64->space_id,
+ pm1_register_byte_width,
+ source64->address +
+ (fadt_pm_info_table[i].
+ register_num *
+ pm1_register_byte_width));
+ }
}
}
>
> I have no idea what vmware is doing, or what we are doing, but before
> that patch I was able to boot and after it, vmware just shuts itself
> off.
>
> -Eric
>
>
next prev parent reply other threads:[~2009-03-05 0:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 21:55 linux-next acpi changes make vmware server unusable Eric Paris
2009-03-05 0:44 ` Lin Ming [this message]
2009-03-05 1:51 ` Eric Paris
2009-03-16 3:55 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236213871.28145.1.camel@minggr.sh.intel.com \
--to=ming.m.lin@intel.com \
--cc=eparis@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.