All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: drop wext channel list if too long
Date: Fri, 13 Mar 2009 13:18:50 -0400	[thread overview]
Message-ID: <1236964730.9657.10.camel@localhost.localdomain> (raw)
In-Reply-To: <20090313145445.GC5551@tuxdriver.com>

On Fri, 2009-03-13 at 10:54 -0400, John W. Linville wrote:
> On Thu, Mar 12, 2009 at 07:24:04PM +0100, Johannes Berg wrote:
> > wext limits the number of channels it can list to 32, we obey
> > that limitation but show a partial list which is confusing.
> > Thus, when going over the limit, drop the list completely to
> > make the users aware that something is wrong and hopefully
> > prompt them to use iw instead. We still let iwlist print out
> > the total number of available channels.
> > 
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> 
> Will this make wpa_supplicant or Networkmanager barf?

It doesn't look like wpa_supplicant cares about the returned channel
list from SIOCGIWRANGE.

NM, however, uses the returned channel list to figure out a free
supported adhoc frequency to use when creating an adhoc network (like
for connection sharing).  If it can't find an intersection between an
internal "safe" frequency list and what the card supports (which it
wouldn't be able to with this patch), it will simply use 2462 or 5180
MHz.

Thus, I don't think you'll *break* anything specifically, but this patch
would cause the default frequency for an IBSS created by NM  to move
from channel 1 to channel 11.

Dan



  reply	other threads:[~2009-03-13 17:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 18:24 [PATCH] cfg80211: drop wext channel list if too long Johannes Berg
2009-03-13 14:54 ` John W. Linville
2009-03-13 17:18   ` Dan Williams [this message]
2009-03-14  8:30     ` Johannes Berg
2009-03-16 16:56       ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236964730.9657.10.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.