From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 664BEC00449 for ; Wed, 3 Oct 2018 15:49:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16C302098A for ; Wed, 3 Oct 2018 15:49:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16C302098A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=tronnes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727221AbeJCWid (ORCPT ); Wed, 3 Oct 2018 18:38:33 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:49556 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbeJCWid (ORCPT ); Wed, 3 Oct 2018 18:38:33 -0400 Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:52691 helo=[192.168.10.175]) by smtp.domeneshop.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1g7jP5-0008I2-9g; Wed, 03 Oct 2018 17:49:35 +0200 Subject: Re: [PATCH] drm/imx: move 'legacyfb_depth' definition out of #ifdef To: Arnd Bergmann , Philipp Zabel , David Airlie Cc: Lucas Stach , Sam Ravnborg , Daniel Vetter , Souptick Joarder , Leonard Crestez , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20181002205836.2323084-1-arnd@arndb.de> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <123f7e1c-8f2b-5797-de16-650ec01d0b24@tronnes.org> Date: Wed, 3 Oct 2018 17:49:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181002205836.2323084-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 02.10.2018 22.58, skrev Arnd Bergmann: > The variable is now referenced unconditionally, but still > declared in an #ifdef: > > drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind': > drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'? > > Remove the #ifdef so it can always be accessed. > > Fixes: f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()") > Signed-off-by: Arnd Bergmann > --- I've already applied the previous one you sent: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=064b06bbf117f8b5e64a5143e970d5a1cf602fd6 Not sure when it reaches linux-next now that we are past rc6. Noralf. > drivers/gpu/drm/imx/imx-drm-core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c > index a70f3131a377..0e6942f21a4e 100644 > --- a/drivers/gpu/drm/imx/imx-drm-core.c > +++ b/drivers/gpu/drm/imx/imx-drm-core.c > @@ -35,10 +35,8 @@ > > #define MAX_CRTC 4 > > -#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION) > static int legacyfb_depth = 16; > module_param(legacyfb_depth, int, 0444); > -#endif > > DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops); > From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH] drm/imx: move 'legacyfb_depth' definition out of #ifdef Date: Wed, 3 Oct 2018 17:49:32 +0200 Message-ID: <123f7e1c-8f2b-5797-de16-650ec01d0b24@tronnes.org> References: <20181002205836.2323084-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69E9A8915B for ; Wed, 3 Oct 2018 15:49:37 +0000 (UTC) In-Reply-To: <20181002205836.2323084-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann , Philipp Zabel , David Airlie Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Souptick Joarder , Thomas Zimmermann , Leonard Crestez , Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org CgpEZW4gMDIuMTAuMjAxOCAyMi41OCwgc2tyZXYgQXJuZCBCZXJnbWFubjoKPiBUaGUgdmFyaWFi bGUgaXMgbm93IHJlZmVyZW5jZWQgdW5jb25kaXRpb25hbGx5LCBidXQgc3RpbGwKPiBkZWNsYXJl ZCBpbiBhbiAjaWZkZWY6Cj4KPiBkcml2ZXJzL2dwdS9kcm0vaW14L2lteC1kcm0tY29yZS5jOiBJ biBmdW5jdGlvbiAnaW14X2RybV9iaW5kJzoKPiBkcml2ZXJzL2dwdS9kcm0vaW14L2lteC1kcm0t Y29yZS5jOjI2NDo2OiBlcnJvcjogJ2xlZ2FjeWZiX2RlcHRoJyB1bmRlY2xhcmVkIChmaXJzdCB1 c2UgaW4gdGhpcyBmdW5jdGlvbik7IGRpZCB5b3UgbWVhbiAnbG9ja2RlcF9kZXB0aCc/Cj4KPiBS ZW1vdmUgdGhlICNpZmRlZiBzbyBpdCBjYW4gYWx3YXlzIGJlIGFjY2Vzc2VkLgo+Cj4gRml4ZXM6 IGY1MzcwNWZkOTgwMyAoImRybS9pbXg6IFVzZSBkcm1fZmJkZXZfZ2VuZXJpY19zZXR1cCgpIikK PiBTaWduZWQtb2ZmLWJ5OiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPgo+IC0tLQoKSSd2 ZSBhbHJlYWR5IGFwcGxpZWQgdGhlIHByZXZpb3VzIG9uZSB5b3Ugc2VudDoKaHR0cHM6Ly9jZ2l0 LmZyZWVkZXNrdG9wLm9yZy9kcm0vZHJtLW1pc2MvY29tbWl0Lz9pZD0wNjRiMDZiYmYxMTdmOGI1 ZTY0YTUxNDNlOTcwZDVhMWNmNjAyZmQ2CgpOb3Qgc3VyZSB3aGVuIGl0IHJlYWNoZXMgbGludXgt bmV4dCBub3cgdGhhdCB3ZSBhcmUgcGFzdCByYzYuCgpOb3JhbGYuCgo+ICAgZHJpdmVycy9ncHUv ZHJtL2lteC9pbXgtZHJtLWNvcmUuYyB8IDIgLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pbXgvaW14LWRybS1jb3Jl LmMgYi9kcml2ZXJzL2dwdS9kcm0vaW14L2lteC1kcm0tY29yZS5jCj4gaW5kZXggYTcwZjMxMzFh Mzc3Li4wZTY5NDJmMjFhNGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2lteC9pbXgt ZHJtLWNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pbXgvaW14LWRybS1jb3JlLmMKPiBA QCAtMzUsMTAgKzM1LDggQEAKPiAgIAo+ICAgI2RlZmluZSBNQVhfQ1JUQwk0Cj4gICAKPiAtI2lm IElTX0VOQUJMRUQoQ09ORklHX0RSTV9GQkRFVl9FTVVMQVRJT04pCj4gICBzdGF0aWMgaW50IGxl Z2FjeWZiX2RlcHRoID0gMTY7Cj4gICBtb2R1bGVfcGFyYW0obGVnYWN5ZmJfZGVwdGgsIGludCwg MDQ0NCk7Cj4gLSNlbmRpZgo+ICAgCj4gICBERUZJTkVfRFJNX0dFTV9DTUFfRk9QUyhpbXhfZHJt X2RyaXZlcl9mb3BzKTsKPiAgIAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg==