From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH 2/2] ARM: dts: bcm283x: Add critical thermal zone for GPU Date: Thu, 9 Feb 2017 18:48:52 +0100 (CET) Message-ID: <124007607.358509.1486662532562@email.1und1.de> References: <1486217787-15703-1-git-send-email-stefan.wahren@i2se.com> <1486217787-15703-2-git-send-email-stefan.wahren@i2se.com> <20170208041929.GA6809@localhost.localdomain> <20170208042351.GB6809@localhost.localdomain> <93f3ecbc-6d28-3e04-d6f3-4c03f8ac7ab3@i2se.com> <87lgtgea1q.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87lgtgea1q.fsf@eliezer.anholt.net> Sender: linux-pm-owner@vger.kernel.org To: Eric Anholt , Eduardo Valentin Cc: Frank Rowand , kernel@martin.sperl.org, Zhang Rui , Rob Herring , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Eric, > Eric Anholt hat am 8. Februar 2017 um 20:50 geschrieben: > > > Stefan Wahren writes: > > > Am 08.02.2017 um 05:23 schrieb Eduardo Valentin: > >> On Tue, Feb 07, 2017 at 08:19:31PM -0800, Eduardo Valentin wrote: > >>> On Sat, Feb 04, 2017 at 02:16:27PM +0000, Stefan Wahren wrote: > >>>> As suggested by Eduardo Valentin this adds the thermal zone for > >>>> the bcm2835 SoC. Since we currently don't have any cooling devices > >>>> leave this section empty. > >>>> > >>>> Signed-off-by: Stefan Wahren > >>>> --- > >>>> arch/arm/boot/dts/bcm283x.dtsi | 19 +++++++++++++++++++ > >>>> 1 file changed, 19 insertions(+) > >>>> > >>>> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi > >>>> index 9c7ec7e..359da9d 100644 > >>>> --- a/arch/arm/boot/dts/bcm283x.dtsi > >>>> +++ b/arch/arm/boot/dts/bcm283x.dtsi > >>>> @@ -19,6 +19,25 @@ > >>>> bootargs = "earlyprintk console=ttyAMA0"; > >>>> }; > >>>> > >>>> + thermal-zones { > >>>> + gpu_thermal: gpu-thermal { > >>>> + polling-delay-passive = <0>; > >>>> + polling-delay = <1000>; > >>>> + > >>>> + thermal-sensors = <&thermal>; > >> Just came to my mind, dont you need to have an id to specify with sensor > >> points to gpu? > > > > Sorry, i don't know the exact setup of the single thermal sensor on the > > SoC (datasheet doesn't provide any helpful information). I adapted the > > Renesas R-Car thermal binding because i think it would be the best match. > > > > @Eric: What's your opinion? > > I don't understand the question. i hope to get it right. We are talking about defining the thermal zone [1]. There are 4 examples: (a) - CPU thermal zone with one internal sensor (b) - IC with several internal sensors (c) - Several sensors within one single thermal zone (d) - Board thermal I decided to choose (a) for the patch and Eduardo tends to (b). Here are the questions: Where is the thermal sensor TSENS located (ARM core or VideoCore 4)? Do we expect several internal sensors? [1] - http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/thermal/thermal.txt