From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LzItb-0007eY-Ms
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 19:08:55 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LzItb-0007eA-1J
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 19:08:55 -0400
Received: from [199.232.76.173] (port=55573 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LzIta-0007e7-UL
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 19:08:54 -0400
Received: from mail.corp.accelance.fr ([213.162.48.15]:59779)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <lionel.landwerlin@openwide.fr>) id 1LzIta-00067k-Hf
	for qemu-devel@nongnu.org; Wed, 29 Apr 2009 19:08:54 -0400
Subject: Re: [Qemu-devel] [PATCH] linux-user: Added
	IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt
From: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
In-Reply-To: <20090429203552.GB20993@shareable.org>
References: <1240695019.21332.1.camel@coalu.atr>
	<20090427172134.GA23911@codesourcery.com>
	<1240855506.29022.1.camel@coalu.atr> <20090429180048.GA19011@kos.to>
	<20090429203552.GB20993@shareable.org>
Content-Type: text/plain; charset="UTF-8"
Date: Thu, 30 Apr 2009 01:08:50 +0200
Message-Id: <1241046530.19973.2.camel@coalu.atr>
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Nathan Froyd <froydnj@codesourcery.com>

Le mercredi 29 avril 2009 =C3=A0 21:35 +0100, Jamie Lokier a =C3=A9crit :
> Riku Voipio wrote:
> > On Mon, Apr 27, 2009 at 08:05:06PM +0200, Lionel Landwerlin wrote:
> > > Le lundi 27 avril 2009 =C3=A0 10:21 -0700, Nathan Froyd a =C3=A9cri=
t :
> > > > On Sat, Apr 25, 2009 at 11:30:19PM +0200, Lionel Landwerlin wrote=
:
> > > > > linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to=
 setsockopt
> >=20
> > > > Should these be TARGET_IP_* instead, or are they like the FUTEX_*
> > > > constants and the same on every platform?  If the latter, at the =
very
> > > > least there should be explanatory comments somewhere--just making=
 them
> > > > TARGET_IP_* would be even better, IMHO.
> >=20
> > > I'm agree too, I just did the way it was before...
> >=20
> > These are defined in include/linux/in.h so they should be same on all=
 archs?
>=20
> But what if you're compiling for a non-Linux host?
>=20
> IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP are standard BSD sockets options,
> found everywhere, even on Windows I think.

Ok, so I think I can keep the patch as it is now

--=20
Lionel Landwerlin <lionel.landwerlin@openwide.fr>