From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761720AbZD3A2g (ORCPT ); Wed, 29 Apr 2009 20:28:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760772AbZD3A1b (ORCPT ); Wed, 29 Apr 2009 20:27:31 -0400 Received: from ey-out-2122.google.com ([74.125.78.26]:4720 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759935AbZD3A1a (ORCPT ); Wed, 29 Apr 2009 20:27:30 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=hv6qfoe2HYAUJPk0i2YL1YLtV8bf++V+pdf3qA3lSp+Jf34nHpuARI8bFunQr/IkEH EAw40+IaoJrlpRRhNJA08dyBkkMLHsEuVImfVU2+hmue123IJ9muzILTFtj3QnptRrLM WnTSDwx421T2ZzsrkWpqz1I9Ha/TOSssRN2dM= From: Frederic Weisbecker To: Ingo Molnar Cc: LKML , Li Zefan , Zhaolei , Steven Rostedt , Tom Zanussi , Oleg Nesterov , Andrew Morton , Frederic Weisbecker Subject: [PATCH 03/19] trace_workqueue: remove cpu_workqueue_stats->first_entry Date: Thu, 30 Apr 2009 02:27:04 +0200 Message-Id: <1241051240-4280-4-git-send-email-fweisbec@gmail.com> X-Mailer: git-send-email 1.6.2.3 In-Reply-To: <1241051240-4280-1-git-send-email-fweisbec@gmail.com> References: <1241051240-4280-1-git-send-email-fweisbec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhaolei cpu_workqueue_stats->first_entry is useless because we can retrieve the header of a cpu workqueue using: if (&cpu_workqueue_stats->list == workqueue_cpu_stat(cpu)->list.next) [ Impact: cleanup ] Signed-off-by: Zhao Lei Cc: Steven Rostedt Cc: Tom Zanussi Cc: Oleg Nesterov Cc: Andrew Morton Signed-off-by: Frederic Weisbecker --- kernel/trace/trace_workqueue.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_workqueue.c b/kernel/trace/trace_workqueue.c index 128b64b..890974a 100644 --- a/kernel/trace/trace_workqueue.c +++ b/kernel/trace/trace_workqueue.c @@ -16,8 +16,6 @@ /* A cpu workqueue thread */ struct cpu_workqueue_stats { struct list_head list; -/* Useful to know if we print the cpu headers */ - bool first_entry; int cpu; pid_t pid; /* Can be inserted from interrupt or user context, need to be atomic */ @@ -103,8 +101,6 @@ static void probe_workqueue_creation(struct task_struct *wq_thread, int cpu) cws->pid = wq_thread->pid; spin_lock_irqsave(&workqueue_cpu_stat(cpu)->lock, flags); - if (list_empty(&workqueue_cpu_stat(cpu)->list)) - cws->first_entry = true; list_add_tail(&cws->list, &workqueue_cpu_stat(cpu)->list); spin_unlock_irqrestore(&workqueue_cpu_stat(cpu)->lock, flags); } -- 1.6.2.3