All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaikumar Ganesh <jaikumar@google.com>
To: linux-bluetooth@vger.kernel.org
Cc: Jaikumar Ganesh <jaikumar@google.com>
Subject: [PATCH] Emit device_found when RSSI changes.
Date: Mon,  4 May 2009 23:32:39 -0700	[thread overview]
Message-ID: <1241505159-12795-1-git-send-email-jaikumar@google.com> (raw)

When the RSSI of the remote device changes, emit
device found. Currently, we were not sending
emit_device_found signal, when the RSSI of already
found devices gets updated.

Signed-off-by: Jaikumar Ganesh <jaikumar@google.com>
---
 src/adapter.c  |   24 +++++++++---------------
 src/dbus-hci.c |   10 ++++++++--
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/src/adapter.c b/src/adapter.c
index d9914e2..1ec076d 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -2639,6 +2639,15 @@ void adapter_emit_device_found(struct btd_adapter *adapter,
 	g_free(alias);
 }
 
+void adapter_update_found_devices_for_rssi(struct btd_adapter *adapter,
+				struct remote_dev_info *dev, int8_t rssi)
+{
+	dev->rssi = rssi;
+	adapter->found_devices = g_slist_sort(adapter->found_devices,
+						(GCompareFunc) dev_rssi_cmp);
+	adapter_emit_device_found(adapter, dev);
+}
+
 void adapter_update_found_devices(struct btd_adapter *adapter, bdaddr_t *bdaddr,
 				int8_t rssi, uint32_t class, const char *name,
 				const char *alias, gboolean legacy,
@@ -2650,13 +2659,6 @@ void adapter_update_found_devices(struct btd_adapter *adapter, bdaddr_t *bdaddr,
 	bacpy(&match.bdaddr, bdaddr);
 	match.name_status = NAME_ANY;
 
-	dev = adapter_search_found_devices(adapter, &match);
-	if (dev) {
-		if (rssi == dev->rssi)
-			return;
-		goto done;
-	}
-
 	dev = g_new0(struct remote_dev_info, 1);
 
 	bacpy(&dev->bdaddr, bdaddr);
@@ -2669,14 +2671,6 @@ void adapter_update_found_devices(struct btd_adapter *adapter, bdaddr_t *bdaddr,
 	dev->name_status = name_status;
 
 	adapter->found_devices = g_slist_prepend(adapter->found_devices, dev);
-
-done:
-	dev->rssi = rssi;
-
-	adapter->found_devices = g_slist_sort(adapter->found_devices,
-						(GCompareFunc) dev_rssi_cmp);
-
-	adapter_emit_device_found(adapter, dev);
 }
 
 int adapter_remove_found_device(struct btd_adapter *adapter, bdaddr_t *bdaddr)
diff --git a/src/dbus-hci.c b/src/dbus-hci.c
index 932682a..d7df415 100644
--- a/src/dbus-hci.c
+++ b/src/dbus-hci.c
@@ -668,9 +668,15 @@ void hcid_dbus_inquiry_result(bdaddr_t *local, bdaddr_t *peer, uint32_t class,
 	memset(&match, 0, sizeof(struct remote_dev_info));
 	bacpy(&match.bdaddr, peer);
 	match.name_status = NAME_SENT;
-	/* if found: don't send the name again */
+	/* 
+	 * if found and rssi has changed, emit device_found
+	 * if found: don't send the name again.
+	 */
 	dev = adapter_search_found_devices(adapter, &match);
-	if (dev)
+	if (dev && dev->rssi != rssi) {
+		adapter_update_found_devices_for_rssi(adapter, dev, rssi);
+		return;
+	} else if (dev)
 		return;
 
 	/* the inquiry result can be triggered by NON D-Bus client */
-- 
1.5.4.3


             reply	other threads:[~2009-05-05  6:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05  6:32 Jaikumar Ganesh [this message]
2009-05-18  2:27 ` [PATCH] Emit device_found when RSSI changes Manuel Naranjo
     [not found]   ` <e8892a6a0905172014h798119c4m3b36e7e6efed8bb4@mail.gmail.com>
2009-05-18  3:30     ` Manuel Naranjo
2009-05-18 21:20       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241505159-12795-1-git-send-email-jaikumar@google.com \
    --to=jaikumar@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.