From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759940AbZEKWuv (ORCPT ); Mon, 11 May 2009 18:50:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759498AbZEKWue (ORCPT ); Mon, 11 May 2009 18:50:34 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:48473 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759927AbZEKWud (ORCPT ); Mon, 11 May 2009 18:50:33 -0400 Subject: Re: [PATCH] scsi: libsas depends on HAS_DMA From: James Bottomley To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org In-Reply-To: <200905112240.20171.arnd@arndb.de> References: <20090511222702.352192505@arndb.de> > <200905112240.20171.arnd@arndb.de> Content-Type: text/plain Date: Mon, 11 May 2009 22:50:33 +0000 Message-Id: <1242082233.27353.9.camel@mulgrave.int.hansenpartnership.com> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-05-11 at 22:40 +0000, Arnd Bergmann wrote: > libsas uses the DMA mapping API, so it cannot be > built on architectures that don't support DMA. > > Signed-off-by: Arnd Bergmann > --- > drivers/scsi/libsas/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig > index 18f33cd..59e00fa 100644 > --- a/drivers/scsi/libsas/Kconfig > +++ b/drivers/scsi/libsas/Kconfig > @@ -24,7 +24,7 @@ > > config SCSI_SAS_LIBSAS > tristate "SAS Domain Transport Attributes" > - depends on SCSI > + depends on SCSI && HAS_DMA Our unfortunate Kconfig system can cause problems if you do this: SCSI_SAS_LIBSAS is used as a select for drivers that need it, so either they'd need to select this themselves, or you need some other solution. James