All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
To: "Valentin Eduardo (Nokia-D/Helsinki)" <eduardo.valentin@nokia.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH v2 4/7] FMTx: si4713: Add files to handle si4713 i2c device
Date: Tue, 12 May 2009 08:15:50 +0300	[thread overview]
Message-ID: <1242105350.19944.56.camel@eenurkka-desktop> (raw)
In-Reply-To: <1242034309-13448-5-git-send-email-eduardo.valentin@nokia.com>

On Mon, 2009-05-11 at 11:31 +0200, Valentin Eduardo (Nokia-D/Helsinki)
wrote:
> +/*
> + * Values for region specific configurations
> + * (spacing, bottom and top frequencies, preemphasis)
> + */
> +static struct region_info region_configs[] = {
> +       /* USA */
> +       {
> +               .channel_spacing        = 20,
> +               .bottom_frequency       = 8750,
> +               .top_frequency          = 10800,
> +               .preemphasis            = 0,
> +               .region                 = 0,
> +       },
> +       /* Australia */
> +       {
> +               .channel_spacing        = 20,
> +               .bottom_frequency       = 8750,
> +               .top_frequency          = 10800,
> +               .preemphasis            = 1,
> +               .region                 = 1,
> +       },
> +       /* Europe */
> +       {
> +               .channel_spacing        = 10,
> +               .bottom_frequency       = 8750,
> +               .top_frequency          = 10800,
> +               .preemphasis            = 1,
> +               .region                 = 2,
> +       },
> +       /* Japan */
> +       {
> +               .channel_spacing        = 10,
> +               .bottom_frequency       = 7600,
> +               .top_frequency          = 9000,
> +               .preemphasis            = 1,
> +               .region                 = 3,
> +       },
> +       /* Japan wide band */
> +       {
> +               .channel_spacing        = 10,
> +               .bottom_frequency       = 7600,
> +               .top_frequency          = 10800,
> +               .preemphasis            = 1,
> +               .region                 = 4,
> +       },
> +};
> +

Hi,

I took a quick peek;

For USA, the correct range appears as:
USA: 87.9 - 107.9

Some more to add:

China: 92 - 108 Mhz
Korea: 88 - 108 Mhz
(Europe?Middle east? Israel: 87.5 - 108)

But please do double check these before changing ;)

- Eero


  parent reply	other threads:[~2009-05-12  5:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11  9:31 [PATCH v2 0/7] [RFC] FM Transmitter (si4713) and another changes Eduardo Valentin
2009-05-11  9:31 ` [PATCH v2 1/7] v4l2: video device: Add V4L2_CTRL_CLASS_FMTX controls Eduardo Valentin
2009-05-11  9:31   ` [PATCH v2 2/7] v4l2: video device: Add FMTX controls default configurations Eduardo Valentin
2009-05-11  9:31     ` [PATCH v2 3/7] v4l2_subdev i2c: Add i2c board info to v4l2_i2c_new_subdev Eduardo Valentin
2009-05-11  9:31       ` [PATCH v2 4/7] FMTx: si4713: Add files to handle si4713 i2c device Eduardo Valentin
2009-05-11  9:31         ` [PATCH v2 5/7] FMTx: si4713: Add files to add radio interface for si4713 Eduardo Valentin
2009-05-11  9:31           ` [PATCH v2 6/7] FMTx: si4713: Add Kconfig and Makefile entries Eduardo Valentin
2009-05-11  9:31             ` [PATCH v2 7/7] FMTx: si4713: Add document file Eduardo Valentin
2009-05-12  5:15         ` Eero Nurkkala [this message]
2009-05-12  5:22           ` [PATCH v2 4/7] FMTx: si4713: Add files to handle si4713 i2c device Eero Nurkkala
2009-05-12  6:08             ` Eero Nurkkala
2009-05-12  2:12   ` [PATCH v2 1/7] v4l2: video device: Add V4L2_CTRL_CLASS_FMTX controls Mauro Carvalho Chehab
2009-05-12  6:12     ` Eduardo Valentin
2009-05-12  2:17   ` Mauro Carvalho Chehab
2009-05-12  6:10     ` Eduardo Valentin
2009-05-12  6:26       ` Hans Verkuil
2009-05-12 10:29         ` Mauro Carvalho Chehab
2009-05-13  5:55           ` Eduardo Valentin
2009-05-12  9:53       ` Mauro Carvalho Chehab
2009-05-12  4:49   ` Eero Nurkkala
2009-05-12  6:05     ` Eduardo Valentin
2009-05-12  7:03 ` [PATCH v2 0/7] [RFC] FM Transmitter (si4713) and another changes Hans Verkuil
2009-05-12  7:33   ` Eduardo Valentin
2009-05-12  7:35     ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242105350.19944.56.camel@eenurkka-desktop \
    --to=ext-eero.nurkkala@nokia.com \
    --cc=eduardo.valentin@nokia.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.