Re: [RFT 3/4] cfg80211: add rfkill support

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

On Sun, 2009-05-24 at 09:32 -0400, Dan Williams wrote:
> On Thu, 2009-05-21 at 23:59 +0200, Johannes Berg wrote:
> > plain text document attachment (015-cfg80211-rfkill.patch)
> > To be easier on drivers and users, have cfg80211 register an
> > rfkill structure that drivers can access. When soft-killed,
> > simply take down all interfaces; when hard-killed the driver
> > needs to notify us and we will take down the interfaces
> > after the fact. While rfkilled, interfaces cannot be set UP.
> 
> Any chance we could get something other than EINVAL returned from the
> PRE_UP notifier when the device is rfkilled?  It's useful to get some
> indication of *why* the device can't be brought up.  For example, if the
> device requires firmware but that firmware isn't present, the driver
> will usually return ENOENT because that's what request_firmware()
> returns when it can't find what it needs.  Thus userspace can do
> something intelligent with the error.
> 
> So maybe EL2HLT could be (ab)used here?  I guess technically it's an L1
> halt since the PHY is powered down, but whatever.  The only other stuff
> that seems to use this are the USB 'gadget' drivers.  Either that, or
> lets make an EL1OFF or ERFKILL maybe.

Sure, we can do whatever we want, I just quickly put EINVAL in.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]