From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH 1/1] ethtool: Expose MDI-X status Date: Tue, 26 May 2009 17:02:48 +0100 Message-ID: <1243353768.3188.2.camel@achroite> References: <1243004704.3192.21.camel@achroite> <20090522171850.GA16751@clala-laptop> <1243040677.16597.52.camel@deadeye> <4A1C0C1C.8040401@riverbed.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "jgarzik@pobox.com" , "netdev@vger.kernel.org" To: Chaitanya Lala Return-path: Received: from smarthost03.mail.zen.net.uk ([212.23.3.142]:39695 "EHLO smarthost03.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044AbZEZQCw (ORCPT ); Tue, 26 May 2009 12:02:52 -0400 In-Reply-To: <4A1C0C1C.8040401@riverbed.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2009-05-26 at 08:34 -0700, Chaitanya Lala wrote: > Ben Hutchings wrote: > > On Fri, 2009-05-22 at 10:18 -0700, Chaitanya Lala wrote: > > > >> The MDI-X status is a useful tool for diagnosing network > >> connectivity issues. We expose MDI-X status as a tri-state value > >> status which drivers can optionally implement. > >> > >> Signed-off-by: Chaitanya Lala > >> Signed-off-by: Arthur Jones > >> --- > >> ethtool-copy.h | 6 ++++++ > >> ethtool.c | 13 +++++++++++++ > >> 2 files changed, 19 insertions(+), 0 deletions(-) > >> > >> diff --git a/ethtool-copy.h b/ethtool-copy.h > >> index 3ca4e2c..d3e1524 100644 > >> --- a/ethtool-copy.h > >> +++ b/ethtool-copy.h > >> @@ -28,6 +28,7 @@ struct ethtool_cmd { > >> __u16 speed_hi; > >> __u16 reserved2; > >> __u32 reserved[3]; > >> + __u8 is_mdix; /* Tri-state value to expose MDI-X */ > >> }; > >> > > [...] > > > > No, you cannot change the size of this structure either. > > > Hi, > > In that case please suggest a way to do this. There are 14 bytes at the end of the structure reserved for future expansion. You could take one of them. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.