From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: Wrong looking statement in cpm_common.c
Date: Wed, 27 May 2009 08:22:17 +1000 [thread overview]
Message-ID: <1243376537.17847.11.camel@pasglop> (raw)
In-Reply-To: <4A1C69F8.9090301@freescale.com>
On Tue, 2009-05-26 at 17:15 -0500, Scott Wood wrote:
> Benjamin Herrenschmidt wrote:
> > On Tue, 2009-05-26 at 12:56 -0500, Scott Wood wrote:
> >> Any suggestions for how to do it properly?
> >
> > ioremap ? :-)
>
> Does ioremap work that early?
It works very early on ppc32 but maybe not -that- early... It works from
start_kernel on. You might be able to do the ioremaps in machine_init
(provided LMBs are up) but they won't be "effective" until MMU_init
returns, but then, neither will setbat anyway.
However, since that's the only user of setbat I can still find and we
want to replace that with something saner, I'd rather kill it.
Ben.
next prev parent reply other threads:[~2009-05-26 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 4:00 Wrong looking statement in cpm_common.c Benjamin Herrenschmidt
2009-05-26 17:56 ` Scott Wood
2009-05-26 22:07 ` Benjamin Herrenschmidt
2009-05-26 22:15 ` Scott Wood
2009-05-26 22:22 ` Benjamin Herrenschmidt [this message]
2009-05-26 22:38 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243376537.17847.11.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.