Hi Gerd,

Thanks for reviewing!

On Montag, 13. Januar 2020 10:56:36 CET Gerd Hoffmann wrote:

> Hi,

>

> > This also means that we cannot have unspec for planes layout. Device

> > either

> > expects planes in separate buffers or in one buffer with some offsets,

> > there cannot be mixed cases.

>

> Hmm. Is it useful to support both? Or maybe support the "one buffer +

> offsets" case only? Splitting one buffer into multiple smaller ones

> internally if needed shouldn't be a problem, and it would simplify the

> interface a bit ...

>

Ok, let's consider the following case:

- the device expects planes in separate buffers.

- say, Android on the guest side also imports planes in separate buffers into the driver.

- but he driver only supports one buffer + offsets.

Do you mean the driver then can join the underlying page lists and set offsets then? Yes, this would probably make sense.

Regards,

Dmitry.

> cheers,

> Gerd