From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-6649-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 4FFA7985CD4 for ; Mon, 13 Jan 2020 10:41:51 +0000 (UTC) From: Dmitry Sepp Date: Mon, 13 Jan 2020 11:41:45 +0100 Message-ID: <12433898.dW097sEU6C@os-lin-dmo> In-Reply-To: <20200113095636.blov62o4gbf27om5@sirius.home.kraxel.org> References: <20191218130214.170703-1-keiichiw@chromium.org> <7740094.NyiUUSuA9g@os-lin-dmo> <20200113095636.blov62o4gbf27om5@sirius.home.kraxel.org> MIME-Version: 1.0 Subject: Re: [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification Content-Type: multipart/alternative; boundary="nextPart22239718.ouqheUzb2q" To: Gerd Hoffmann , spice-devel@lists.freedesktop.org Cc: Keiichi Watanabe , virtio-dev@lists.oasis-open.org, Tomasz Figa , Linux Media Mailing List , Alexandre Courbot , Alex Lau , Daniel Vetter , Dylan Reid , Enrico Granata , Frediano Ziglio , Hans Verkuil , =?ISO-8859-1?Q?St=E9phane?= Marchesin , Pawel Osciak , David Stevens , uril@redhat.com List-ID: --nextPart22239718.ouqheUzb2q Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset=WINDOWS-1252 Hi Gerd, Thanks for reviewing! On Montag, 13. Januar 2020 10:56:36 CET Gerd Hoffmann wrote: > Hi, > > > This also means that we cannot have unspec for planes layout. Device > > either > > expects planes in separate buffers or in one buffer with some offsets, > > there cannot be mixed cases. > > Hmm. Is it useful to support both? Or maybe support the "one buffer + > offsets" case only? Splitting one buffer into multiple smaller ones > internally if needed shouldn't be a problem, and it would simplify the > interface a bit ... > Ok, let's consider the following case: - the device expects planes in separate buffers. - say, Android on the guest side also imports planes in separate buffers into the driver. - but he driver only supports one buffer + offsets. Do you mean the driver then can join the underlying page lists and set offsets then? Yes, this would probably make sense. Regards, Dmitry. > cheers, > Gerd --nextPart22239718.ouqheUzb2q Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset=WINDOWS-1252

Hi Gerd,

 

Thanks for reviewing!

 

On Montag, 13. Januar 2020 10:56:36 CET Gerd Hoffmann wrote:

> Hi,

>

> > This also means that we cannot have unspec for planes layout. Device

> > either

> > expects planes in separate buffers or in one buffer with some offsets,

> > there cannot be mixed cases.

>

> Hmm. Is it useful to support both? Or maybe support the "one buffer +

> offsets" case only? Splitting one buffer into multiple smaller ones

> internally if needed shouldn't be a problem, and it would simplify the

> interface a bit ...

>

 

Ok, let's consider the following case:

- the device expects planes in separate buffers.

- say, Android on the guest side also imports planes in separate buffers into the driver.

- but he driver only supports one buffer + offsets.

 

Do you mean the driver then can join the underlying page lists and set offsets then? Yes, this would probably make sense.

 

Regards,

Dmitry.

 

> cheers,

> Gerd

--nextPart22239718.ouqheUzb2q--