From: Eric Anholt <eric@anholt.net>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
"airlied@redhat.com" <airlied@redhat.com>,
"dri-devel@lists.sf.net" <dri-devel@lists.sf.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
"stable@kernel.org" <stable@kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] drm: i915: ensure objects are allocated below 4GB on PAE
Date: Wed, 27 May 2009 10:40:12 -0700 [thread overview]
Message-ID: <1243446012.8400.37.camel@gaiman.anholt.net> (raw)
In-Reply-To: <20090527004250.GA11835@sli10-desk.sh.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]
On Wed, 2009-05-27 at 08:42 +0800, Shaohua Li wrote:
> On Wed, May 27, 2009 at 08:18:40AM +0800, Kyle McMartin wrote:
> > On Tue, May 26, 2009 at 11:55:50PM +0100, Hugh Dickins wrote:
> > > I'm confused: I thought GFP_DMA32 only applies on x86_64:
> > > my 32-bit PAE machine with (slightly!) > 4GB shows no ZONE_DMA32.
> > > Does this patch perhaps depend on another, to enable DMA32 on 32-bit
> > > PAE, or am I just in a muddle?
> > >
> >
> > No, you're exactly right, I'm just a muppet and missed the obvious.
> > Looks like the "correct" fix is the fact that the allocation is thus
> > filled out with GFP_USER, therefore, from ZONE_NORMAL, and below
> > max_low_pfn.
> >
> > Looks like we'll need some additional thinking to get true ZONE_DMA32 on
> > i386... ugh, I'll look into it tonight.
> For i386, GFP_USER is enough. But 945G GART can only map to physical page < 4G,
> so for x64, we need GFP_DMA32. This is the reason I add extra GFP_DMA32.
Those 945Gs don't have memory located above 4G, from my reading of the
chipset specs.
--
Eric Anholt
eric@anholt.net eric.anholt@intel.com
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-05-27 17:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 16:27 [PATCH] drm: i915: ensure objects are allocated below 4GB on PAE Kyle McMartin
2009-05-26 16:27 ` Kyle McMartin
2009-05-26 19:17 ` Peter Zijlstra
2009-05-26 19:17 ` Peter Zijlstra
2009-05-26 21:35 ` Eric Anholt
2009-05-26 21:41 ` Peter Zijlstra
2009-05-26 21:41 ` Peter Zijlstra
2009-05-26 21:43 ` Kyle McMartin
2009-05-26 21:43 ` Kyle McMartin
2009-05-26 22:55 ` Hugh Dickins
2009-05-26 22:55 ` Hugh Dickins
2009-05-27 0:18 ` Kyle McMartin
2009-05-27 0:18 ` Kyle McMartin
2009-05-27 0:42 ` Shaohua Li
2009-05-27 0:42 ` Shaohua Li
2009-05-27 17:40 ` Eric Anholt [this message]
2009-05-27 18:23 ` Kyle McMartin
2009-05-27 18:23 ` Kyle McMartin
2009-05-31 0:49 ` Shaohua Li
2009-05-31 0:49 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243446012.8400.37.camel@gaiman.anholt.net \
--to=eric@anholt.net \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.sf.net \
--cc=hugh.dickins@tiscali.co.uk \
--cc=jbarnes@virtuousgeek.org \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaohua.li@intel.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.