Re: [PATCH] fix descriptions for AT_NO_AUTOMOUNT - Alejandro Colomar (man-pages)

From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: "Pádraig Brady" <P@draigBrady.com>,
	"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>
Cc: Gnulib bugs <bug-gnulib@gnu.org>, Coreutils <coreutils@gnu.org>,
	Andreas Schwab <schwab@linux-m68k.org>,
	"Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>,
	Ian Kent <raven@themaw.net>, David Howells <dhowells@redhat.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Colin Walters <walters@redhat.com>,
	Ondrej Holy <oholy@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Neil Brown <neilb@suse.com>, Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH] fix descriptions for AT_NO_AUTOMOUNT
Date: Mon, 14 Mar 2022 23:16:48 +0100	[thread overview]
Message-ID: <12444329-b272-373c-4255-e39584a6716e@gmail.com> (raw)
In-Reply-To: <9488e311-ab35-96ee-7791-ec65fa6fe948@gmail.com>

Hi Pádraig,

On 3/14/22 20:56, Alejandro Colomar (man-pages) wrote:
> Please send the patch inline (or both inline and attached),
> if you don't mind.
> However, if it's a big hassle for you,
> I can apply it from an attachment.

Thanks for the inline patcx.
> ---
> 
>>
>> Subject: [PATCH] fix descriptions for AT_NO_AUTOMOUNT
>>
[...]
>>
>> Signed-off-by: Pádraig Brady <P@draigBrady.com>
> 
> Makes sense to me.
> But see a few minor comments below.

But you missed the comments below :)
Please fix them (see below).

Thanks,

Alex

[...]
>> diff --git a/man2/statx.2 b/man2/statx.2
>> index 04b3e5075..d4e638756 100644
>> --- a/man2/statx.2
>> +++ b/man2/statx.2
>> @@ -195,11 +195,23 @@ Don't automount the terminal ("basename") component of
>>  if it is a directory that is an automount point.
>>  This allows the caller to gather attributes of an automount point
>>  (rather than the location it would mount).
>> -This flag can be used in tools that scan directories
>> -to prevent mass-automounting of a directory of automount points.
>> +This
>> +flag has no effect if the mount point has already been mounted over.
> 
> Weird break point there.
> I see that it was like that in existing code, but please fix it :)

check

> 
>> +.IP
>>  The
>>  .B AT_NO_AUTOMOUNT
>> -flag has no effect if the mount point has already been mounted over.
>> +flag can be used in tools that scan directories
>> +to prevent mass-automounting of a directory of automount points.
>> +.IP
>> +All of
>> +.BR stat () ,
> 
> s/() ,/(2),/

check

> 
>> +.BR lstat () ,
> 
> s/() ,/(2),/

check

> 
>> +and
>> +.BR fstatat ()
> 
> s/()/(2)/

check

> 
>> +act as though
>> +.B AT_NO_AUTOMOUNT
>> +was set.
>> +.IP
>>  This flag is Linux-specific; define
>>  .B _GNU_SOURCE
>>  .\" Before glibc 2.16, defining _ATFILE_SOURCE sufficed
>> -- 
>> 2.31.1
>>
> 
> 

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/