* [PATCH -tip][KVM] x86: kvm/x86_emulate.c toggle_interruptibility() should be static
@ 2009-06-18 11:23 ` Jaswinder Singh Rajput
0 siblings, 0 replies; 6+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-18 11:23 UTC (permalink / raw)
To: Avi Kivity, Ingo Molnar, x86 maintainers, KVM list, LKML
toggle_interruptibility() is used only by same file, it should be static.
Fixed following sparse warning :
arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kvm/x86_emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index c1b6c23..616de46 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -1361,7 +1361,7 @@ static inline int writeback(struct x86_emulate_ctxt *ctxt,
return 0;
}
-void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
+static void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
{
u32 int_shadow = kvm_x86_ops->get_interrupt_shadow(ctxt->vcpu, mask);
/*
--
1.6.0.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -tip]x86: kvm/x86_emulate.c toggle_interruptibility() should be static
@ 2009-06-18 11:23 ` Jaswinder Singh Rajput
0 siblings, 0 replies; 6+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-18 11:23 UTC (permalink / raw)
To: Avi Kivity, Ingo Molnar, x86 maintainers, KVM list, LKML
toggle_interruptibility() is used only by same file, it should be static.
Fixed following sparse warning :
arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kvm/x86_emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index c1b6c23..616de46 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -1361,7 +1361,7 @@ static inline int writeback(struct x86_emulate_ctxt *ctxt,
return 0;
}
-void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
+static void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
{
u32 int_shadow = kvm_x86_ops->get_interrupt_shadow(ctxt->vcpu, mask);
/*
--
1.6.0.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [KVM] x86: kvm/x86_emulate.c toggle_interruptibility() should be static
2009-06-18 11:23 ` [PATCH -tip]x86: " Jaswinder Singh Rajput
@ 2009-06-20 7:48 ` Jaswinder Singh Rajput
-1 siblings, 0 replies; 6+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-20 7:48 UTC (permalink / raw)
To: Avi Kivity; +Cc: Ingo Molnar, x86 maintainers, KVM list, LKML
toggle_interruptibility() is used only by same file, it should be static.
Fixed following sparse warning :
arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kvm/x86_emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index c1b6c23..616de46 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -1361,7 +1361,7 @@ static inline int writeback(struct x86_emulate_ctxt *ctxt,
return 0;
}
-void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
+static void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
{
u32 int_shadow = kvm_x86_ops->get_interrupt_shadow(ctxt->vcpu, mask);
/*
--
1.6.0.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* x86: kvm/x86_emulate.c toggle_interruptibility() should be static
@ 2009-06-20 7:48 ` Jaswinder Singh Rajput
0 siblings, 0 replies; 6+ messages in thread
From: Jaswinder Singh Rajput @ 2009-06-20 7:48 UTC (permalink / raw)
To: Avi Kivity; +Cc: Ingo Molnar, x86 maintainers, KVM list, LKML
toggle_interruptibility() is used only by same file, it should be static.
Fixed following sparse warning :
arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/kvm/x86_emulate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c
index c1b6c23..616de46 100644
--- a/arch/x86/kvm/x86_emulate.c
+++ b/arch/x86/kvm/x86_emulate.c
@@ -1361,7 +1361,7 @@ static inline int writeback(struct x86_emulate_ctxt *ctxt,
return 0;
}
-void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
+static void toggle_interruptibility(struct x86_emulate_ctxt *ctxt, u32 mask)
{
u32 int_shadow = kvm_x86_ops->get_interrupt_shadow(ctxt->vcpu, mask);
/*
--
1.6.0.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -tip][KVM] x86: kvm/x86_emulate.c toggle_interruptibility() should be static
2009-06-18 11:23 ` [PATCH -tip]x86: " Jaswinder Singh Rajput
@ 2009-06-21 12:46 ` Avi Kivity
-1 siblings, 0 replies; 6+ messages in thread
From: Avi Kivity @ 2009-06-21 12:46 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: Ingo Molnar, x86 maintainers, KVM list, LKML
On 06/18/2009 02:23 PM, Jaswinder Singh Rajput wrote:
> toggle_interruptibility() is used only by same file, it should be static.
>
> Fixed following sparse warning :
>
> arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -tip]x86: kvm/x86_emulate.c toggle_interruptibility() should be static
@ 2009-06-21 12:46 ` Avi Kivity
0 siblings, 0 replies; 6+ messages in thread
From: Avi Kivity @ 2009-06-21 12:46 UTC (permalink / raw)
To: Jaswinder Singh Rajput; +Cc: Ingo Molnar, x86 maintainers, KVM list, LKML
On 06/18/2009 02:23 PM, Jaswinder Singh Rajput wrote:
> toggle_interruptibility() is used only by same file, it should be static.
>
> Fixed following sparse warning :
>
> arch/x86/kvm/x86_emulate.c:1364:6: warning: symbol 'toggle_interruptibility' was not declared. Should it be static?
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-06-21 12:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-18 11:23 [PATCH -tip][KVM] x86: kvm/x86_emulate.c toggle_interruptibility() should be static Jaswinder Singh Rajput
2009-06-18 11:23 ` [PATCH -tip]x86: " Jaswinder Singh Rajput
2009-06-20 7:48 ` [KVM] x86: " Jaswinder Singh Rajput
2009-06-20 7:48 ` Jaswinder Singh Rajput
2009-06-21 12:46 ` [PATCH -tip][KVM] " Avi Kivity
2009-06-21 12:46 ` [PATCH -tip]x86: " Avi Kivity
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.