From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOpAi-00038t-Lf for qemu-devel@nongnu.org; Thu, 09 Jul 2009 04:40:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOpAd-00035u-SX for qemu-devel@nongnu.org; Thu, 09 Jul 2009 04:40:03 -0400 Received: from [199.232.76.173] (port=54986 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOpAd-00035m-2n for qemu-devel@nongnu.org; Thu, 09 Jul 2009 04:39:59 -0400 Received: from mx2.redhat.com ([66.187.237.31]:60613) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MOpAc-0000Sx-JT for qemu-devel@nongnu.org; Thu, 09 Jul 2009 04:39:58 -0400 Subject: Re: [Qemu-devel] [PATCH 3/3 v2] Add a pc-0-10 machine type for compatibility with 0.10.x From: Mark McLoughlin In-Reply-To: <4A55A29A.9020202@redhat.com> References: <1244821292.30522.56.camel@blaa> <20090615103249.GB6351@redhat.com> <4A363012.8050409@redhat.com> <20090615114858.GG6351@redhat.com> <4A3636FA.1040609@redhat.com> <20090615124101.GH6351@redhat.com> <4A364381.401@redhat.com> <4A364401.6010500@codemonkey.ws> <4A3647FB.9010808@redhat.com> <4A364B53.9080007@codemonkey.ws> <4A364FE0.40204@redhat.com> <4A3651EB.3070204@codemonkey.ws> <4A36555A.4090303@redhat.com> <4A3659A0.3050108@codemonkey.ws> <4A366348.1030202@redhat.com> <1245083229.3222.103.camel@blaa> <4A368F12.2090504@codemonkey.ws> <1246964898.2836.38.camel@blaa> <1246964950.2836.39.camel@blaa> <1246964998.2836.40.camel@blaa> <1246965054.2836.41.camel@blaa> <4A5338FC.9030301@redhat.com> <1247049984.3270.52.camel@blaa> <1247050083.3270.54.camel@blaa> <4A54986D.301@redhat.com> <4A54A2B0.6050605@codemonk! ey.ws> <4A54A895.5090501@redhat.com> <1247065728.3270.65.camel@blaa> <4A54EE87.2000508@redhat.com> <4A55136E.6050508@codemonkey.ws> <4A55A29A.9020202@redhat.com> Content-Type: text/plain Date: Thu, 09 Jul 2009 09:39:35 +0100 Message-Id: <1247128775.22231.15.camel@blaa> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: Mark McLoughlin List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Avi Kivity , qemu-devel@nongnu.org On Thu, 2009-07-09 at 09:56 +0200, Gerd Hoffmann wrote: > We could have each machine type register a list of default options. > Using qdev properties that should be doable in a fairly generic way, > like this: > > virtio-blk-pci and virtio-console-pci get a "class" property. > virtio-net-pci gets a "msi" property. ide-disk+cdrom gets a > "fw-version" property (well, not yet, when being converted to qdev). > > pc-0.10 could then register a list of default properties, i.e. > something > like > > "virtio-blk-pci" => "class=0x??" > "virtio-console-pci" => "class=0x??" > "virtio-net-pci => "msi=0" > "ide-disk" => "fw-version=0.10.0" > > When creating devices qdev would apply them. > > I can prototype that. > > comments? I think this would be a very nice way of making what I did more generic, but with the same external interface. Time is running short for 0.11, though, so I'd suggest it could be an incremental cleanup on top of the patches I posted. If we're settled on adding '-M pc-0-10', I next want to: 1) add '-M pc-0-11' and make it the default 2) make '-M pc' a symlink to the latest machine type i.e. 'qemu-system-x86_64 -M ?' would give: Supported machines are: pc Standard PC with latest features pc-0-11 Standard PC compatible with qemu 0.11.x (default) pc-0-10 Standard PC compatible with qemu 0.10.x isapc ISA-only PC and libvirt, when creating a guest for the first time would parse this output for the default value and store it in the XML config: hvm Cheers, Mark.