From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E598C43603 for ; Tue, 17 Dec 2019 15:30:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC00A21582 for ; Tue, 17 Dec 2019 15:30:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JcA+49Rb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC00A21582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1860D852; Tue, 17 Dec 2019 16:29:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1860D852 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1576596607; bh=HqfaY6e05pbxFXp3zffIUsh1PxGFqumguWFVbQbPVvE=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JcA+49Rb88Xoz1eCviCY9ugEhcT3YZQeI6mRwTpBC5KdvKvABpS6ddQJfj64kzhbe MdBtUv+NQnGaOWqEHK0pE/7Pa99phTLVteSOfWCesaipcviBQsfQiWyjucues4lulj F9Rg9dvAYEEEtNaG3zmizPrFWFULl9cd99c2vgHM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8C681F8020B; Tue, 17 Dec 2019 16:29:16 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 83221F80234; Tue, 17 Dec 2019 16:29:12 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9CC70F8020B for ; Tue, 17 Dec 2019 16:29:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9CC70F8020B X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 07:29:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,325,1571727600"; d="scan'208";a="212605786" Received: from pbossart-mac02.an.intel.com ([10.122.138.72]) by fmsmga008.fm.intel.com with ESMTP; 17 Dec 2019 07:29:05 -0800 To: Mark Brown , Kuninori Morimoto References: <87woavhhfi.wl-kuninori.morimoto.gx@renesas.com> <87o8w7hhds.wl-kuninori.morimoto.gx@renesas.com> <01e4157a-d4b7-8bb2-d3bf-957d47e3e5f9@linux.intel.com> <87lfrbhajp.wl-kuninori.morimoto.gx@renesas.com> <87k16vh8d6.wl-kuninori.morimoto.gx@renesas.com> <20191217121308.GC4755@sirena.org.uk> From: Pierre-Louis Bossart Message-ID: <124fd50c-db99-7a4a-9e35-ad69b5e16abc@linux.intel.com> Date: Tue, 17 Dec 2019 07:56:28 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20191217121308.GC4755@sirena.org.uk> Content-Language: en-US Cc: Linux-ALSA Subject: Re: [alsa-devel] [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop() X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 12/17/19 6:13 AM, Mark Brown wrote: > On Tue, Dec 17, 2019 at 01:41:09PM +0900, Kuninori Morimoto wrote: > >> I noticed that soc_compr_free_fe(), dpcm_fe_dai_shutdown() are directly >> calling SND_SOC_DAPM_STREAM_STOP without caring pmdown time / delayed work. >> Can we use snd_soc_dapm_stream_stop() for these, too ? > > That does seem like an oversight... What would the rationale for deferring a FE shutdown though? IIRC in the Intel machine drivers we only use .pm_ignore_downtime to backends to keep some clocks on, and even that is questionable (the clock dependencies should be properly modeled instead of hidden with an obscure dailink setting). When I asked why exactly this flag was set in most cases the reason why 'because others did so in the past'... _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel