On Tue, 2009-09-08 at 17:31 -0700, H. Peter Anvin wrote: [...] > I'm wondering if it wouldn't be cleaner to fold the jump into > sync_core() and moving the sync_core() up before local_irq_restore(). Exactly as I suggested below the dashes. :-) The only reason I didn't do that initially was that I don't know whether or not there's a good reason for the current placement of sync_core() after local_irq_restore(). Ben. -- Ben Hutchings Who are all these weirdos? - David Bowie, about L-Space IRC channel #afp