From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932293AbZINV4D (ORCPT ); Mon, 14 Sep 2009 17:56:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757311AbZINV4A (ORCPT ); Mon, 14 Sep 2009 17:56:00 -0400 Received: from mail3.caviumnetworks.com ([12.108.191.235]:9402 "EHLO mail3.caviumnetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755118AbZINVz7 (ORCPT ); Mon, 14 Sep 2009 17:55:59 -0400 From: David Daney To: torvalds@linux-foundation.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, David Daney , Thomas Gleixner , Ingo Molnar , x86@kernel.org Subject: [PATCH 02/11] x86: Convert BUG() to use unreachable() Date: Mon, 14 Sep 2009 14:55:31 -0700 Message-Id: <1252965340-31735-2-git-send-email-ddaney@caviumnetworks.com> X-Mailer: git-send-email 1.6.0.6 In-Reply-To: <4AAEBAC2.1050905@caviumnetworks.com> References: <4AAEBAC2.1050905@caviumnetworks.com> X-OriginalArrivalTime: 14 Sep 2009 21:55:53.0590 (UTC) FILETIME=[21690160:01CA3586] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the new unreachable() macro instead of for(;;);. When allyesconfig is built with a GCC-4.5 snapshot on i686 the size of the text segment is reduced by 3987 bytes (from 6827019 to 6823032). Signed-off-by: David Daney Acked-by: "H. Peter Anvin" CC: Thomas Gleixner CC: Ingo Molnar CC: x86@kernel.org --- arch/x86/include/asm/bug.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h index d9cf1cd..f654d1b 100644 --- a/arch/x86/include/asm/bug.h +++ b/arch/x86/include/asm/bug.h @@ -22,14 +22,14 @@ do { \ ".popsection" \ : : "i" (__FILE__), "i" (__LINE__), \ "i" (sizeof(struct bug_entry))); \ - for (;;) ; \ + unreachable(); \ } while (0) #else #define BUG() \ do { \ asm volatile("ud2"); \ - for (;;) ; \ + unreachable(); \ } while (0) #endif -- 1.6.2.5