Re: [PATCH 2/2] tracing: Export ftrace API for kernel modules

From: Peter Zijlstra <peterz@infradead.org>
To: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
	Ingo Molnar <mingo@elte.hu>,
	fweisbec@gmail.com, "Frank Ch. Eigler" <fche@redhat.com>,
	paulus@samba.org, systemtap@sources.redhat.com
Subject: Re: [PATCH 2/2] tracing: Export ftrace API for kernel modules
Date: Tue, 15 Sep 2009 12:11:19 +0200	[thread overview]
Message-ID: <1253009479.5506.38.camel@laptop> (raw)
In-Reply-To: <4AAF6728.6010807@bk.jp.nec.com>

On Tue, 2009-09-15 at 19:06 +0900, Atsushi Tsuji wrote:
> Export register_ and unresgister_ftrace_function_probe to modules. This can
> be used by SystemTap.

Its unusual to export bits without an in-kernel user.

> Signed-off-by: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>
> ---
>  kernel/trace/ftrace.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 5ef8f59..9c32291 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -2042,6 +2042,7 @@ register_ftrace_function_probe(char *glob, struct ftrace_probe_ops *ops,
>  
>  	return count;
>  }
> +EXPORT_SYMBOL_GPL(register_ftrace_function_probe);
>  
>  enum {
>  	PROBE_TEST_FUNC		= 1,
> @@ -2108,6 +2109,7 @@ unregister_ftrace_function_probe(char *glob, struct ftrace_probe_ops *ops,
>  	__unregister_ftrace_function_probe(glob, ops, data,
>  					  PROBE_TEST_FUNC | PROBE_TEST_DATA);
>  }
> +EXPORT_SYMBOL_GPL(unregister_ftrace_function_probe);
>  
>  void
>  unregister_ftrace_function_probe_func(char *glob, struct ftrace_probe_ops *ops)